[FIX] Slack importer Link handling #17595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-lehnen-rc
approved these changes
May 12, 2020
Contributor
Author
|
@pierre-lehnen-rc Could you re-approve? Tested it more thoroughly now, it should work. And if you could merge it as a hotfix of 3.2.1 or so, that would be great :) |
pierre-lehnen-rc
approved these changes
May 18, 2020
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jun 1, 2020
…rewrite_admin_sidebar * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) Readme: Update Raspberry Pi 2 to Pi 4 (#17031) [NEW] Accept variable `#{userdn}` on LDAP group filter (#16273) [FIX] Spotify embed link opens in same tab (#13637) [FIX] Markdown links not accepting URLs with parentheses (#13605) [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (#14912) [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (#15106) [NEW] Skip Export Operations that haven't been updated in over a day (#16135) [NEW] Highlight matching words in message search results (#16166) [FIX] Set `x-content-type-options: nosniff` header (#16232) [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (#16262) Fixes some italian word (#14008) Bump version to 3.4.0-develop Bump version to 3.3.0 Bump version to 3.3.0-rc.4 Bump version to 3.3.0-rc.3 Bump version to 3.3.0-rc.2 Bump version to 3.3.0-rc.1 Bump version to 3.3.0-rc.0 [FIX] Slack importer Link handling (#17595) Bump version to 3.2.2 ...
gabriellsh
added a commit
that referenced
this pull request
Jun 1, 2020
…into new/apps_rewrite * 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: (31 commits) Readme: Update Raspberry Pi 2 to Pi 4 (#17031) [NEW] Accept variable `#{userdn}` on LDAP group filter (#16273) [FIX] Spotify embed link opens in same tab (#13637) [FIX] Markdown links not accepting URLs with parentheses (#13605) [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (#14912) [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (#15106) [NEW] Skip Export Operations that haven't been updated in over a day (#16135) [NEW] Highlight matching words in message search results (#16166) [FIX] Set `x-content-type-options: nosniff` header (#16232) [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (#16262) Fixes some italian word (#14008) Submit a payload to the release service when a release happens (#17775) Bump version to 3.4.0-develop Bump version to 3.3.0 Bump version to 3.3.0-rc.4 Bump version to 3.3.0-rc.3 Bump version to 3.3.0-rc.2 Bump version to 3.3.0-rc.1 Bump version to 3.3.0-rc.0 [FIX] Slack importer Link handling (#17595) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply changed order of link import to prefer simple links and avoid FUBAR message text after import (cf. issue).
Closes #17594