[FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) #18147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tChat#18105) Closes: RocketChat#18105 Related: RocketChat#17801 Steps to reproduce: 1. Start server with ROOT_URL http://localhost:3000/rc 2. Navigate to /rc/admin Before: 3. Observe admin closes After: 3. Observe admin remains open Additional test cases: 1. Start server with ROOT_URL http://localhost:3000 2. Navigate to /admin 3. Observer admin remains open
ggazzo
approved these changes
Jul 4, 2020
gabriellsh
added a commit
that referenced
this pull request
Jul 6, 2020
…into new/rewrite_account_profile * 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat: [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147) [FIX] App details returns to apps table, instead of previous page (#18080) [FIX] Clipboard not working when permalinking a pinned message (#18047) [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110) [FIX] Jitsi opening twice (#18111) [FIX] Email notifications were still being sent for online users (#18088) [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
gabriellsh
added a commit
that referenced
this pull request
Jul 6, 2020
…ocket.Chat into rewrite/user_preferences * 'new/rewrite_account_profile' of github.com:RocketChat/Rocket.Chat: [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147) [FIX] App details returns to apps table, instead of previous page (#18080) [FIX] Clipboard not working when permalinking a pinned message (#18047) [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110) [FIX] Jitsi opening twice (#18111) [FIX] Email notifications were still being sent for online users (#18088) [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
rodrigok
pushed a commit
that referenced
this pull request
Jul 10, 2020
Merged
Merged
ggazzo
added a commit
that referenced
this pull request
Jul 28, 2020
* [FIX] Jitsi opening twice (#18111) * [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110) * [FIX] Avatar ETag missing from User (#18109) * Handle callback returning promise. (#18102) * [FIX] Not possible to read encrypted messages after disable E2E on channel level (#18101) * [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090) * [FIX] Email notifications were still being sent for online users (#18088) * Bump version to 3.4.1 * [FIX] App details returns to apps table, instead of previous page (#18080) * [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147) * [FIX] Old Data Migrations breaking upgrades (#18185) * [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222) * [FIX] SAML login crashing when receiving an array of roles (#18224) * [FIX] CAS login not merging users with local accounts (#18238) * Bump version to 3.4.2 * Bump version to 3.5.0-rc.0 * Bump version to 3.5.0-rc.1 * Bump version to 3.5.0-rc.2 * Bump version to 3.5.0-rc.3 * Bump version to 3.5.0-rc.4 * Bump version to 3.5.0 * Bump version to 3.6.0-develop Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Maria Eduarda Cunha <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Paulo Bernardo <[email protected]> Co-authored-by: Denis <[email protected]> Co-authored-by: Omar Chehab <[email protected]> Co-authored-by: pierre-lehnen-rc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18105
Closes #18214
Related: #17801
Steps to reproduce:
Before:
After:
Additional test cases:
Types of changes
Checklist
Changelog
Fixed cannot open admin when server uses ROOT_URL with subpath
Further comments