fix: test case 11 and 12 flaky tests by OtavioStasiak · Pull Request #7564 · RocketChat/Rocket.Chat.ReactNative

OtavioStasiak · 2026-08-10T23:37:58Z

Proposed changes

Fix test case 11 and 12 failing on CI.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1488

How to test or reproduce

Run e2e tests;

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Bug Fixes
- Improved emoji autocomplete selection reliability.
- Prevented unnecessary keyboard dismissal on iOS when selecting reactions.
- Improved quoted-message interactions during message navigation.
Tests
- Improved room navigation coverage across activity-sorted room lists.
- Increased reliability when testing long threads, older messages, scrolling, message search, and cross-room thread navigation.

coderabbitai · 2026-08-10T23:38:32Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a36cca2-2466-4330-971f-7ff64e1a2e30

📥 Commits

Reviewing files that changed from the base of the PR and between 957b9df and ca76d3c.

📒 Files selected for processing (1)

.maestro/tests/room/room-last-message-thread-50-plus.yaml

💤 Files with no reviewable changes (1)

.maestro/tests/room/room-last-message-thread-50-plus.yaml

📜 Recent review details

⏰ Context from checks skipped due to timeout. (3)

GitHub Check: format
GitHub Check: ESLint and Test / run-eslint-and-test
GitHub Check: E2E Shard Preflight

Walkthrough

The room tests now wait for emoji autocomplete results, dismiss the keyboard only on Android, use search-based room navigation, and target quoted replies by reply element IDs.

Changes

Room test reliability

Layer / File(s)	Summary
Autocomplete and keyboard flow `.maestro/tests/room/room.yaml`	The test waits for `autocomplete-item-joystick` before selecting `autocomplete-item-joy`. Keyboard dismissal now runs only on Android.
Search-based room navigation and reply targeting `.maestro/tests/room/room-last-message-thread-50-plus.yaml`, `.maestro/tests/room/jump-to-message.yaml`	Room fixtures use `search-and-navigate-room.yaml` instead of `navigate-to-room.yaml`. Quoted-message actions target reply element IDs.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the pull request as a fix for flaky test cases 11 and 12, matching the stated objectives and changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

NATIVE-1488: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

* fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment

* fix: render mentions, emojis, and inline elements inside headings (#6911) * chore: OXC (#7515) * chore: replace ESLint with Oxlint Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid. * chore: replace Prettier with Oxfmt Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean. * chore: update lockfile for oxfmt * chore: migrate typecheck to TypeScript 7.0 (#7516) * chore: bump TypeScript to 6.0 Baseline hop ahead of the TypeScript 7.0 (native compiler) migration, so the 7.0 cut is a version swap against a config that is already 7.0-shaped. TypeScript 6.0 raises both `moduleResolution: node10` and `baseUrl` as errors rather than warnings, and `ignoreDeprecations: "6.0"` stops working in 7.0, so clearing them properly is the only route: - `moduleResolution` -> `bundler` (Metro is a bundler), which requires an esnext-shaped `module`. - `baseUrl` removed. Exactly one import relied on it; it is now relative. - `types` enumerated, since a resolution mode that honours package `exports` no longer auto-includes every `@types` package. `@types/node` becomes an explicit devDependency. Honouring `exports` also stranded the bundled `.d.ts` of three dependencies whose maps expose only JavaScript. Each gets a `types` condition via patch-package; this is visible to the type checker only, as Metro ignores that condition. A `paths` mapping was tried first and rejected, because the jest-expo resolver reads `paths` and then loads those `.d.ts` files at runtime. The inherited block of commented-out option documentation is dropped. * chore: migrate typecheck to TypeScript 7.0 Replaces TypeScript 6.0.3 with the native Go compiler. The version is pinned exactly, since the platform binaries ship as version-matched optional dependencies; the lockfile records the linux-x64 target CI resolves. Typecheck wall time drops from 5.77s on 5.9.3 to ~1.0s. No configuration change was required: the 6.0 hop already left tsconfig in a 7.0-shaped state, and the default parallelism saturates without `--checkers`. `@react-navigation/core` needs a patch to type-check. TypeScript 7.0.2 resolves the mutual recursion between `StaticParamList` and `ParamListForScreens` eagerly where earlier versions defer it, reports the alias as circular, and degrades it to a non-generic symbol -- surfacing as `TS2315: Type 'StaticParamList' is not generic` at our call sites. The patch drops a `FlatType<>` wrapper from the alias, which only flattens intersections for editor display, so the type is unchanged and the misfire stops. * chore: Bump version to 4.76.0 (#7542) * chore(ci): apply least privilege permission to GitHub Actions (#7350) * chore: switch React Compiler to infer mode (#7545) * ci: route Maestro e2e selection through sniffler impact analysis (#7476) * fix(iOS): RoomItem Swipe not working after scroll (#7532) * fix(ci): select shards for changes outside app and honor the release label (#7555) * fix: delete background taller than its row on ServersHistory (#7536) * fix: delete background taller than its row on server items * chore: code improvements --------- Co-authored-by: Diego Mello <diegolmello@gmail.com> * fix: UIKit block messages rendering with smaller font size (#7531) * fix: UIKit block messages rendering with smaller font size * fix: snapshot * fix(db): move deleteMessage finds and prepares inside the writer lock (#7550) * fix: quote has no effect on older thread messages (#7535) * fix: Quote has no effect on older thread messages * fix: Quote has no effect on older thread messages * chore: e2e test * fix: e2e test * chore: format code and fix lint issues * fix(MessageComposer): resolve quoted thread messages and guard stale lookups * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(db): move persistMessage lookups and prepares inside the writer lock (#7551) * fix: test case 11 and 12 flaky tests (#7564) * fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment * fix(db): move sendMessage reads and prepares inside the writer lock (#7546) * fix(db): move sendMessage reads and prepares inside the writer lock * fix: test improvements * chore: remove comments * fix: Admin Panel content hidden behind bottom navigation bar (#7538) * feat: add tabular numbers (#7568) * feat: tabular numbers across the app, upgrade Inter to 4.1 * update snapshot * chore: pin @rocket.chat/sdk to a specific commit hash (#7569) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE (#7554) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE * code improvements * removed unused comment * fix: run handleDelete finds and prepares inside the writer lock (#7552) * fix: run handleDelete finds and prepares inside the writer lock * chore: reuse mockWMDB * fix: crop screen hidden behind navigation bar on iOS 26 (#7529) * fix: re-fetch message inside the write in getThreadName (#7557) * fix: re-fetch message inside the write in getThreadName * fix: re-fetch message inside the write in getThreadName * chore: new test cases * remove unecessary async * fix(db): move decryptPendingMessages prepares inside the writer lock (#7548) * fix(db): move decryptPendingMessages prepares inside the writer lock * code improvements * chore: new test case encryption * chore: format code and fix lint issues --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(android): VideoConf notification accept and decline button hidden and touch not working (#7533) * fix: in-app notification buttons ignoring taps on Android * fix: Decline and Accept invisible on the incoming call notification * fix: UIKit buttons not responding on some Android devices (#7573) * fix: force Google account chooser on OAuth login (#7572) * fix: ISO format support in markdown component (#6943) * fix: resolve deep links by room id for channels and groups (#7111) * Merge pull request #7570 from RocketChat/deeplink-saml-auth feat: SAML deeplink auth * fix: grant pull-requests write to build call sites in build-develop (#7599) The reusable workflows build-android.yml and build-ios.yml declare pull-requests: write on their upload jobs. GitHub validates these at call time regardless of job conditionals, so build-develop.yml (caller) must grant the permission or the workflow fails validation. build-pr.yml already grants it; this mirrors that. --------- Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com> Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>

fix: test

14cef71

coderabbitai Bot added the type: bug label Aug 10, 2026

OtavioStasiak temporarily deployed to approve_e2e_testing August 10, 2026 23:39 — with GitHub Actions Inactive

OtavioStasiak had a problem deploying to ios_build August 10, 2026 23:42 — with GitHub Actions Error

OtavioStasiak had a problem deploying to android_build August 10, 2026 23:42 — with GitHub Actions Error

OtavioStasiak had a problem deploying to ios_build August 11, 2026 15:59 — with GitHub Actions Error

OtavioStasiak had a problem deploying to android_build August 11, 2026 15:59 — with GitHub Actions Error

fix: room last messa test

f396102

OtavioStasiak temporarily deployed to approve_e2e_testing August 11, 2026 17:12 — with GitHub Actions Inactive

coderabbitai Bot added type: chore and removed type: bug labels Aug 11, 2026

OtavioStasiak had a problem deploying to ios_build August 11, 2026 17:14 — with GitHub Actions Error

OtavioStasiak had a problem deploying to android_build August 11, 2026 17:14 — with GitHub Actions Error

fix: jumptomessage test

34fcac5

OtavioStasiak temporarily deployed to approve_e2e_testing August 11, 2026 17:59 — with GitHub Actions Inactive

OtavioStasiak had a problem deploying to ios_build August 11, 2026 18:01 — with GitHub Actions Error

OtavioStasiak had a problem deploying to android_build August 11, 2026 18:01 — with GitHub Actions Error

diegolmello requested changes Aug 11, 2026

View reviewed changes

Comment thread .maestro/tests/room/room.yaml Outdated

Comment thread .maestro/tests/room/room.yaml Outdated

diegolmello requested changes Aug 11, 2026

View reviewed changes

Comment thread .maestro/tests/room/jump-to-message.yaml Outdated

chore: remove comments

f997e8e

OtavioStasiak had a problem deploying to android_build August 11, 2026 22:20 — with GitHub Actions Error

OtavioStasiak had a problem deploying to ios_build August 11, 2026 22:20 — with GitHub Actions Error

OtavioStasiak and others added 2 commits August 12, 2026 11:44

fix: jump to message e2e test iOS

a454787

Merge branch 'develop' into fix.flaky-test-room

957b9df

OtavioStasiak temporarily deployed to approve_e2e_testing August 12, 2026 14:47 — with GitHub Actions Inactive

OtavioStasiak had a problem deploying to android_build August 12, 2026 14:50 — with GitHub Actions Error

OtavioStasiak had a problem deploying to ios_build August 12, 2026 14:50 — with GitHub Actions Error

OtavioStasiak changed the title ~~fix: Room flaky test~~ fix: test case 11 and 12 flaky tests Aug 12, 2026

remove unused comment

d598e22

Merge branch 'develop' into fix.flaky-test-room

ca76d3c

OtavioStasiak temporarily deployed to approve_e2e_testing August 12, 2026 17:38 — with GitHub Actions Inactive

OtavioStasiak had a problem deploying to android_build August 12, 2026 17:40 — with GitHub Actions Error

OtavioStasiak had a problem deploying to ios_build August 12, 2026 17:40 — with GitHub Actions Error

diegolmello approved these changes Aug 12, 2026

View reviewed changes

Merge branch 'develop' into fix.flaky-test-room

48d57b2

OtavioStasiak requested a deployment to approve_e2e_testing August 12, 2026 19:43 — with GitHub Actions Waiting

OtavioStasiak merged commit 2257425 into develop Aug 12, 2026
8 of 9 checks passed

OtavioStasiak deleted the fix.flaky-test-room branch August 12, 2026 19:44

OtavioStasiak requested a deployment to ios_build August 12, 2026 19:45 — with GitHub Actions Waiting

OtavioStasiak requested a deployment to android_build August 12, 2026 19:45 — with GitHub Actions Waiting

OtavioStasiak added a commit that referenced this pull request Aug 13, 2026

fix: test case 11 and 12 flaky tests (#7564)

879fe0e

* fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment

Navigation Menu

Uh oh!

fix: test case 11 and 12 flaky tests - #7564

fix: test case 11 and 12 flaky tests#7564
OtavioStasiak merged 9 commits into
developfrom
fix.flaky-test-room

OtavioStasiak commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Reviews paused

Review ran into problems

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

OtavioStasiak commented Aug 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Review ran into problems

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OtavioStasiak commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading