fix: quote has no effect on older thread messages - #7535
Merged
Conversation
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
July 31, 2026 18:36 — with 
GitHub Actions
Error
GitHub Actions
Error
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThread-aware quoting now passes ChangesThread-aware quoting
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MessageComposer
participant prepareQuoteMessage
participant getMessageById
participant getThreadMessageById
MessageComposer->>prepareQuoteMessage: pass selected messages and tmid
prepareQuoteMessage->>getMessageById: load message with tmid
getMessageById->>getThreadMessageById: check thread message
getThreadMessageById-->>getMessageById: return thread message or no result
getMessageById-->>prepareQuoteMessage: return quoted message
prepareQuoteMessage-->>MessageComposer: prepare quote
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/containers/MessageComposer/hooks/useMessage.ts (1)
7-19: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winTrack
tmidin the effect lifecycle.The effect closes over
tmid, but Line 19 does not include it in the dependency list. If the room thread scope changes after mount, the hook does not reload the message. Guard the state update with a cleanup flag so an earlier lookup cannot overwrite a newer result.Proposed fix
useEffect(() => { + let isCurrent = true; const load = async () => { const result = await getMessageById(messageId, tmid); - if (result) { + if (isCurrent && result) { setMessage(result); } }; load(); - }, [messageId]); + return () => { + isCurrent = false; + }; + }, [messageId, tmid]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/containers/MessageComposer/hooks/useMessage.ts` around lines 7 - 19, Update the useMessage effect to include tmid in its dependency list and add a cleanup flag that prevents an earlier getMessageById lookup from calling setMessage after the effect is superseded. Preserve updates for the currently active messageId and thread scope.Sources: Coding guidelines, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/lib/database/services/Message.ts`:
- Around line 8-18: Update getMessageById to reject only a missing messageId,
allowing calls without tmid to continue to the main messages collection lookup.
Keep getThreadMessageById conditional on tmid being present, then preserve the
existing main-collection fallback for non-thread messages.
---
Outside diff comments:
In `@app/containers/MessageComposer/hooks/useMessage.ts`:
- Around line 7-19: Update the useMessage effect to include tmid in its
dependency list and add a cleanup flag that prevents an earlier getMessageById
lookup from calling setMessage after the effect is superseded. Preserve updates
for the currently active messageId and thread scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8c03ad2b-2b73-4ea6-ba10-9f8479da35dd
📒 Files selected for processing (8)
app/containers/MessageComposer/MessageComposer.tsxapp/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.tsapp/containers/MessageComposer/hooks/useMessage.tsapp/lib/database/services/Message.test.tsapp/lib/database/services/Message.tsapp/lib/methods/getPermalinks.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: ESLint and Test / run-eslint-and-test
- GitHub Check: format
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/hooks/useMessage.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/services/Message.test.tsapp/lib/methods/getPermalinks.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/lib/database/services/Message.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
Files:
app/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/hooks/useMessage.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/services/Message.test.tsapp/lib/methods/getPermalinks.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/lib/database/services/Message.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{js,jsx,ts,tsx}: Before committing changes to JavaScript or TypeScript files, runpnpm prettier-lintandTZ=UTC pnpm testfor the modified files.
Use the local-first data flow: the UI reads from WatermelonDB, while sagas synchronize data with the server.
Use Redux and Redux-Saga for global or server state, and use Zustand for feature-local stores; do not assume all state is in Redux.
Files:
app/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/hooks/useMessage.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/services/Message.test.tsapp/lib/methods/getPermalinks.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/lib/database/services/Message.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.ts
🧠 Learnings (3)
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/hooks/useMessage.tsapp/containers/MessageComposer/MessageComposer.tsxapp/lib/database/services/Message.test.tsapp/lib/methods/getPermalinks.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/lib/database/services/Message.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.ts
📚 Learning: 2026-06-25T18:37:44.793Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.tsx:101-141
Timestamp: 2026-06-25T18:37:44.793Z
Learning: In the Rocket.Chat React Native codebase, do not treat passing an `async` function directly to an event prop in React/React Native UI components (e.g., `onPress={async () => ...}` in TSX) as a “floating promises” CI-blocking lint issue—this repo does not enable the ESLint `no-floating-promises` rule (while `no-void` is enforced). Only raise robustness follow-ups when there are genuinely unhandled promise paths (e.g., fire-and-forget calls like `save()` that return a Promise that is neither awaited nor handled), and prefer making sure failure paths are explicitly handled/reported rather than blocking on lint-style floating-promise concerns.
Applied to files:
app/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/MessageComposer.tsx
📚 Learning: 2026-06-25T18:37:25.526Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.test.tsx:16-22
Timestamp: 2026-06-25T18:37:25.526Z
Learning: In Rocket.Chat ReactNative tests that mock selectors for `useAppSelector`, don’t require the mocked selector input to be typed as `IApplicationState` when the fixture only includes a partial Redux state slice (e.g., only `server` and `settings`). Requiring the full `IApplicationState` type in that scenario forces unsafe `as IApplicationState` casts and undermines type-safety. For these narrowly scoped selector-mock fixtures, use a less strict type (e.g., `any`) to keep the mock focused on the slice under test.
Applied to files:
app/lib/database/services/Message.test.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.ts
🪛 React Doctor (0.9.1)
app/containers/MessageComposer/hooks/useMessage.ts
[error] 11-11: This setter runs after await, so overlapping re-runs of the effect can resolve out of order and write stale state; gate it behind a cancellation/ignore flag or return a cleanup that cancels the work.
In a useEffect whose dependencies can change, guard any setter call that runs after an await behind a cancellation/ignore flag, or return a cleanup that cancels the async work.
(no-set-state-after-await-in-effect)
🔇 Additional comments (6)
app/lib/database/services/Message.test.ts (1)
32-100: LGTM!app/containers/MessageComposer/components/Quotes/Quote.tsx (1)
16-17: LGTM!app/containers/MessageComposer/helpers/prepareQuoteMessage.ts (1)
6-14: LGTM!app/lib/methods/getPermalinks.ts (1)
2-2: LGTM!Also applies to: 21-21
app/containers/MessageComposer/helpers/prepareQuoteMessage.test.ts (1)
84-84: LGTM!Also applies to: 165-204
app/containers/MessageComposer/MessageComposer.tsx (1)
128-128: LGTM!Also applies to: 152-152
OtavioStasiak
temporarily deployed
to
approve_e2e_testing
July 31, 2026 18:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/lib/database/services/Message.ts (1)
8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd an explicit return type to
getMessageById.The function declares parameter types but relies on inference for its exported return type. Add the concrete
Promise<... | null>type that covers both message-model results.As per coding guidelines,
**/*.{ts,tsx}requires explicit type annotations for function parameters and return types.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/lib/database/services/Message.ts` at line 8, Update the exported getMessageById function with an explicit Promise return type covering both possible message-model result types and null, while preserving its existing behavior and parameter types.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/lib/database/services/Message.ts`:
- Line 8: Update the exported getMessageById function with an explicit Promise
return type covering both possible message-model result types and null, while
preserving its existing behavior and parameter types.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 78fedddf-d8c0-4725-9873-529ed4421d1f
📒 Files selected for processing (1)
app/lib/database/services/Message.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: ESLint and Test / run-eslint-and-test
- GitHub Check: format
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/lib/database/services/Message.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
Files:
app/lib/database/services/Message.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{js,jsx,ts,tsx}: Before committing changes to JavaScript or TypeScript files, runpnpm prettier-lintandTZ=UTC pnpm testfor the modified files.
Use the local-first data flow: the UI reads from WatermelonDB, while sagas synchronize data with the server.
Use Redux and Redux-Saga for global or server state, and use Zustand for feature-local stores; do not assume all state is in Redux.
Files:
app/lib/database/services/Message.ts
🧠 Learnings (1)
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/lib/database/services/Message.ts
🔇 Additional comments (2)
app/lib/database/services/Message.ts (2)
9-18: LGTM!
8-18: 📐 Maintainability & Code QualityConfirm the required TypeScript validation commands.
Run
pnpm prettier-lintandTZ=UTC pnpm testfor the modified files before commit.As per coding guidelines,
**/*.{js,jsx,ts,tsx}requires both commands before committing changes.Source: Coding guidelines
OtavioStasiak
temporarily deployed
to
android_build
July 31, 2026 18:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
OtavioStasiak
had a problem deploying
to
upload_android
July 31, 2026 19:55 — with
GitHub Actions
Error
GitHub Actions
Error
|
Android Build Available Rocket.Chat 4.75.0.109471 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQEp3T7dOmpxE8rSBxyXhNBgGhWPC9Mp-A1Kf-Izsg_2V74D4kDeBGn_sEzfDLpzDarDC7pQppdEhH6zAoi |
|
iOS Build Available Rocket.Chat 4.75.0.109473 |
OtavioStasiak
had a problem deploying
to
upload_android
July 31, 2026 21:28 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
July 31, 2026 21:32 — with
GitHub Actions
Error
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.maestro/tests/room/quote-thread-message.yaml (1)
29-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse contains patterns for all Maestro selectors.
Replace each exact
idortextselector with.*value.*. Add the missing leading.*tocomposer-quote-.*andcomposer-quote-remove-.*.This makes the flow consistent with the Maestro selector convention and prevents failures when the rendered value has additional text.
Example change
- tapOn: - id: 'room-view-messages' + id: '.*room-view-messages.*'Based on learnings, use
.*keyword.*for all Maestrotextandidselectors.Also applies to: 69-77, 81-110
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.maestro/tests/room/quote-thread-message.yaml around lines 29 - 50, Update all Maestro selectors in the quote-thread flow, including the referenced later ranges, to use contains patterns by wrapping every id and text value with .* on both sides. Ensure composer-quote-.* and composer-quote-remove-.* include the missing leading wildcard, while preserving the existing actions and flow.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.maestro/tests/room/quote-thread-message.yaml:
- Around line 29-50: Update all Maestro selectors in the quote-thread flow,
including the referenced later ranges, to use contains patterns by wrapping
every id and text value with .* on both sides. Ensure composer-quote-.* and
composer-quote-remove-.* include the missing leading wildcard, while preserving
the existing actions and flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c4ef10b2-d107-4270-90ff-f9a638e556ab
📒 Files selected for processing (1)
.maestro/tests/room/quote-thread-message.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: ESLint and Test / run-eslint-and-test
- GitHub Check: format
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-03-05T14:28:10.004Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6997
File: .maestro/tests/room/message-markdown-click.yaml:28-39
Timestamp: 2026-03-05T14:28:10.004Z
Learning: In Maestro YAML selector fields (text, id) within the Rocket.Chat React Native repository, use the contains pattern '.*keyword.*' (leading and trailing '.*') for matching text. The pattern '.*keyword*.' is incorrect and will fail to match cases where the keyword appears at the end of the element's text. This guideline applies to all Maestro YAML selector fields across the codebase.
Applied to files:
.maestro/tests/room/quote-thread-message.yaml
📚 Learning: 2026-03-17T19:15:26.536Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6970
File: .maestro/tests/room/share-message.yaml:77-79
Timestamp: 2026-03-17T19:15:26.536Z
Learning: In YAML test files under .maestro/tests/room, use tapping the empty area (e.g., tapOn: point: 5%,10%) to dismiss both the bottom sheet and keyboard when needed. Do not rely on action-sheet-handle alone if the keyboard also needs to be dismissed in the same step. This pattern is acceptable for tests where a single tap should close both UI elements.
Applied to files:
.maestro/tests/room/quote-thread-message.yaml
🔇 Additional comments (1)
.maestro/tests/room/quote-thread-message.yaml (1)
1-22: LGTM!Also applies to: 53-66
OtavioStasiak
had a problem deploying
to
android_build
July 31, 2026 21:36 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
July 31, 2026 21:39 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
July 31, 2026 21:43 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
August 3, 2026 17:20 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
temporarily deployed
to
approve_e2e_testing
August 3, 2026 17:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
OtavioStasiak
had a problem deploying
to
android_build
August 3, 2026 17:24 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
requested a deployment
to
ios_build
August 3, 2026 17:24 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
app/containers/MessageComposer/hooks/useMessage.ts (1)
10-10: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the explicit return type to
load.Declare the local async function as
async (): Promise<void>.As per coding guidelines, TypeScript functions must use explicit parameter and return type annotations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/containers/MessageComposer/hooks/useMessage.ts` at line 10, Update the local load function declaration in useMessage to include the explicit async return type Promise<void>, while preserving its existing parameters and implementation.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/containers/MessageComposer/hooks/useMessage.ts`:
- Line 11: Update the asynchronous load logic in useMessage so each request is
cancellable or tracks an active cleanup state; after awaiting getMessageById,
call setMessage only if that request is still current. Ensure the effect cleanup
invalidates obsolete loads when messageId or tmid changes.
- Line 11: Update the lookup flow in useMessage so getMessageById is protected
by try/catch, handling rejected thread and regular-message lookups consistently.
Also update the load() invocation to explicitly handle its returned promise with
catch or awaiting, without using void load(), while preserving the existing
success behavior.
- Around line 7-11: Update the useMessage effect to depend on both messageId and
tmid so it reloads when either lookup input changes, and replace the conditional
result guard with state assignment using result ?? undefined to clear stale
messages when no result is returned.
---
Nitpick comments:
In `@app/containers/MessageComposer/hooks/useMessage.ts`:
- Line 10: Update the local load function declaration in useMessage to include
the explicit async return type Promise<void>, while preserving its existing
parameters and implementation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bc6b344e-fd6d-4a60-92e2-ebd41a5aab17
📒 Files selected for processing (9)
.maestro/tests/room/quote-thread-message.yamlapp/containers/MessageComposer/MessageComposer.tsxapp/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/helpers/prepareQuoteMessage.test.tsapp/containers/MessageComposer/helpers/prepareQuoteMessage.tsapp/containers/MessageComposer/hooks/useMessage.tsapp/lib/database/services/Message.test.tsapp/lib/database/services/Message.tsapp/lib/methods/getPermalinks.ts
🚧 Files skipped from review as they are similar to previous changes (8)
- app/containers/MessageComposer/MessageComposer.tsx
- app/lib/methods/getPermalinks.ts
- app/containers/MessageComposer/helpers/prepareQuoteMessage.ts
- app/lib/database/services/Message.test.ts
- app/containers/MessageComposer/helpers/prepareQuoteMessage.test.ts
- app/containers/MessageComposer/components/Quotes/Quote.tsx
- app/lib/database/services/Message.ts
- .maestro/tests/room/quote-thread-message.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: ESLint and Test / run-eslint-and-test
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/containers/MessageComposer/hooks/useMessage.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
Files:
app/containers/MessageComposer/hooks/useMessage.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{js,jsx,ts,tsx}: Format JavaScript and TypeScript code with Oxfmt using the repository configuration: tabs, single quotes, 130-character width, no trailing commas, omitted arrow-function parentheses where possible, and same-line brackets.
Follow Oxlint rules configured in.oxlintrc.json, including the import, React, Jest, TypeScript, and React Native plugins.
Files:
app/containers/MessageComposer/hooks/useMessage.ts
🧠 Learnings (1)
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/containers/MessageComposer/hooks/useMessage.ts
🪛 React Doctor (0.9.3)
app/containers/MessageComposer/hooks/useMessage.ts
[error] 9-9: This setter runs after await, so overlapping re-runs of the effect can resolve out of order and write stale state; gate it behind a cancellation/ignore flag or return a cleanup that cancels the work.
In a useEffect whose dependencies can change, guard any setter call that runs after an await behind a cancellation/ignore flag, or return a cleanup that cancels the async work.
(no-set-state-after-await-in-effect)
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
August 10, 2026 18:04 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
August 10, 2026 18:09 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
ios_build
August 10, 2026 18:11 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
August 10, 2026 18:11 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
approve_e2e_testing
August 10, 2026 19:13 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
August 10, 2026 19:16 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
ios_build
August 10, 2026 19:16 — with
GitHub Actions
Error
GitHub Actions
Error
diegolmello
approved these changes
Aug 11, 2026
OtavioStasiak
temporarily deployed
to
approve_e2e_testing
August 11, 2026 18:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
OtavioStasiak
had a problem deploying
to
ios_build
August 11, 2026 18:49 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
August 11, 2026 18:49 — with
GitHub Actions
Error
GitHub Actions
Error
10 tasks
OtavioStasiak
had a problem deploying
to
ios_build
August 12, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
had a problem deploying
to
android_build
August 12, 2026 14:45 — with
GitHub Actions
Error
GitHub Actions
Error
OtavioStasiak
requested a deployment
to
approve_e2e_testing
August 12, 2026 16:12 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
OtavioStasiak
requested a deployment
to
ios_build
August 12, 2026 16:14 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
OtavioStasiak
requested a deployment
to
android_build
August 12, 2026 16:14 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
diegolmello
added a commit
that referenced
this pull request
Aug 31, 2026
* fix: render mentions, emojis, and inline elements inside headings (#6911) * chore: OXC (#7515) * chore: replace ESLint with Oxlint Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid. * chore: replace Prettier with Oxfmt Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean. * chore: update lockfile for oxfmt * chore: migrate typecheck to TypeScript 7.0 (#7516) * chore: bump TypeScript to 6.0 Baseline hop ahead of the TypeScript 7.0 (native compiler) migration, so the 7.0 cut is a version swap against a config that is already 7.0-shaped. TypeScript 6.0 raises both `moduleResolution: node10` and `baseUrl` as errors rather than warnings, and `ignoreDeprecations: "6.0"` stops working in 7.0, so clearing them properly is the only route: - `moduleResolution` -> `bundler` (Metro is a bundler), which requires an esnext-shaped `module`. - `baseUrl` removed. Exactly one import relied on it; it is now relative. - `types` enumerated, since a resolution mode that honours package `exports` no longer auto-includes every `@types` package. `@types/node` becomes an explicit devDependency. Honouring `exports` also stranded the bundled `.d.ts` of three dependencies whose maps expose only JavaScript. Each gets a `types` condition via patch-package; this is visible to the type checker only, as Metro ignores that condition. A `paths` mapping was tried first and rejected, because the jest-expo resolver reads `paths` and then loads those `.d.ts` files at runtime. The inherited block of commented-out option documentation is dropped. * chore: migrate typecheck to TypeScript 7.0 Replaces TypeScript 6.0.3 with the native Go compiler. The version is pinned exactly, since the platform binaries ship as version-matched optional dependencies; the lockfile records the linux-x64 target CI resolves. Typecheck wall time drops from 5.77s on 5.9.3 to ~1.0s. No configuration change was required: the 6.0 hop already left tsconfig in a 7.0-shaped state, and the default parallelism saturates without `--checkers`. `@react-navigation/core` needs a patch to type-check. TypeScript 7.0.2 resolves the mutual recursion between `StaticParamList` and `ParamListForScreens` eagerly where earlier versions defer it, reports the alias as circular, and degrades it to a non-generic symbol -- surfacing as `TS2315: Type 'StaticParamList' is not generic` at our call sites. The patch drops a `FlatType<>` wrapper from the alias, which only flattens intersections for editor display, so the type is unchanged and the misfire stops. * chore: Bump version to 4.76.0 (#7542) * chore(ci): apply least privilege permission to GitHub Actions (#7350) * chore: switch React Compiler to infer mode (#7545) * ci: route Maestro e2e selection through sniffler impact analysis (#7476) * fix(iOS): RoomItem Swipe not working after scroll (#7532) * fix(ci): select shards for changes outside app and honor the release label (#7555) * fix: delete background taller than its row on ServersHistory (#7536) * fix: delete background taller than its row on server items * chore: code improvements --------- Co-authored-by: Diego Mello <diegolmello@gmail.com> * fix: UIKit block messages rendering with smaller font size (#7531) * fix: UIKit block messages rendering with smaller font size * fix: snapshot * fix(db): move deleteMessage finds and prepares inside the writer lock (#7550) * fix: quote has no effect on older thread messages (#7535) * fix: Quote has no effect on older thread messages * fix: Quote has no effect on older thread messages * chore: e2e test * fix: e2e test * chore: format code and fix lint issues * fix(MessageComposer): resolve quoted thread messages and guard stale lookups * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(db): move persistMessage lookups and prepares inside the writer lock (#7551) * fix: test case 11 and 12 flaky tests (#7564) * fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment * fix(db): move sendMessage reads and prepares inside the writer lock (#7546) * fix(db): move sendMessage reads and prepares inside the writer lock * fix: test improvements * chore: remove comments * fix: Admin Panel content hidden behind bottom navigation bar (#7538) * feat: add tabular numbers (#7568) * feat: tabular numbers across the app, upgrade Inter to 4.1 * update snapshot * chore: pin @rocket.chat/sdk to a specific commit hash (#7569) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE (#7554) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE * code improvements * removed unused comment * fix: run handleDelete finds and prepares inside the writer lock (#7552) * fix: run handleDelete finds and prepares inside the writer lock * chore: reuse mockWMDB * fix: crop screen hidden behind navigation bar on iOS 26 (#7529) * fix: re-fetch message inside the write in getThreadName (#7557) * fix: re-fetch message inside the write in getThreadName * fix: re-fetch message inside the write in getThreadName * chore: new test cases * remove unecessary async * fix(db): move decryptPendingMessages prepares inside the writer lock (#7548) * fix(db): move decryptPendingMessages prepares inside the writer lock * code improvements * chore: new test case encryption * chore: format code and fix lint issues --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(android): VideoConf notification accept and decline button hidden and touch not working (#7533) * fix: in-app notification buttons ignoring taps on Android * fix: Decline and Accept invisible on the incoming call notification * fix: UIKit buttons not responding on some Android devices (#7573) * fix: force Google account chooser on OAuth login (#7572) * fix: ISO format support in markdown component (#6943) * fix: resolve deep links by room id for channels and groups (#7111) * Merge pull request #7570 from RocketChat/deeplink-saml-auth feat: SAML deeplink auth * fix: grant pull-requests write to build call sites in build-develop (#7599) The reusable workflows build-android.yml and build-ios.yml declare pull-requests: write on their upload jobs. GitHub validates these at call time regardless of job conditionals, so build-develop.yml (caller) must grant the permission or the workflow fails validation. build-pr.yml already grants it; this mirrors that. --------- Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com> Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
diegolmello
added a commit
that referenced
this pull request
Aug 31, 2026
* fix: render mentions, emojis, and inline elements inside headings (#6911) * chore: OXC (#7515) * chore: replace ESLint with Oxlint Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid. * chore: replace Prettier with Oxfmt Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean. * chore: update lockfile for oxfmt * chore: migrate typecheck to TypeScript 7.0 (#7516) * chore: bump TypeScript to 6.0 Baseline hop ahead of the TypeScript 7.0 (native compiler) migration, so the 7.0 cut is a version swap against a config that is already 7.0-shaped. TypeScript 6.0 raises both `moduleResolution: node10` and `baseUrl` as errors rather than warnings, and `ignoreDeprecations: "6.0"` stops working in 7.0, so clearing them properly is the only route: - `moduleResolution` -> `bundler` (Metro is a bundler), which requires an esnext-shaped `module`. - `baseUrl` removed. Exactly one import relied on it; it is now relative. - `types` enumerated, since a resolution mode that honours package `exports` no longer auto-includes every `@types` package. `@types/node` becomes an explicit devDependency. Honouring `exports` also stranded the bundled `.d.ts` of three dependencies whose maps expose only JavaScript. Each gets a `types` condition via patch-package; this is visible to the type checker only, as Metro ignores that condition. A `paths` mapping was tried first and rejected, because the jest-expo resolver reads `paths` and then loads those `.d.ts` files at runtime. The inherited block of commented-out option documentation is dropped. * chore: migrate typecheck to TypeScript 7.0 Replaces TypeScript 6.0.3 with the native Go compiler. The version is pinned exactly, since the platform binaries ship as version-matched optional dependencies; the lockfile records the linux-x64 target CI resolves. Typecheck wall time drops from 5.77s on 5.9.3 to ~1.0s. No configuration change was required: the 6.0 hop already left tsconfig in a 7.0-shaped state, and the default parallelism saturates without `--checkers`. `@react-navigation/core` needs a patch to type-check. TypeScript 7.0.2 resolves the mutual recursion between `StaticParamList` and `ParamListForScreens` eagerly where earlier versions defer it, reports the alias as circular, and degrades it to a non-generic symbol -- surfacing as `TS2315: Type 'StaticParamList' is not generic` at our call sites. The patch drops a `FlatType<>` wrapper from the alias, which only flattens intersections for editor display, so the type is unchanged and the misfire stops. * chore: Bump version to 4.76.0 (#7542) * chore(ci): apply least privilege permission to GitHub Actions (#7350) * chore: switch React Compiler to infer mode (#7545) * ci: route Maestro e2e selection through sniffler impact analysis (#7476) * fix(iOS): RoomItem Swipe not working after scroll (#7532) * fix(ci): select shards for changes outside app and honor the release label (#7555) * fix: delete background taller than its row on ServersHistory (#7536) * fix: delete background taller than its row on server items * chore: code improvements --------- Co-authored-by: Diego Mello <diegolmello@gmail.com> * fix: UIKit block messages rendering with smaller font size (#7531) * fix: UIKit block messages rendering with smaller font size * fix: snapshot * fix(db): move deleteMessage finds and prepares inside the writer lock (#7550) * fix: quote has no effect on older thread messages (#7535) * fix: Quote has no effect on older thread messages * fix: Quote has no effect on older thread messages * chore: e2e test * fix: e2e test * chore: format code and fix lint issues * fix(MessageComposer): resolve quoted thread messages and guard stale lookups * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(db): move persistMessage lookups and prepares inside the writer lock (#7551) * fix: test case 11 and 12 flaky tests (#7564) * fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment * fix(db): move sendMessage reads and prepares inside the writer lock (#7546) * fix(db): move sendMessage reads and prepares inside the writer lock * fix: test improvements * chore: remove comments * fix: Admin Panel content hidden behind bottom navigation bar (#7538) * feat: add tabular numbers (#7568) * feat: tabular numbers across the app, upgrade Inter to 4.1 * update snapshot * chore: pin @rocket.chat/sdk to a specific commit hash (#7569) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE (#7554) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE * code improvements * removed unused comment * fix: run handleDelete finds and prepares inside the writer lock (#7552) * fix: run handleDelete finds and prepares inside the writer lock * chore: reuse mockWMDB * fix: crop screen hidden behind navigation bar on iOS 26 (#7529) * fix: re-fetch message inside the write in getThreadName (#7557) * fix: re-fetch message inside the write in getThreadName * fix: re-fetch message inside the write in getThreadName * chore: new test cases * remove unecessary async * fix(db): move decryptPendingMessages prepares inside the writer lock (#7548) * fix(db): move decryptPendingMessages prepares inside the writer lock * code improvements * chore: new test case encryption * chore: format code and fix lint issues --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(android): VideoConf notification accept and decline button hidden and touch not working (#7533) * fix: in-app notification buttons ignoring taps on Android * fix: Decline and Accept invisible on the incoming call notification * fix: UIKit buttons not responding on some Android devices (#7573) * fix: force Google account chooser on OAuth login (#7572) * fix: ISO format support in markdown component (#6943) * fix: resolve deep links by room id for channels and groups (#7111) * Merge pull request #7570 from RocketChat/deeplink-saml-auth feat: SAML deeplink auth * fix: grant pull-requests write to build call sites in build-develop (#7599) The reusable workflows build-android.yml and build-ios.yml declare pull-requests: write on their upload jobs. GitHub validates these at call time regardless of job conditionals, so build-develop.yml (caller) must grant the permission or the workflow fails validation. build-pr.yml already grants it; this mirrors that. --------- Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com> Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Quoting a message inside a thread only worked for the newest handful of replies (~5–7). For anything older, tapping Quote did nothing: no preview in the composer, and no quote in the sent message. It affected both your own messages and other users'.
The cause is that thread replies are persisted in the thread_messages table, while the quote flow resolved ids through getMessageById, which only reads messages. A reply lands in messages only if it happened to arrive via the room stream, so which messages were quotable depended on how the room had been loaded rather than on anything the user did.
getMessageById now accepts an optional tmid and prefers thread_messages when it's set, falling back to messages so the thread's parent message still resolves. The composer passes tmid through to both the preview (Quote.tsx → useMessage) and the outgoing message (prepareQuoteMessage), including the attachment-caption path. getPermalinkMessage was widened from TMessageModel to TAnyMessageModel — a parameter-type widening only, no runtime change. All four code paths that create a thread_messages row set subscription_id to the room's rid, so permalinks resolve to the room and not the thread.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-1092
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
New Features
Bug Fixes
Tests