chore: switch React Compiler to infer mode - #7545
Merged
Merged
Conversation
diegolmello
temporarily deployed
to
approve_e2e_testing
August 4, 2026 16:57 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (178)
WalkthroughThis PR updates React Compiler configuration, upgrades the compiler package, removes local ChangesReact Compiler migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
temporarily deployed
to
android_build
August 4, 2026 17:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsx`:
- Around line 52-55: Update the declarations at
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsx:52-55,
app/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.ts:25-28, and
app/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.ts:25-28 to add
explicit parameter and return types: type the isAndroid getter as boolean,
renderPreviewFormatText as accepting string and returning string, and
renderShortnameToUnicode as accepting a string plus optional boolean and
returning string.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: da88a175-0676-4e5e-b4cd-d376c4a2f3f3
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (178)
app/AppContainer.tsxapp/containers/ActionSheet/BottomSheetContent.tsxapp/containers/ActionSheet/Handle.tsxapp/containers/ActionSheet/Item.tsxapp/containers/ActionSheet/Provider.tsxapp/containers/AltTextLabel.tsxapp/containers/Header/components/HeaderBackButton.tsxapp/containers/Header/components/HeaderButton/HeaderButtonItem.tsxapp/containers/Header/components/HeaderContainer/index.tsxapp/containers/Header/components/HeaderTitle/index.tsxapp/containers/Header/index.tsxapp/containers/List/ListContainer.tsxapp/containers/List/ListHeader.tsxapp/containers/List/ListIcon.tsxapp/containers/List/ListInfo.tsxapp/containers/List/ListItem.tsxapp/containers/List/ListSection.tsxapp/containers/List/ListSeparator.tsxapp/containers/MediaCallHeader/MediaCallHeader.tsxapp/containers/MediaCallHeader/components/Collapse.tsxapp/containers/MediaCallHeader/components/EndCall.tsxapp/containers/MediaCallHeader/components/Subtitle.tsxapp/containers/MediaCallHeader/components/Timer.tsxapp/containers/MediaCallHeader/components/Title.tsxapp/containers/MessageComposer/MessageComposer.tsxapp/containers/MessageComposer/MessageComposerContainer.tsxapp/containers/MessageComposer/components/Attachments/ComposerAttachments.tsxapp/containers/MessageComposer/components/Autocomplete/Autocomplete.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteCannedResponse.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteEmoji.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteItem.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteItemLoading.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompletePreview.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteSlashCommand.tsxapp/containers/MessageComposer/components/Autocomplete/AutocompleteUserRoom.tsxapp/containers/MessageComposer/components/Autocomplete/styles.tsapp/containers/MessageComposer/components/Buttons/ActionsButton.tsxapp/containers/MessageComposer/components/Buttons/BaseButton.tsxapp/containers/MessageComposer/components/Buttons/MicOrSendButton.tsxapp/containers/MessageComposer/components/CancelEdit.tsxapp/containers/MessageComposer/components/EmojiSearchbar.tsxapp/containers/MessageComposer/components/MessageComposerContent.tsxapp/containers/MessageComposer/components/Quotes/Quote.tsxapp/containers/MessageComposer/components/Quotes/Quotes.tsxapp/containers/MessageComposer/components/RecordAudio/ReviewButton.tsxapp/containers/MessageComposer/components/SendThreadToChannel.tsxapp/containers/MessageComposer/components/Toolbar/Container.tsxapp/containers/MessageComposer/components/Toolbar/Default.tsxapp/containers/MessageComposer/components/Toolbar/EmojiKeyboard.tsxapp/containers/MessageComposer/components/Toolbar/Markdown.tsxapp/containers/MessageComposer/components/Toolbar/Toolbar.tsxapp/containers/MessageComposer/components/Unfocused/Left.tsxapp/containers/MessageComposer/components/Unfocused/Right.tsxapp/containers/MessageComposer/context.tsxapp/containers/MessageComposer/hooks/useAutoSaveDraft.tsapp/containers/MessageComposer/hooks/useCanUploadFile.tsapp/containers/MessageComposer/hooks/useChooseMedia.tsapp/containers/MessageComposer/hooks/useEmojiKeyboard.tsxapp/containers/MessageComposer/hooks/useIOSBackSwipeHandler.tsapp/containers/MessageComposer/hooks/useMessage.tsapp/containers/RoomHeader/RoomHeader.tsxapp/containers/RoomItem/RoomItem.tsxapp/containers/Status/StatusRows.tsxapp/containers/markdown/components/Heading.tsxapp/containers/markdown/components/inline/Bold.tsxapp/containers/markdown/components/inline/Italic.tsxapp/containers/markdown/components/inline/Strike.tsxapp/containers/markdown/index.tsxapp/containers/message/components/Attachments/AttachedActions.tsxapp/containers/message/components/Attachments/Attachments.tsxapp/containers/message/components/Attachments/Audio.tsxapp/containers/message/components/Attachments/CollapsibleQuote.tsxapp/containers/message/components/Attachments/Image/Button.tsxapp/containers/message/components/Attachments/Image/Container.tsxapp/containers/message/components/Attachments/Image/Image.tsxapp/containers/message/components/Attachments/Image/ImageBadge.tsxapp/containers/message/components/Attachments/Quote.tsxapp/containers/message/components/Attachments/Reply.tsxapp/containers/message/components/Attachments/Video.tsxapp/containers/message/components/Blocks.tsapp/containers/message/components/Broadcast.tsxapp/containers/message/components/CallButton.tsxapp/containers/message/components/Content/ContentWrapper.tsxapp/containers/message/components/Content/EncryptedContent.tsxapp/containers/message/components/Content/IgnoredContent.tsxapp/containers/message/components/Content/InfoContent.tsxapp/containers/message/components/Content/MarkdownContent.tsxapp/containers/message/components/Content/PreviewContent.tsxapp/containers/message/components/Content/index.tsxapp/containers/message/components/Discussion.tsxapp/containers/message/components/Emoji.tsxapp/containers/message/components/Layout/BlocksLayout.tsxapp/containers/message/components/Layout/ContentLayout.tsxapp/containers/message/components/Layout/DiscussionLayout.tsxapp/containers/message/components/Layout/JitsiLayout.tsxapp/containers/message/components/Layout/PreviewLayout.tsxapp/containers/message/components/Layout/StandardLayout.tsxapp/containers/message/components/Layout/index.tsxapp/containers/message/components/Message/CompactMessage.tsxapp/containers/message/components/Message/FullMessage.tsxapp/containers/message/components/Message/Message.tsxapp/containers/message/components/MessageAccessibleIndex.tsxapp/containers/message/components/MessageAvatar.tsxapp/containers/message/components/OverlayComponent.tsxapp/containers/message/components/Preview.tsxapp/containers/message/components/Reactions.tsxapp/containers/message/components/RepliedThread.tsxapp/containers/message/components/RightIcons/Edited.tsxapp/containers/message/components/RightIcons/Encrypted.tsxapp/containers/message/components/RightIcons/MessageError.tsxapp/containers/message/components/RightIcons/Pinned.tsxapp/containers/message/components/RightIcons/ReadReceipt.tsxapp/containers/message/components/RightIcons/Translated.tsxapp/containers/message/components/RightIcons/index.tsxapp/containers/message/components/Thread.tsxapp/containers/message/components/Time.tsxapp/containers/message/components/Touchable/MessageActionTouchable.tsxapp/containers/message/components/Touchable/MessageTouchable.tsxapp/containers/message/components/Touchable/Touch.tsxapp/containers/message/components/Urls.tsxapp/containers/message/components/User.tsxapp/containers/message/components/WidthAwareView.tsxapp/containers/message/docs/ARCHITECTURE.mdapp/containers/message/hooks/useFile.tsxapp/containers/message/hooks/useMediaAutoDownload.tsxapp/containers/message/hooks/useMessageAccessibilityActions.tsapp/containers/message/hooks/useMessageAccessibilityHint.tsapp/containers/message/index.tsxapp/containers/message/stores/MessageActionStore.tsxapp/containers/message/stores/MessageRoomStore.tsxapp/containers/message/stores/MessageStore.tsxapp/lib/hooks/useCustomEmoji.tsapp/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.tsapp/lib/hooks/useSubscription.tsapp/stacks/InsideStack.tsxapp/stacks/MasterDetailStack/ModalContainer.tsxapp/stacks/MasterDetailStack/index.tsxapp/stacks/OutsideStack.tsxapp/stacks/ShareExtensionStack.tsxapp/views/CallView/components/CallButtons.tsxapp/views/CallView/components/Dialpad/DialpadButton.tsxapp/views/CallView/index.tsxapp/views/DirectoryView/hooks/useDirectorySearch.tsapp/views/LanguageView/index.tsxapp/views/RoomInfoView/components/RoomInfoButtons.tsxapp/views/RoomView/List/index.tsxapp/views/RoomView/RoomProviders.tsxapp/views/RoomView/components/HeaderCallButton.tsxapp/views/RoomsListView/components/Container.tsxapp/views/RoomsListView/components/Header.tsxapp/views/RoomsListView/components/ListHeader.tsxapp/views/RoomsListView/components/SectionHeader.tsxapp/views/RoomsListView/components/ServersList.tsxapp/views/RoomsListView/components/TabletHeader.tsxapp/views/RoomsListView/contexts/RoomsSearchProvider.tsxapp/views/RoomsListView/hooks/useGetItemLayout.tsapp/views/RoomsListView/hooks/useHeader.tsxapp/views/RoomsListView/hooks/useRefresh.tsapp/views/RoomsListView/hooks/useSearch.tsapp/views/RoomsListView/hooks/useSubscriptions.tsapp/views/RoomsListView/index.tsxapp/views/SelectServerView.tsxapp/views/SettingsView/index.tsxapp/views/SidebarView/components/Admin.tsxapp/views/SidebarView/components/CustomStatus.tsxapp/views/SidebarView/components/Profile.tsxapp/views/SidebarView/components/Stacks.tsxapp/views/SidebarView/components/SupportedVersionsWarnItem.tsxapp/views/SidebarView/index.tsxapp/views/StatusView/ClearAfterPicker/ClearAfterSheetContent.tsxapp/views/StatusView/ClearAfterPicker/DatePickerSheetContent.tsxapp/views/StatusView/ClearAfterPicker/index.tsxapp/views/StatusView/FooterComponent.tsxapp/views/StatusView/index.tsxbabel.config.jspackage.json
💤 Files with no reviewable changes (172)
- app/containers/MessageComposer/components/SendThreadToChannel.tsx
- app/containers/MediaCallHeader/components/EndCall.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteCannedResponse.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteItem.tsx
- app/containers/List/ListIcon.tsx
- app/containers/MediaCallHeader/components/Timer.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteSlashCommand.tsx
- app/containers/MessageComposer/components/Unfocused/Right.tsx
- app/containers/MessageComposer/MessageComposerContainer.tsx
- app/containers/message/components/Touchable/MessageActionTouchable.tsx
- app/containers/MediaCallHeader/components/Title.tsx
- app/containers/markdown/components/inline/Strike.tsx
- app/containers/message/hooks/useFile.tsx
- app/containers/message/components/RightIcons/index.tsx
- app/containers/message/components/Message/Message.tsx
- app/containers/message/components/Attachments/Image/Button.tsx
- app/views/RoomView/RoomProviders.tsx
- app/containers/message/components/Layout/PreviewLayout.tsx
- app/containers/MessageComposer/components/Buttons/ActionsButton.tsx
- app/containers/MessageComposer/components/EmojiSearchbar.tsx
- app/containers/message/components/MessageAccessibleIndex.tsx
- app/views/StatusView/FooterComponent.tsx
- app/containers/message/components/RightIcons/Pinned.tsx
- app/views/SidebarView/components/Admin.tsx
- app/containers/MessageComposer/components/RecordAudio/ReviewButton.tsx
- app/containers/MessageComposer/components/Buttons/MicOrSendButton.tsx
- app/containers/MessageComposer/components/Attachments/ComposerAttachments.tsx
- app/containers/message/components/OverlayComponent.tsx
- app/containers/message/components/RightIcons/Translated.tsx
- app/containers/message/components/Attachments/Audio.tsx
- app/views/SidebarView/index.tsx
- app/containers/message/components/Attachments/Attachments.tsx
- app/containers/message/components/Discussion.tsx
- app/containers/MessageComposer/components/Toolbar/Default.tsx
- app/containers/MessageComposer/components/Toolbar/Container.tsx
- app/containers/markdown/components/inline/Italic.tsx
- app/containers/message/components/Layout/BlocksLayout.tsx
- app/containers/Header/components/HeaderButton/HeaderButtonItem.tsx
- app/containers/message/components/Layout/StandardLayout.tsx
- app/containers/MediaCallHeader/MediaCallHeader.tsx
- app/containers/List/ListSection.tsx
- app/containers/MediaCallHeader/components/Collapse.tsx
- app/containers/List/ListContainer.tsx
- app/containers/message/components/Touchable/MessageTouchable.tsx
- app/containers/List/ListSeparator.tsx
- app/containers/message/components/Touchable/Touch.tsx
- app/containers/MessageComposer/MessageComposer.tsx
- app/containers/message/components/Layout/JitsiLayout.tsx
- app/containers/MessageComposer/components/MessageComposerContent.tsx
- app/containers/message/components/Attachments/Image/Image.tsx
- app/views/DirectoryView/hooks/useDirectorySearch.ts
- app/containers/MessageComposer/components/Autocomplete/AutocompletePreview.tsx
- app/containers/ActionSheet/BottomSheetContent.tsx
- app/containers/message/components/Attachments/Image/ImageBadge.tsx
- app/views/RoomsListView/components/Container.tsx
- app/containers/MessageComposer/components/Toolbar/Toolbar.tsx
- app/containers/MessageComposer/components/Toolbar/Markdown.tsx
- app/containers/markdown/index.tsx
- app/views/StatusView/ClearAfterPicker/DatePickerSheetContent.tsx
- app/containers/message/components/Time.tsx
- app/containers/MessageComposer/components/Autocomplete/Autocomplete.tsx
- app/containers/ActionSheet/Provider.tsx
- app/containers/List/ListItem.tsx
- app/views/SidebarView/components/CustomStatus.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteUserRoom.tsx
- app/containers/MessageComposer/components/Autocomplete/styles.ts
- app/containers/message/components/RightIcons/MessageError.tsx
- app/containers/message/hooks/useMessageAccessibilityActions.ts
- app/containers/message/components/MessageAvatar.tsx
- app/views/SidebarView/components/Stacks.tsx
- app/containers/List/ListInfo.tsx
- app/AppContainer.tsx
- app/views/RoomView/components/HeaderCallButton.tsx
- app/containers/MessageComposer/components/Quotes/Quote.tsx
- app/containers/Header/components/HeaderContainer/index.tsx
- app/containers/List/ListHeader.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteItemLoading.tsx
- app/views/CallView/index.tsx
- app/containers/message/components/Layout/index.tsx
- app/containers/message/components/Attachments/Video.tsx
- app/containers/MessageComposer/components/Autocomplete/AutocompleteEmoji.tsx
- app/containers/MediaCallHeader/components/Subtitle.tsx
- app/containers/MessageComposer/components/Buttons/BaseButton.tsx
- app/containers/message/components/Layout/ContentLayout.tsx
- app/containers/message/components/Content/InfoContent.tsx
- app/containers/message/components/RightIcons/Encrypted.tsx
- app/containers/MessageComposer/components/Toolbar/EmojiKeyboard.tsx
- app/containers/message/components/Thread.tsx
- app/containers/message/components/Attachments/Image/Container.tsx
- app/views/CallView/components/CallButtons.tsx
- app/containers/MessageComposer/hooks/useMessage.ts
- app/containers/message/components/RightIcons/ReadReceipt.tsx
- app/containers/message/components/Content/index.tsx
- app/containers/MessageComposer/hooks/useIOSBackSwipeHandler.ts
- app/views/RoomView/List/index.tsx
- app/containers/message/components/Content/IgnoredContent.tsx
- app/stacks/ShareExtensionStack.tsx
- app/containers/message/hooks/useMessageAccessibilityHint.ts
- app/views/RoomsListView/components/Header.tsx
- app/containers/message/components/Attachments/CollapsibleQuote.tsx
- app/containers/message/components/Attachments/Quote.tsx
- app/views/SidebarView/components/Profile.tsx
- app/containers/message/components/Reactions.tsx
- app/containers/AltTextLabel.tsx
- app/containers/message/components/Preview.tsx
- app/views/StatusView/ClearAfterPicker/ClearAfterSheetContent.tsx
- app/containers/Header/components/HeaderTitle/index.tsx
- app/containers/ActionSheet/Item.tsx
- app/containers/message/components/RightIcons/Edited.tsx
- app/stacks/OutsideStack.tsx
- app/containers/Header/components/HeaderBackButton.tsx
- app/containers/message/components/Message/FullMessage.tsx
- app/containers/message/components/Message/CompactMessage.tsx
- app/containers/MessageComposer/components/Quotes/Quotes.tsx
- app/containers/message/components/Urls.tsx
- app/views/RoomInfoView/components/RoomInfoButtons.tsx
- app/views/SidebarView/components/SupportedVersionsWarnItem.tsx
- app/containers/message/components/Emoji.tsx
- app/containers/Header/index.tsx
- app/views/StatusView/index.tsx
- app/containers/message/components/RepliedThread.tsx
- app/containers/message/components/Content/MarkdownContent.tsx
- app/views/LanguageView/index.tsx
- app/containers/message/hooks/useMediaAutoDownload.tsx
- app/views/RoomsListView/contexts/RoomsSearchProvider.tsx
- app/containers/message/components/Blocks.ts
- app/containers/MessageComposer/hooks/useCanUploadFile.ts
- app/views/CallView/components/Dialpad/DialpadButton.tsx
- app/containers/message/components/CallButton.tsx
- app/views/RoomsListView/components/ListHeader.tsx
- app/containers/markdown/components/inline/Bold.tsx
- app/containers/message/components/Attachments/AttachedActions.tsx
- app/containers/markdown/components/Heading.tsx
- app/containers/ActionSheet/Handle.tsx
- app/containers/message/index.tsx
- app/containers/message/stores/MessageActionStore.tsx
- app/containers/message/components/WidthAwareView.tsx
- app/views/RoomsListView/components/SectionHeader.tsx
- app/containers/message/components/Broadcast.tsx
- app/stacks/MasterDetailStack/ModalContainer.tsx
- app/views/StatusView/ClearAfterPicker/index.tsx
- app/containers/message/components/Content/ContentWrapper.tsx
- app/views/RoomsListView/index.tsx
- app/containers/message/components/Content/PreviewContent.tsx
- app/lib/hooks/useSubscription.ts
- app/containers/RoomHeader/RoomHeader.tsx
- app/views/RoomsListView/hooks/useGetItemLayout.ts
- app/views/RoomsListView/components/ServersList.tsx
- app/containers/MessageComposer/hooks/useChooseMedia.ts
- app/views/RoomsListView/hooks/useSubscriptions.ts
- app/containers/MessageComposer/hooks/useAutoSaveDraft.ts
- app/containers/MessageComposer/hooks/useEmojiKeyboard.tsx
- app/containers/MessageComposer/context.tsx
- app/containers/message/components/Layout/DiscussionLayout.tsx
- app/containers/message/stores/MessageRoomStore.tsx
- app/stacks/MasterDetailStack/index.tsx
- app/containers/message/components/Attachments/Reply.tsx
- app/views/SettingsView/index.tsx
- app/containers/Status/StatusRows.tsx
- app/views/RoomsListView/hooks/useRefresh.ts
- app/containers/RoomItem/RoomItem.tsx
- app/containers/MessageComposer/components/Unfocused/Left.tsx
- app/containers/message/stores/MessageStore.tsx
- app/views/RoomsListView/components/TabletHeader.tsx
- app/views/SelectServerView.tsx
- app/views/RoomsListView/hooks/useSearch.ts
- app/stacks/InsideStack.tsx
- app/containers/message/components/User.tsx
- app/views/RoomsListView/hooks/useHeader.tsx
- app/containers/MessageComposer/components/CancelEdit.tsx
- app/lib/hooks/useCustomEmoji.ts
- app/containers/message/components/Content/EncryptedContent.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: ESLint and Test / run-eslint-and-test
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.tsbabel.config.js
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers
Files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{js,jsx,ts,tsx}: Format JavaScript and TypeScript code with Oxfmt using the repository configuration: tabs, single quotes, 130-character width, no trailing commas, omitted arrow-function parentheses where possible, and same-line brackets.
Follow Oxlint rules configured in.oxlintrc.json, including the import, React, Jest, TypeScript, and React Native plugins.
Files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.tsbabel.config.js
🧠 Learnings (5)
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.
Applied to files:
package.json
📚 Learning: 2026-05-07T17:47:14.516Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7303
File: package.json:5-5
Timestamp: 2026-05-07T17:47:14.516Z
Learning: When reviewing pnpm `packageManager` version pins in any `package.json` (e.g., `"packageManager": "pnpm@<version>"`), don’t rely solely on web-search results to determine whether a version exists. For very recently published versions, cross-check the target version against the official pnpm release page (https://github.com/pnpm/pnpm/releases) and the npm registry page for pnpm (https://www.npmjs.com/package/pnpm) before flagging the pinned version as non-existent.
Applied to files:
package.json
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.ts
📚 Learning: 2026-06-25T18:37:25.526Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.test.tsx:16-22
Timestamp: 2026-06-25T18:37:25.526Z
Learning: In Rocket.Chat ReactNative tests that mock selectors for `useAppSelector`, don’t require the mocked selector input to be typed as `IApplicationState` when the fixture only includes a partial Redux state slice (e.g., only `server` and `settings`). Requiring the full `IApplicationState` type in that scenario forces unsafe `as IApplicationState` casts and undermines type-safety. For these narrowly scoped selector-mock fixtures, use a less strict type (e.g., `any`) to keep the mock focused on the slice under test.
Applied to files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsxapp/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.tsapp/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.ts
📚 Learning: 2026-06-25T18:37:44.793Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7434
File: app/views/ScreenLockConfigView.tsx:101-141
Timestamp: 2026-06-25T18:37:44.793Z
Learning: In the Rocket.Chat React Native codebase, do not treat passing an `async` function directly to an event prop in React/React Native UI components (e.g., `onPress={async () => ...}` in TSX) as a “floating promises” CI-blocking lint issue—this repo does not enable the ESLint `no-floating-promises` rule (while `no-void` is enforced). Only raise robustness follow-ups when there are genuinely unhandled promise paths (e.g., fire-and-forget calls like `save()` that return a Promise that is neither awaited nor handled), and prefer making sure failure paths are explicitly handled/reported rather than blocking on lint-style floating-promise concerns.
Applied to files:
app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsx
🔇 Additional comments (6)
babel.config.js (1)
9-23: LGTM!package.json (1)
193-193: LGTM!app/containers/message/docs/ARCHITECTURE.md (1)
40-42: LGTM!app/lib/hooks/useNewMediaCall/useNewMediaCall.test.tsx (1)
82-82: LGTM!Also applies to: 281-285
app/lib/hooks/usePreviewFormatText/usePreviewFormatText.test.ts (1)
1-1: LGTM!Also applies to: 30-86, 105-110, 129-134
app/lib/hooks/useShortnameToUnicode/useShortnameToUnicode.test.ts (1)
1-1: LGTM!Also applies to: 30-76, 90-95, 109-109
diegolmello
had a problem deploying
to
upload_android
August 4, 2026 17:27 — with
GitHub Actions
Error
GitHub Actions
Error
|
Android Build Available Rocket.Chat 4.76.0.109496 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTtwqZK5jL68zK2fr2ah3ngOPj3NOfBqbSlM8qpxpIv3aEFhUNXs2s0jWNQ3jeKXm6oXjJ4ODFN2VOwnP-b |
|
iOS Build Available Rocket.Chat 4.76.0.109497 |
Bump babel-plugin-react-compiler to 1.0.0 and switch compilationMode from 'annotation' to 'infer'. The plugin moves into a babel overrides entry whose exclude covers jest.setup.js and test files: babel merges an override's plugins with the root list instead of replacing them, so the exclude form is the only way to keep the compiler out of jest setup.
Under infer the compiled hooks need a component context, so useShortnameToUnicode, usePreviewFormatText, and useNewMediaCall tests now render via renderHook. The useNewMediaCall Android case drops jest.resetModules in favor of a getter-based isAndroid mock: re-requiring the hook loaded a second react copy whose dispatcher was never set.
Under infer the directives are inert. Deletions only: 208 directive lines and their adjacent blank lines across 172 files.
Matches the renderPreviewFormatText helper in the sibling suite.
diegolmello
force-pushed
the
remove-use-memo
branch
from
August 4, 2026 18:45
7b8a8f5 to
e5153e9
Compare
diegolmello
requested a deployment
to
approve_e2e_testing
August 4, 2026 18:45 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
diegolmello
requested a deployment
to
android_build
August 4, 2026 18:48 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
diegolmello
added a commit
that referenced
this pull request
Aug 31, 2026
* fix: render mentions, emojis, and inline elements inside headings (#6911) * chore: OXC (#7515) * chore: replace ESLint with Oxlint Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid. * chore: replace Prettier with Oxfmt Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean. * chore: update lockfile for oxfmt * chore: migrate typecheck to TypeScript 7.0 (#7516) * chore: bump TypeScript to 6.0 Baseline hop ahead of the TypeScript 7.0 (native compiler) migration, so the 7.0 cut is a version swap against a config that is already 7.0-shaped. TypeScript 6.0 raises both `moduleResolution: node10` and `baseUrl` as errors rather than warnings, and `ignoreDeprecations: "6.0"` stops working in 7.0, so clearing them properly is the only route: - `moduleResolution` -> `bundler` (Metro is a bundler), which requires an esnext-shaped `module`. - `baseUrl` removed. Exactly one import relied on it; it is now relative. - `types` enumerated, since a resolution mode that honours package `exports` no longer auto-includes every `@types` package. `@types/node` becomes an explicit devDependency. Honouring `exports` also stranded the bundled `.d.ts` of three dependencies whose maps expose only JavaScript. Each gets a `types` condition via patch-package; this is visible to the type checker only, as Metro ignores that condition. A `paths` mapping was tried first and rejected, because the jest-expo resolver reads `paths` and then loads those `.d.ts` files at runtime. The inherited block of commented-out option documentation is dropped. * chore: migrate typecheck to TypeScript 7.0 Replaces TypeScript 6.0.3 with the native Go compiler. The version is pinned exactly, since the platform binaries ship as version-matched optional dependencies; the lockfile records the linux-x64 target CI resolves. Typecheck wall time drops from 5.77s on 5.9.3 to ~1.0s. No configuration change was required: the 6.0 hop already left tsconfig in a 7.0-shaped state, and the default parallelism saturates without `--checkers`. `@react-navigation/core` needs a patch to type-check. TypeScript 7.0.2 resolves the mutual recursion between `StaticParamList` and `ParamListForScreens` eagerly where earlier versions defer it, reports the alias as circular, and degrades it to a non-generic symbol -- surfacing as `TS2315: Type 'StaticParamList' is not generic` at our call sites. The patch drops a `FlatType<>` wrapper from the alias, which only flattens intersections for editor display, so the type is unchanged and the misfire stops. * chore: Bump version to 4.76.0 (#7542) * chore(ci): apply least privilege permission to GitHub Actions (#7350) * chore: switch React Compiler to infer mode (#7545) * ci: route Maestro e2e selection through sniffler impact analysis (#7476) * fix(iOS): RoomItem Swipe not working after scroll (#7532) * fix(ci): select shards for changes outside app and honor the release label (#7555) * fix: delete background taller than its row on ServersHistory (#7536) * fix: delete background taller than its row on server items * chore: code improvements --------- Co-authored-by: Diego Mello <diegolmello@gmail.com> * fix: UIKit block messages rendering with smaller font size (#7531) * fix: UIKit block messages rendering with smaller font size * fix: snapshot * fix(db): move deleteMessage finds and prepares inside the writer lock (#7550) * fix: quote has no effect on older thread messages (#7535) * fix: Quote has no effect on older thread messages * fix: Quote has no effect on older thread messages * chore: e2e test * fix: e2e test * chore: format code and fix lint issues * fix(MessageComposer): resolve quoted thread messages and guard stale lookups * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(db): move persistMessage lookups and prepares inside the writer lock (#7551) * fix: test case 11 and 12 flaky tests (#7564) * fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment * fix(db): move sendMessage reads and prepares inside the writer lock (#7546) * fix(db): move sendMessage reads and prepares inside the writer lock * fix: test improvements * chore: remove comments * fix: Admin Panel content hidden behind bottom navigation bar (#7538) * feat: add tabular numbers (#7568) * feat: tabular numbers across the app, upgrade Inter to 4.1 * update snapshot * chore: pin @rocket.chat/sdk to a specific commit hash (#7569) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE (#7554) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE * code improvements * removed unused comment * fix: run handleDelete finds and prepares inside the writer lock (#7552) * fix: run handleDelete finds and prepares inside the writer lock * chore: reuse mockWMDB * fix: crop screen hidden behind navigation bar on iOS 26 (#7529) * fix: re-fetch message inside the write in getThreadName (#7557) * fix: re-fetch message inside the write in getThreadName * fix: re-fetch message inside the write in getThreadName * chore: new test cases * remove unecessary async * fix(db): move decryptPendingMessages prepares inside the writer lock (#7548) * fix(db): move decryptPendingMessages prepares inside the writer lock * code improvements * chore: new test case encryption * chore: format code and fix lint issues --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(android): VideoConf notification accept and decline button hidden and touch not working (#7533) * fix: in-app notification buttons ignoring taps on Android * fix: Decline and Accept invisible on the incoming call notification * fix: UIKit buttons not responding on some Android devices (#7573) * fix: force Google account chooser on OAuth login (#7572) * fix: ISO format support in markdown component (#6943) * fix: resolve deep links by room id for channels and groups (#7111) * Merge pull request #7570 from RocketChat/deeplink-saml-auth feat: SAML deeplink auth * fix: grant pull-requests write to build call sites in build-develop (#7599) The reusable workflows build-android.yml and build-ios.yml declare pull-requests: write on their upload jobs. GitHub validates these at call time regardless of job conditionals, so build-develop.yml (caller) must grant the permission or the workflow fails validation. build-pr.yml already grants it; this mirrors that. --------- Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com> Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
diegolmello
added a commit
that referenced
this pull request
Aug 31, 2026
* fix: render mentions, emojis, and inline elements inside headings (#6911) * chore: OXC (#7515) * chore: replace ESLint with Oxlint Migrate linting from ESLint 8 to Oxlint. `pnpm lint` drops from ~1min to ~0.6s and 17 eslint packages are removed from devDependencies. Config lives in `.oxlintrc.json`, generated with `@oxlint/migrate` from the old `.eslintrc.js` and then tuned: - `eslint-plugin-react-native` is loaded through `jsPlugins`, since Oxlint has no built-in equivalent. - `import/extensions` is off. Its old options (`js: 'warning'`, ...) were not valid values for the rule, so it never reported anything under ESLint. - `no-unused-vars` sets `caughtErrors: 'none'` to match the ESLint 8 default. - `import/no-cycle` and the React Compiler rules report as warnings. They surface findings ESLint never showed, so they are not gated yet. Rules with no Oxlint equivalent are dropped: `no-restricted-syntax` (the ban on `React.*` member syntax), `import/order`, `import/no-unresolved` and `import/named`. ESLint 8 skipped dot-directories, so files under `.rnstorybook/` and `.maestro/` were never linted. Oxlint does lint them, which surfaced four violations that are fixed here. The CI workflow keeps its filename and job id so branch protection checks stay valid. * chore: replace Prettier with Oxfmt Migrate formatting from Prettier 2.8.8 to Oxfmt via `oxfmt --migrate prettier`. - `.oxfmtrc.json` carries every previous Prettier option unchanged (tabs, single quotes, printWidth 130, no trailing comma, avoid arrow parens, bracketSameLine) plus the `.prettierignore` patterns as `ignorePatterns`. `sortPackageJson` is disabled to match previous behavior. - `.prettierrc.js` and `.prettierignore` removed; `prettier` dropped from devDependencies. - `prettier-lint` script renamed to `format-lint` and now runs `oxfmt`. - 44 files reformatted: Oxfmt follows Prettier 3 style, so nested ternaries and `extends`/type-argument wrapping indent differently than under Prettier 2. No semantic changes. - prettier.yml still ran `eslint --fix`, missed in the Oxlint migration; it now runs `oxfmt` and `oxlint --fix`. `react/exhaustive-deps` is allowed there because its autofix rewrites dependency arrays, which changes behavior and must not land unreviewed from CI. - Workflow filename kept as prettier.yml to avoid disturbing branch protection checks, same as eslint.yml. Verified: `pnpm lint` exit 0 (0 errors), `tsc` clean, 217/217 suites and 2032/2032 tests pass, `oxfmt --check` clean. * chore: update lockfile for oxfmt * chore: migrate typecheck to TypeScript 7.0 (#7516) * chore: bump TypeScript to 6.0 Baseline hop ahead of the TypeScript 7.0 (native compiler) migration, so the 7.0 cut is a version swap against a config that is already 7.0-shaped. TypeScript 6.0 raises both `moduleResolution: node10` and `baseUrl` as errors rather than warnings, and `ignoreDeprecations: "6.0"` stops working in 7.0, so clearing them properly is the only route: - `moduleResolution` -> `bundler` (Metro is a bundler), which requires an esnext-shaped `module`. - `baseUrl` removed. Exactly one import relied on it; it is now relative. - `types` enumerated, since a resolution mode that honours package `exports` no longer auto-includes every `@types` package. `@types/node` becomes an explicit devDependency. Honouring `exports` also stranded the bundled `.d.ts` of three dependencies whose maps expose only JavaScript. Each gets a `types` condition via patch-package; this is visible to the type checker only, as Metro ignores that condition. A `paths` mapping was tried first and rejected, because the jest-expo resolver reads `paths` and then loads those `.d.ts` files at runtime. The inherited block of commented-out option documentation is dropped. * chore: migrate typecheck to TypeScript 7.0 Replaces TypeScript 6.0.3 with the native Go compiler. The version is pinned exactly, since the platform binaries ship as version-matched optional dependencies; the lockfile records the linux-x64 target CI resolves. Typecheck wall time drops from 5.77s on 5.9.3 to ~1.0s. No configuration change was required: the 6.0 hop already left tsconfig in a 7.0-shaped state, and the default parallelism saturates without `--checkers`. `@react-navigation/core` needs a patch to type-check. TypeScript 7.0.2 resolves the mutual recursion between `StaticParamList` and `ParamListForScreens` eagerly where earlier versions defer it, reports the alias as circular, and degrades it to a non-generic symbol -- surfacing as `TS2315: Type 'StaticParamList' is not generic` at our call sites. The patch drops a `FlatType<>` wrapper from the alias, which only flattens intersections for editor display, so the type is unchanged and the misfire stops. * chore: Bump version to 4.76.0 (#7542) * chore(ci): apply least privilege permission to GitHub Actions (#7350) * chore: switch React Compiler to infer mode (#7545) * ci: route Maestro e2e selection through sniffler impact analysis (#7476) * fix(iOS): RoomItem Swipe not working after scroll (#7532) * fix(ci): select shards for changes outside app and honor the release label (#7555) * fix: delete background taller than its row on ServersHistory (#7536) * fix: delete background taller than its row on server items * chore: code improvements --------- Co-authored-by: Diego Mello <diegolmello@gmail.com> * fix: UIKit block messages rendering with smaller font size (#7531) * fix: UIKit block messages rendering with smaller font size * fix: snapshot * fix(db): move deleteMessage finds and prepares inside the writer lock (#7550) * fix: quote has no effect on older thread messages (#7535) * fix: Quote has no effect on older thread messages * fix: Quote has no effect on older thread messages * chore: e2e test * fix: e2e test * chore: format code and fix lint issues * fix(MessageComposer): resolve quoted thread messages and guard stale lookups * fix: test --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(db): move persistMessage lookups and prepares inside the writer lock (#7551) * fix: test case 11 and 12 flaky tests (#7564) * fix: test * fix: room last messa test * fix: jumptomessage test * chore: remove comments * fix: jump to message e2e test iOS * remove unused comment * fix(db): move sendMessage reads and prepares inside the writer lock (#7546) * fix(db): move sendMessage reads and prepares inside the writer lock * fix: test improvements * chore: remove comments * fix: Admin Panel content hidden behind bottom navigation bar (#7538) * feat: add tabular numbers (#7568) * feat: tabular numbers across the app, upgrade Inter to 4.1 * update snapshot * chore: pin @rocket.chat/sdk to a specific commit hash (#7569) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE (#7554) * fix(e2ee): re-fetch subscription inside the write in toggleRoomE2EE * code improvements * removed unused comment * fix: run handleDelete finds and prepares inside the writer lock (#7552) * fix: run handleDelete finds and prepares inside the writer lock * chore: reuse mockWMDB * fix: crop screen hidden behind navigation bar on iOS 26 (#7529) * fix: re-fetch message inside the write in getThreadName (#7557) * fix: re-fetch message inside the write in getThreadName * fix: re-fetch message inside the write in getThreadName * chore: new test cases * remove unecessary async * fix(db): move decryptPendingMessages prepares inside the writer lock (#7548) * fix(db): move decryptPendingMessages prepares inside the writer lock * code improvements * chore: new test case encryption * chore: format code and fix lint issues --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> * fix(android): VideoConf notification accept and decline button hidden and touch not working (#7533) * fix: in-app notification buttons ignoring taps on Android * fix: Decline and Accept invisible on the incoming call notification * fix: UIKit buttons not responding on some Android devices (#7573) * fix: force Google account chooser on OAuth login (#7572) * fix: ISO format support in markdown component (#6943) * fix: resolve deep links by room id for channels and groups (#7111) * Merge pull request #7570 from RocketChat/deeplink-saml-auth feat: SAML deeplink auth * fix: grant pull-requests write to build call sites in build-develop (#7599) The reusable workflows build-android.yml and build-ios.yml declare pull-requests: write on their upload jobs. GitHub validates these at call time regardless of job conditionals, so build-develop.yml (caller) must grant the permission or the workflow fails validation. build-pr.yml already grants it; this mirrors that. --------- Co-authored-by: Rohit Bansal <40559587+Rohit3523@users.noreply.github.com> Co-authored-by: Yasmim Nagat <117310290+yasnagat@users.noreply.github.com> Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com> Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
React Compiler ran in
annotationmode: only the 172 files hand-marked with'use memo'were compiled — 201 functions of the ~1,300 the compiler can cover. Every new component was uncompiled unless the author remembered the directive, so most of the app missed the compiler's memoization and the directive set drifted out of date.This PR switches
babel-plugin-react-compilertocompilationMode: 'infer'(the compiler's own default), so every component and hook is compiled automatically, and deletes the now-redundant directives. The compiler skips what it cannot prove safe, so unmodified code keeps working uncompiled.Measured evidence:
overridesentry withexcludematchingjest.setup.jsand test files, sojest.mock()factories keep working while app source stays compiled under jest. (Theexcludeform is required: babel merges an override'spluginswith the root list instead of replacing it.)useShortnameToUnicode,usePreviewFormatText,useNewMediaCall) now call hooks throughrenderHook, the pattern five other hook suites already use.'use memo'stripped from all 172 files, deletions-only. The directives are inert under infer; keeping them implies annotation mode still matters.Escape hatch: any component that misbehaves at runtime can opt out with
'use no memo', recorded here. None were needed.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1481
How to test or reproduce
Gates:
pnpm format-lint,tsc, and the full jest suite against compiled app code — 227/227 suites (2,066 tests, 411 snapshots).Device smoke checks (debug build of this branch, Android API 34 emulator,
open.rocket.chat):All flows pass. One anomaly observed, not attributable to this PR: the
rocketchat://authdeeplink stalled before dispatching login (the deepLinking saga is untouched here and is not a compiled component); flagged for a separate develop-side investigation.Screenshots
Types of changes
Checklist
Further comments
No re-render A/B was run: the risk bar for this change is behavior parity, not perf measurement. If a NO-GO-grade surprise appears later, the revert is one config value; the directive strip is cosmetic and can stay.
Summary by CodeRabbit
Refactor
Bug Fixes
Tests
Chores