Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

This repo is not forked from upstream #21

Closed
3 tasks
mwoehlke-kitware opened this issue Nov 29, 2016 · 14 comments
Closed
3 tasks

This repo is not forked from upstream #21

mwoehlke-kitware opened this issue Nov 29, 2016 · 14 comments

Comments

@mwoehlke-kitware
Copy link
Contributor

This repository is not forked off of what appears to be the (current) canonical upstream, https://github.com/libbot2/libbot, and the history is out of sync.

I propose that someone with sufficient permissions:

@jamiesnape
Copy link

Pinging @david-german-tri.

@david-german-tri
Copy link
Contributor

david-german-tri commented Dec 2, 2016

Hmm. Alternatively, could we just fork the canonical upstream into a new repo, push our patches to it, cut Drake & co over, and then delete this repo once we're really sure it has no users? (Or perhaps just stick a loud warning in the README and forget it exists?) That seems like it has a few advantages:

  • No rewriting public history
  • Similar amounts of work, since you already have the stack of commits in your fork
  • Canonicalize on the new libbot2 name
  • Don't have to talk to GitHub support (can they even make the "fork" link post facto?)

@jamiesnape
Copy link

I like that plan. Quite convenient the upstream repo is not called libbot.

@mwoehlke-kitware
Copy link
Contributor Author

Alternatively, could we just fork the canonical upstream into a new repo

This just pushes the problem downstream, by detaching us from the (non-trivial) network of forks of this repo. We'd force everyone else to do the same, and we'd lose history (all issues and PR's in all downstream repos) in the process.

No rewriting public history

Either way, we need to point master at the aforementioned SHA (which is not in upstream). Anyway, I proposed to keep the old history, maybe even indefinitely (so old PR's will still point somewhere).

Don't have to talk to GitHub support (can they even make the "fork" link post facto?)

I believe so; at least, I found a page somewhere (SO?) that suggests they can. Possibly we could even ask first, as I think adding the fork relationship doesn't actually require shared history.

Canonicalize on the new libbot2 name

If that's desirable, it's trivial and less disruptive / destructive to just rename this repo.

@david-german-tri
Copy link
Contributor

OK, those are good points. I'll contact GitHub support.

@david-german-tri
Copy link
Contributor

They say:

Cross-network reparenting isn’t possible at this time. If the two repository existed in the same network, we may have been able to assist with this, but looking at them on our side, this wouldn't be possible.

@david-german-tri
Copy link
Contributor

david-german-tri commented Dec 14, 2016

I just talked with @gizatt about this, and he says that if we switch to a new repo, it won't cause significant pain for his forks.

@patmarion, @wxmerkt, would it cause problems for you if Drake switched to a new RobotLocomotion/libbot2 repository, which is a fork of upstream https://github.com/libbot2/libbot? master in the new repo would have the exact same source code as this repo does right now, but a history that was consistent with upstream. This repo could continue to exist indefinitely.

@patmarion
Copy link
Member

fine with me, thanks for working on it!

@mwoehlke-kitware
Copy link
Contributor Author

Updated SHA (including #22) is 83d56d6.

@david-german-tri
Copy link
Contributor

We probably won't hear from @wxmerkt until tomorrow AM due to time zones, so let's table until then.

@wxmerkt
Copy link
Member

wxmerkt commented Dec 14, 2016

@david-german-tri No problems here, thanks for checking :)

@david-german-tri
Copy link
Contributor

@david-german-tri
Copy link
Contributor

@mwoehlke-kitware, please go ahead and PR your stack of commits, then cut Drake over!

@mwoehlke-kitware
Copy link
Contributor Author

mwoehlke-kitware commented Jan 6, 2017

New (properly forked) repo is https://github.com/RobotLocomotion/libbot2, used by Drake as of RobotLocomotion/drake#4680

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants