-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libbot, use new repo #4680
Update libbot, use new repo #4680
Conversation
Update libbot to bring in RobotLocomotion/libbot2#2, which fixes the last remaining bits of RobotLocomotion#3231. This also switches us to the new repository which shares history with upstream. (The old repository was separately copied from the old subversion repository, and had the same content but not the same SHA's.)
I don't think I understand how to use this. If I invoke
|
Also, note #3231 (comment) |
|
Yeah, OK. I suppose that's the right thing to do, and it works. |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
I'll go ahead and merge this, then clean up the remaining #3231 hacks in Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Thanks! I took a brief look at those last night, but it wasn't immediately obvious what to do about them, and it was late. (Particularly, it seems we would want to leverage knowledge of Drake's superbuild to make sure |
Per f2f with David: the |
Yeah. I was planning to glom |
Update libbot to bring in RobotLocomotion/libbot2#2, which fixes the last remaining bits of #3231. This also switches us to the new repository which shares history with upstream. (The old repository was separately copied from the old subversion repository, and had the same content but not the same SHA's.)
Fixes #3231.
@david-german-tri for feature and platform review (due to having reviewed the libbot PR).
Note: the old submodule SHA (RobotLocomotion/libbot@6d932c813e6e) corresponds to RobotLocomotion/libbot2@807d17220dc6. The effective changes can be seen here.
This change is