Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libbot, use new repo #4680

Merged

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Jan 4, 2017

Update libbot to bring in RobotLocomotion/libbot2#2, which fixes the last remaining bits of #3231. This also switches us to the new repository which shares history with upstream. (The old repository was separately copied from the old subversion repository, and had the same content but not the same SHA's.)

Fixes #3231.

@david-german-tri for feature and platform review (due to having reviewed the libbot PR).

Note: the old submodule SHA (RobotLocomotion/libbot@6d932c813e6e) corresponds to RobotLocomotion/libbot2@807d17220dc6. The effective changes can be seen here.


This change is Reviewable

Update libbot to bring in RobotLocomotion/libbot2#2, which fixes the
last remaining bits of RobotLocomotion#3231. This also switches us to the new
repository which shares history with upstream. (The old repository was
separately copied from the old subversion repository, and had the same
content but not the same SHA's.)
@david-german-tri
Copy link
Contributor

I don't think I understand how to use this. If I invoke lcm-spy, message details are as absent as ever. If I invoke bot-spy, I get:

~/drake/drake-distro/build$ ./install/bin/bot-spy
Checking /home/dgerman/drake/drake-distro/build/install/share/java
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmtypes_bot2-core.jar
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmtypes_bot2-frames.jar
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmtypes_bot2-param.jar
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmtypes_bot2-procman.jar
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmtypes_drake.jar
   Found /home/dgerman/drake/drake-distro/build/install/share/java/lcmspy_plugins_bot2.jar
./install/bin/bot-spy: 15: exec: lcm-spy: not found

@david-german-tri
Copy link
Contributor

Also, note #3231 (comment)

@mwoehlke-kitware
Copy link
Contributor Author

lcm-spy needs to be in PATH

@david-german-tri
Copy link
Contributor

david-german-tri commented Jan 4, 2017

lcm-spy needs to be in PATH

Yeah, OK. I suppose that's the right thing to do, and it works.

@david-german-tri
Copy link
Contributor

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor

I'll go ahead and merge this, then clean up the remaining #3231 hacks in automotive/.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor

-@ggould-tri


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri david-german-tri merged commit 3114dac into RobotLocomotion:master Jan 5, 2017
@mwoehlke-kitware
Copy link
Contributor Author

I'll go ahead and merge this, then clean up the remaining #3231 hacks in automotive/.

Thanks! I took a brief look at those last night, but it wasn't immediately obvious what to do about them, and it was late. (Particularly, it seems we would want to leverage knowledge of Drake's superbuild to make sure PATH is set.) I was going to take another look this morning, but if you have it covered, that's much appreciated.

@mwoehlke-kitware mwoehlke-kitware deleted the update-libbot branch January 5, 2017 15:12
@jwnimmer-tri
Copy link
Collaborator

Per f2f with David: the automotive_demo.py will soon (1-2 weeks) be Bazel-only per #4574, so it's not worth fixing its CMake superbuild integration.

@david-german-tri
Copy link
Contributor

Particularly, it seems we would want to leverage knowledge of Drake's superbuild to make sure PATH is set.

Yeah. I was planning to glom DRAKE_INSTALL_BIN_DIR into the subprocess PATH env var, when @jwnimmer-tri suggested I just drop it instead. I'm writing it down here in case someone else has the same problem in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run lcm-spy or bot-spy Due To java.lang.NoClassDefFoundError
4 participants