Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bazel 5.1 in Provisioned #16865

Closed
jwnimmer-tri opened this issue Mar 24, 2022 · 6 comments · Fixed by #16926
Closed

Upgrade to Bazel 5.1 in Provisioned #16865

jwnimmer-tri opened this issue Mar 24, 2022 · 6 comments · Fixed by #16926
Assignees
Labels
component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure priority: low unused team: kitware

Comments

@jwnimmer-tri
Copy link
Collaborator

https://github.com/bazelbuild/bazel/releases/tag/5.1.0

Prior issue: #16447.
Prior PR: #16523.

No hurry on this, it's OK for this to wait until the 2022-04-01 externals upgrade / bionic drop time period. I'll be running it locally in the meantime and will chime in about any local problems I see.

@BetsyMcPhail
Copy link
Contributor

Note that Homebrew is still at 5.0.0

@BetsyMcPhail
Copy link
Contributor

BetsyMcPhail commented Mar 28, 2022

@mwoehlke-kitware
Copy link
Contributor

...wheels? (macOS wheel will follow homebrew / CI provisioning, but the Linux wheels need to be updated.)

FYI, I'm running a local wheel build with 5.1.0 now... probably going to take a few hours since this invalidated all of the caching. (Would there be any value in moving Bazel provisioning to after dependencies but before Python provisioning?)

@BetsyMcPhail
Copy link
Contributor

@mwoehlke-kitware tools/wheel/image/provision-base.sh was updated as part of the Linux PR. Where else do I need to update? I probably missed it last time as well so we may be 2 versions out of date.

@mwoehlke-kitware
Copy link
Contributor

Ah, apparently my local checkout is that far out of date 😢 .

@BetsyMcPhail
Copy link
Contributor

Homebrew was updated to 5.1.1 on 4/8. The nightly and weekly unprovisioned jobs ran with the updated version over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: continuous integration Jenkins, CDash, mirroring of externals, website infrastructure priority: low unused team: kitware
Development

Successfully merging a pull request may close this issue.

3 participants