Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bazel 5.0 in Provisioned #16447

Closed
jwnimmer-tri opened this issue Jan 27, 2022 · 8 comments
Closed

Upgrade to Bazel 5.0 in Provisioned #16447

jwnimmer-tri opened this issue Jan 27, 2022 · 8 comments
Assignees
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Jan 27, 2022

https://github.com/bazelbuild/bazel/releases/tag/5.0.0

@jwnimmer-tri jwnimmer-tri self-assigned this Jan 27, 2022
@jwnimmer-tri jwnimmer-tri added component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware labels Jan 27, 2022
@jwnimmer-tri
Copy link
Collaborator Author

I have been running 5.0 locally since it was released, and I haven't seen any problems. Our macOS unprovisioned is also running it without any problems.

FYI see #16405 for a fix (that's already landed) that is required for 5.0. Users of older Drake releases that still want to use Bazel 5.0 should set build --notrim_test_configuration in the drake/user.bazelrc file to work around the problem.

@jwnimmer-tri
Copy link
Collaborator Author

@BetsyMcPhail could you take this on (or delegate it), as part of this week's "monthly dependency upgrades" work?

(For myself, I will check that Anzu is also happy with Bazel 5.)

@BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail could you take this on (or delegate it), as part of this week's "monthly dependency upgrades" work?

Sounds good

@BetsyMcPhail
Copy link
Contributor

@jwnimmer-tri, to make sure we're on the same page, this issue is similar to #15711? Upgrade the requirement within drake and then, eventually if all looks good, the provisioned images?

@jwnimmer-tri
Copy link
Collaborator Author

Yes, perfect!

To be clear -- in this case, though, I think we will not need to update the minimum required version. We have no evidence that bazel 4.0 is incompatible with current Drake. If you'd like to locally install 4.0 and try a Release build to confirm or refute, that's fine too, but is not especially important.

@BetsyMcPhail
Copy link
Contributor

Linux images have been updated.

@BetsyMcPhail
Copy link
Contributor

Mac images are also updated

@BetsyMcPhail
Copy link
Contributor

And PR for unprovisioned images is merged. All set to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low unused team: kitware
Development

No branches or pull requests

2 participants