Skip to content

Conversation

@cpcallen
Copy link
Collaborator

@cpcallen cpcallen commented May 6, 2025

The basics

The details

Proposed Changes

  • Fix clean:node npm script that was inadvertently broken by a mistranscription in PR fix: add lerna commands to plugins package.json #2453.
  • Bump blockly dev dependency to v12.0.0-beta.4.
  • Fix type of FieldColour.prototype.isFullBlockField, as superclass method becomes public in v12.0.0.
  • Fix FieldMultilineInput to not depend on Field.NBSP, which was temporarily removed.
    • Include a TODO to reinstate use of .NBSP where appropriate.
  • Fix FieldGridDropdown to not fail type checking due to the introduction of spacers.

Reason for Changes

Keep samples working with v12.

Test Coverage

Passes npm test (at least, I think it does—FieldDate tests always fail when tested outside the US!)

Have not done manual testing of individual plugins.

@cpcallen cpcallen requested a review from a team as a code owner May 6, 2025 18:48
@cpcallen cpcallen requested review from RoboErikG and removed request for a team May 6, 2025 18:48
@cpcallen
Copy link
Collaborator Author

cpcallen commented May 6, 2025

@RoboErikG or anyone on the team: I recommend you merge this once it has been approved. Can't auto-merge due to there being no rule blocking merge without review.

BenHenning
BenHenning previously approved these changes May 6, 2025
Copy link
Collaborator

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpcallen. Going ahead and approving to unblock.

@BenHenning
Copy link
Collaborator

Though, I think there are other failures still @cpcallen.

@BenHenning BenHenning dismissed their stale review May 6, 2025 19:03

Dismissing since CI is failing.

@cpcallen cpcallen force-pushed the chore/blockly_v12-beta.4 branch from bc3c7ec to 7af1368 Compare May 7, 2025 22:38
@cpcallen cpcallen marked this pull request as draft May 7, 2025 22:39
@cpcallen cpcallen force-pushed the chore/blockly_v12-beta.4 branch 2 times, most recently from bc3c7ec to 2102204 Compare May 7, 2025 22:44
@cpcallen cpcallen marked this pull request as ready for review May 8, 2025 01:12
@cpcallen cpcallen marked this pull request as draft May 8, 2025 01:21
@cpcallen cpcallen marked this pull request as ready for review May 8, 2025 01:32
@cpcallen
Copy link
Collaborator Author

cpcallen commented May 8, 2025

OK, despite what GitHub is currently telling me ("All checks have passed"), the keyboard-navigation plugin is still unbuildable due to too many breaking changes in core. I was going to delete it in this PR but remembered that that might cause many other plugins to get a major version bump, so I separated the deletion out into #2508.

This PR's tests should all pass once that PR has been merged.

N.B. there have been additional commits added since @BenHenning approved.

@cpcallen cpcallen force-pushed the chore/blockly_v12-beta.4 branch from b2fd23a to 0a561fb Compare May 8, 2025 22:33
@cpcallen
Copy link
Collaborator Author

cpcallen commented May 8, 2025

Superceded by #2509.

@cpcallen cpcallen closed this May 8, 2025
@cpcallen
Copy link
Collaborator Author

cpcallen commented May 8, 2025

OK, #2509 had test failures in CI that I did not discover when running test locally, so I'm going to reopen this one for now and leave the update to -beta.5 until I can fix those test failures.

@maribethb
Copy link
Contributor

Going to merge this so can do the .5 changes separately.

@maribethb maribethb merged commit 735959d into RaspberryPiFoundation:rc/v12.0.0 May 9, 2025
14 checks passed
@cpcallen cpcallen deleted the chore/blockly_v12-beta.4 branch May 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants