-
Notifications
You must be signed in to change notification settings - Fork 661
chore(deps): Update blockly dev dependency to [email protected]
#2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update blockly dev dependency to [email protected]
#2504
Conversation
|
@RoboErikG or anyone on the team: I recommend you merge this once it has been approved. Can't auto-merge due to there being no rule blocking merge without review. |
BenHenning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpcallen. Going ahead and approving to unblock.
|
Though, I think there are other failures still @cpcallen. |
bc3c7ec to
7af1368
Compare
bc3c7ec to
2102204
Compare
|
OK, despite what GitHub is currently telling me ("All checks have passed"), the This PR's tests should all pass once that PR has been merged. N.B. there have been additional commits added since @BenHenning approved. |
This was inadvertently broken by a mistranscription in PR RaspberryPiFoundation#2453.
Method on superclass became public in v12.0.0.
Workaround for removal of that constant in RaspberryPiFoundation/blockly#8738.
b2fd23a to
0a561fb
Compare
|
Superceded by #2509. |
|
OK, #2509 had test failures in CI that I did not discover when running test locally, so I'm going to reopen this one for now and leave the update to |
|
Going to merge this so can do the .5 changes separately. |
The basics
The details
Proposed Changes
clean:nodenpm script that was inadvertently broken by a mistranscription in PR fix: add lerna commands to plugins package.json #2453.blocklydev dependency to v12.0.0-beta.4.FieldColour.prototype.isFullBlockField, as superclass method becomes public in v12.0.0.FieldMultilineInputto not depend onField.NBSP, which was temporarily removed.TODOto reinstate use of.NBSPwhere appropriate.FieldGridDropdownto not fail type checking due to the introduction of spacers.Reason for Changes
Keep samples working with v12.
Test Coverage
Passes
npm test(at least, I think it does—FieldDatetests always fail when tested outside the US!)Have not done manual testing of individual plugins.