Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@eslint/js": "^8.49.0",
"@typescript-eslint/eslint-plugin": "^6.7.2",
"@typescript-eslint/parser": "^6.7.2",
"blockly": "^12.0.0-beta.1",
"blockly": "^12.0.0-beta.4",
"conventional-changelog-conventionalcommits": "^5.0.0",
"eslint": "^8.49.0",
"eslint-config-google": "^0.14.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/field-colour/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"typescript": "^5.4.5"
},
"peerDependencies": {
"blockly": "^11.0.0"
"blockly": "^12.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion plugins/field-colour/src/field_colour.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export class FieldColour extends Blockly.Field<string> {
*
* @returns True if this field should take up the full block. False otherwise.
*/
protected isFullBlockField(): boolean {
override isFullBlockField(): boolean {
const block = this.getSourceBlock();
if (!block) throw new Blockly.UnattachedFieldError();

Expand Down
5 changes: 4 additions & 1 deletion plugins/field-grid-dropdown/src/grid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

import {utils, browserEvents, MenuOption} from 'blockly/core';
import {utils, browserEvents, MenuOption, FieldDropdown} from 'blockly/core';
import {GridItem} from './grid_item';

/**
Expand Down Expand Up @@ -88,6 +88,9 @@ export class Grid {
private populateItems(options: MenuOption[]) {
let row = document.createElement('div');
for (const [index, item] of options.entries()) {
// TODO(#2507): Don't just ignore separators.
if (item === FieldDropdown.SEPARATOR) continue;

if (index % this.columns === 0) {
row = document.createElement('div');
row.className = 'blocklyFieldGridRow';
Expand Down
7 changes: 5 additions & 2 deletions plugins/field-multilineinput/src/field_multilineinput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,11 @@ export class FieldMultilineInput extends Blockly.FieldTextInput {
);
}
let textLines = this.getText();
// TODO(google/blockly#8738): Use minimum-width setting mechanism
// to be introduced in PR #9011.
if (!textLines) {
// Prevent the field from disappearing if empty.
return Blockly.Field.NBSP;
return '\u00A0'; // Non-breaking space.
}
const lines = textLines.split('\n');
textLines = '';
Expand All @@ -182,7 +184,8 @@ export class FieldMultilineInput extends Blockly.FieldTextInput {
}
// Replace whitespace with non-breaking spaces so the text doesn't
// collapse.
text = text.replace(/\s/g, Blockly.Field.NBSP);
// TODO(google/blockly#8738): Use Blockly.Field.NBSP.
text = text.replace(/\s/g, '\u00A0'); // Non-breaking space.

textLines += text;
if (i !== displayLinesNumber - 1) {
Expand Down
2 changes: 1 addition & 1 deletion plugins/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"boot": "lerna bootstrap",
"build": "lerna run build",
"clean": "lerna run clean",
"clean:node": "lerna run clean --yes",
"clean:node": "lerna clean --yes",
"postinstall": "npm run boot",
"predeploy": "lerna run predeploy",
"test": "lerna run test"
Expand Down
Loading