-
Notifications
You must be signed in to change notification settings - Fork 661
chore(deps): Update blockly dev dependency to [email protected]
#2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update blockly dev dependency to [email protected]
#2509
Conversation
This was inadvertently broken by a mistranscription in PR RaspberryPiFoundation#2453.
Method on superclass became public in v12.0.0.
Workaround for removal of that constant in RaspberryPiFoundation/blockly#8738.
|
Converting to draft until I can investigate test failures. In the mean time, I reopened #2504 which contains the first five of the eight commits in this PR. |
|
I've rebased this onto rc/v12.0.0 (after merging #2504) and it passes locally for me, which I suppose is where Christopher left off. |
|
The tests fail because |
|
Thank you Christopher! This was used as the base for #2524 so the commits were merged there. |
The basics
The details
Proposed Changes
clean:nodenpm script that was inadvertently broken by a mistranscription in PR fix: add lerna commands to plugins package.json #2453.blocklydev dependency to v12.0.0-beta.4.FieldColour.prototype.isFullBlockField, as superclass method becomes public in v12.0.0.FieldMultilineInputto not depend onField.NBSP, which was temporarily removed.TODOto reinstate use of.NBSPwhere appropriate.FieldGridDropdownto not fail type checking due to the introduction of spacers inMenuOptions.blocklydev dependency to v12.0.0-beta.5.FieldBitmapandFieldColourby implementing abstractgetClassmethod added in refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. blockly#8992.FieldGridDropdownto not fail type checking due to the introduction ofHTMLElementinMenuOptions.Reason for Changes
Keep samples working with v12.
Test Coverage
Passes
npm test(at least, I think it does—FieldDatetests always fail when tested outside the US!)Have not done manual testing of individual plugins.