Skip to content

Conversation

@cpcallen
Copy link
Collaborator

@cpcallen cpcallen commented May 8, 2025

The basics

The details

Proposed Changes

  • Fix clean:node npm script that was inadvertently broken by a mistranscription in PR fix: add lerna commands to plugins package.json #2453.
  • Bump blockly dev dependency to v12.0.0-beta.4.
  • Fix type of FieldColour.prototype.isFullBlockField, as superclass method becomes public in v12.0.0.
  • Fix FieldMultilineInput to not depend on Field.NBSP, which was temporarily removed.
    • Include a TODO to reinstate use of .NBSP where appropriate.
  • Fix FieldGridDropdown to not fail type checking due to the introduction of spacers in MenuOptions.
  • Bump blockly dev dependency to v12.0.0-beta.5.
  • Fix compilation failures for FieldBitmap and FieldColour by implementing abstract getClass method added in refactor!: Use navigation rulesets instead of ASTNode to control keyboard navigation. blockly#8992.
  • Fix FieldGridDropdown to not fail type checking due to the introduction of HTMLElement in MenuOptions.

Reason for Changes

Keep samples working with v12.

Test Coverage

Passes npm test (at least, I think it does—FieldDate tests always fail when tested outside the US!)

Have not done manual testing of individual plugins.

@cpcallen cpcallen requested a review from a team as a code owner May 8, 2025 22:42
@cpcallen cpcallen requested review from rachel-fenichel and removed request for a team May 8, 2025 22:42
@cpcallen cpcallen marked this pull request as draft May 8, 2025 23:07
@cpcallen
Copy link
Collaborator Author

cpcallen commented May 8, 2025

Converting to draft until I can investigate test failures.

In the mean time, I reopened #2504 which contains the first five of the eight commits in this PR.

@maribethb
Copy link
Contributor

I've rebased this onto rc/v12.0.0 (after merging #2504) and it passes locally for me, which I suppose is where Christopher left off.

@maribethb
Copy link
Contributor

The tests fail because field_dropdown now does a instanceof HTMLElement check in its code, and that fails when running these tests on CI because HTMLElement is not defined in node. I think this might be a legitimate problem for loading headless blocks with dropdown fields in node, but I don't have a great understanding of our current usage of jsdom. It might be that it works fine in core because we use jsdom (or require node users use it??) and we just need to use jsdom in the mocha tests for plugins as well.

@maribethb
Copy link
Contributor

Thank you Christopher! This was used as the base for #2524 so the commits were merged there.

@maribethb maribethb closed this May 15, 2025
@cpcallen cpcallen deleted the chore/blockly_v12-beta.5 branch May 21, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants