fix!: Delete old keyboard-navigation plugin
#2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think removing this makes complete sense, but I want to defer to @maribethb or @rachel-fenichel to make the actual decision since this may affect things I'm not certain of in the external community. |
1 task
maribethb
reviewed
May 8, 2025
Contributor
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
Also needs to be removed from the plugin showcase page.
Doesn't really matter in this exact case since you are deleting the changelog, but generally chore type commits shouldn't be breaking changes, because chores are not included in the release notes/changelog.
Contributor
|
Also, could you update the PR description to contain info that's helpful for people coming here to find out what happened? e.g. point them at the experiment repo |
This depends on things that no longer exist in [email protected], like BasicCursor and Cursor, and also on other things that will cease to exist before 12.0.0, like ASTNode. We need to update the samples repository to be able to test plugins with v12, and this plugin is soon to be replaced by the new plugin being developed in google/blockly-keyboard-experimentation, so the most expedient course of action is just to delete this one to allow upgrading this repo's blockly devDependency. (We could alternatively leave this plugin as an empty shell waiting to be filled with the contents of the blockly-keyboard-experimentation repo, but it seems preferable to not publish publish anything, thus leaving the latest version of the @blockly/keyboard-navigation NPM package useful though outdatedly dependent on blockly@11, rather than publish an empty plugin package that is of no use at all. BREAKING CHANGE: Removes the keyboard-experimentation plugin, obviously.
cpcallen
force-pushed
the
chore/delete-keyboard-nav
branch
from
0384da3 to
1e7d065
Compare
cpcallen
changed the title
keyboard-navigation pluginkeyboard-navigation plugin
Collaborator
Author
Done. |
maribethb
approved these changes
May 8, 2025
BenHenning
pushed a commit
to BenHenning/blockly-samples
that referenced
this pull request
May 12, 2025
This depends on things that no longer exist in [email protected], like BasicCursor and Cursor, and also on other things that will cease to exist before 12.0.0, like ASTNode. We need to update the samples repository to be able to test plugins with v12, and this plugin is soon to be replaced by the new plugin being developed in google/blockly-keyboard-experimentation, so the most expedient course of action is just to delete this one to allow upgrading this repo's blockly devDependency. BREAKING CHANGE: Removes the keyboard-experimentation plugin, obviously. Conflicts: plugins/keyboard-navigation/CHANGELOG.md plugins/keyboard-navigation/package-lock.json plugins/keyboard-navigation/package.json plugins/keyboard-navigation/src/navigation.js plugins/keyboard-navigation/src/navigation_controller.js plugins/keyboard-navigation/test/navigation_test.mocha.js
This was referenced May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Delete
plugins/keyboard-navigation/and contents.Reason for Changes
This plugin depends on too many things that no longer exist in Blockly, like
CursorandBasicCursor, and also on other things that will cease to exist before 12.0.0, likeASTNode.This plugin depends on things that no longer exist in
[email protected], likeBasicCursorandCursor, and alsoon other things that will cease to exist before 12.0.0, like
ASTNode.We need to update the samples repository to be able to test plugins with v12, and this plugin is soon to be replaced by
the new plugin being developed in google/blockly-keyboard-experimentation, so the most expedient course of action is just to delete this one to allow upgrading this repo's
blocklydevDependency.Additional Information
(We could alternatively leave this plugin as an empty shell waiting to be filled with the contents of the
blockly-keyboard-experimentationrepo, but it seems preferable to not publish publish anything, thus leaving the latest version of the@blockly/keyboard-navigationNPM package useful though outdatedly dependent onblockly@11, rather than publish an empty plugin package that is of no use at all.This has been broken out from #2504 so that that PR will not contain any breaking changes, since it affects multiple plugins.
BREAKING CHANGE:
Removes the keyboard-experimentation plugin, obviously.
The plugin will return soon, but in the meantime use the plugin being developed in google/blockly-keyboard-experimentation, published as the
@blockly/keyboard-experimentNPM package.