Reintroduce fix for spirv and unknown architecture when using lookback_scan_state#698
Merged
stanleytsang-amd merged 2 commits intoAug 25, 2025
Conversation
NB4444
requested review from
RobsonRLemos,
stanleytsang-amd and
umfranzw
as code owners
stanleytsang-amd
approved these changes
Jul 16, 2025
Contributor
|
lgtm pending CI checks |
Naraenda
added
project: rocprim
organization: streamhpc
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ROCm/rocPRIM#734 a fix was introduced, something must have gone wrong with rebasing. Here we reintroduce the fix for both spirv and unknown architectures that can not use our 128-bit atomic.