Added generic pragmas and created fallback for atomics#734
Merged
rocm-ci merged 2 commits intoMay 22, 2025
Conversation
Closed
NB4444
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
cgmb
approved these changes
May 20, 2025
Comment on lines
-93
to
+94
| #elif defined(__GFX11__) | ||
| #elif defined(__GFX11__) || defined(__gfx11_generic__) |
Contributor
There was a problem hiding this comment.
It does no harm to do this, but I will note that the __GFX11__ macro is defined whenever __gfx11_generic__ is defined.
Contributor
There was a problem hiding this comment.
| || defined(__gfx90c__) || defined(__gfx9_generic__) | ||
| #define ROCPRIM_TARGET_GCN5 1 | ||
| #elif defined(__GFX12__) | ||
| #elif defined(__GFX12__) || defined(__gfx12_generic__) |
Contributor
There was a problem hiding this comment.
It does no harm to do this, but I will note that the __GFX12__ macro is defined whenever __gfx12_generic__ is defined.
stanleytsang-amd
approved these changes
May 22, 2025
stanleytsang-amd
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 11, 2025
For #67. Seems like this was overlooked in ROCm/rocPRIM#734.
jayhawk-commits
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 17, 2025
For #67. Seems like this was overlooked in ROCm/rocPRIM#734.
stanleytsang-amd
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Aug 25, 2025
…k_scan_state (#698) In ROCm/rocPRIM#734 a fix was introduced, something must have gone wrong with rebasing. Here we reintroduce the fix for both spirv and unknown architectures that can not use our 128-bit atomic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the generic build targets to the config. And created a fallback with warning for unknown types.
#733