Skip to content

Reintroduce fix for spirv and unknown architecture when using lookback_scan_state #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanleytsang-amd merged 2 commits into from
Aug 25, 2025
Merged

Reintroduce fix for spirv and unknown architecture when using lookback_scan_state #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a571b51
MAX_PAYLOAD_SIZE was not used for the fallback implementation that do…
NB4444 Jul 15, 2025
cfa69f0
Change documentation of IsSmall to reflect using MAX_PAYLOAD_SIZE
NB4444 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/rocprim/rocprim/include/rocprim/device/detail/lookback_scan_state.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ constexpr const int MAX_PAYLOAD_SIZE = ROCPRIM_MAX_ATOMIC_SIZE - 1;
///
/// \tparam T The accumulator type of the scan operation.
/// \tparam UseSleep [optional] If true, the execution of a wavefront is paused for a short duration, allowing other threads or processes to execute during idle periods.
/// \tparam IsSmall [optional] Dependent on the size of `T`. If it's smaller than 16 bytes, it's set to true.
template<class T, bool UseSleep = false, bool IsSmall = (sizeof(T) <= 15)>
/// \tparam IsSmall [optional] Dependent on the size of `T`. If it's smaller than 16 bytes (8 bytes if 16 byte atomics are possibly not supported), it's by default set to true.
template<class T, bool UseSleep = false, bool IsSmall = (sizeof(T) <= MAX_PAYLOAD_SIZE)>
struct lookback_scan_state;

/// Reduce lanes `0-valid_items` and return the result in lane 0.
Expand Down
Loading