Warn about upcoming scan accumulator default type change#698
Conversation
umfranzw
requested review from
Naraenda,
NguyenNhuDi,
RobsonRLemos and
stanleytsang-amd
|
Hi @Naraenda, we've received approval to make this change in the next ROCm release. I'm proposing to update the defaults to the way they are currently in hipCUB, as we'd discussed a while back. Please feel free to let me know if you think the new defaults I've proposed need to be adjusted. |
spolifroni-amd
left a comment
spolifroni-amd
left a comment
There was a problem hiding this comment.
Where the comment is needs to change depending on which version the change is going to be in.
Regardless, please let me know which version it will be so I can tweak the language.
In the next major release, we'll be modifying the default scan accumulator type for device-level scan algorithms. Add a note to the changelog to warn users that this change will be coming soon, and describe how the default type will be changed.
umfranzw
force-pushed
the
scan_accum_default_changelog
branch
from
1a8686b to
119a9e9
Compare
|
Hi @spolifroni-amd, would you mind taking one more pass on this, and marking the changes you'd requested as completed? We'd like to get this merged shortly if possible. Thanks! |
Looks good! Approved. |
In the next major release, we'll be modifying the default scan accumulator type for device-level scan algorithms. Add a note to the changelog to warn users that this change will be coming soon, and describe how the default type will be changed. [ROCm/rocPRIM commit: 70eac44]
4 participants
In the next major release, we'll be modifying the default scan accumulator type for device-level scan algorithms.
Add a note to the changelog to warn users that this change will be coming soon, and describe how the default type will be changed.