[CI Test] Build + test fusilli pulled from rocm-libraries#3912
Closed
AaronStGeorge wants to merge 3 commits into
Closed
[CI Test] Build + test fusilli pulled from rocm-libraries#3912AaronStGeorge wants to merge 3 commits into
rocm-libraries#3912AaronStGeorge wants to merge 3 commits into
Conversation
Point the fusilliprovider subproject at rocm-libraries/dnn-providers/fusilli-provider instead of iree-libs/fusilli/plugins/hipdnn-plugin. Add rocm-libraries to the fusilli-libs artifact group source_sets in BUILD_TOPOLOGY.toml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d31a103 to
db345a3
Compare
rocm-librariesrocm-libraries
1 task
db345a3 to
d4dc6ec
Compare
AaronStGeorge
added a commit
that referenced
this pull request
Mar 12, 2026
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Update TheRock build for fusilli provider to pull from new location in `rocm-libraries` (see: ROCm/rocm-libraries#5149) ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> Really just a couple boilerplate additions. Note: as an optimization, we may want to add a feature to allow a sparse checkout when fetching the `rocm-libraries` source set ([link](https://github.com/ROCm/TheRock/pull/3791/changes#diff-9c53c23f4ebfe2986e8dfe8af30208eb6a1a6294946bb07b8fd69f9e1b84d379R317)). The `fusilli-libs` stage is only using a very small portion of that repo. ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> As the IREE / fusilli build are not enabled by default, see this test branch with temporary changes required to enable the IREE / fusilli build: #3912 ## Test Result <!-- Briefly summarize test outcomes. --> It works! [successful build + CI](https://github.com/ROCm/TheRock/actions/runs/22972523986/job/66726952506?pr=3912) ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
geomin12
reviewed
Mar 12, 2026
Contributor
geomin12
left a comment
There was a problem hiding this comment.
FYI you can use workflow dispatches: https://github.com/ROCm/TheRock/blob/main/docs/development/ci_behavior_manipulation.md#workflow-dispatch-behavior to test with pre-existing artifacts and run just one build / test :)
since this is just for testing. it does looks like it works though !!!
Contributor
There was a problem hiding this comment.
we also want to keep submodule bumps by its own, but this is just for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a test branch for #3791 that includes temporary changes needed to build fusilli provider from it's new location in
rocm-libraries(merged in #3791).Technical Details
The PR rolls includes the changes from #3791, bumps
rocm-librariesto the point where (merged) ROCm/rocm-libraries#5149 will be included, enables tests that are otherwise default disabled until such time as fusilli+ IREE build by default.Test Plan
Test Result
Submission Checklist