Skip to content

[CI Test] Build + test fusilli pulled from rocm-libraries#3912

Closed
AaronStGeorge wants to merge 3 commits into
mainfrom
multi_arch/p036-move-fusilli-plugin-to-rocm-libs_test
Closed

[CI Test] Build + test fusilli pulled from rocm-libraries#3912
AaronStGeorge wants to merge 3 commits into
mainfrom
multi_arch/p036-move-fusilli-plugin-to-rocm-libs_test

Conversation

@AaronStGeorge
Copy link
Copy Markdown
Contributor

@AaronStGeorge AaronStGeorge commented Mar 11, 2026

Motivation

This is a test branch for #3791 that includes temporary changes needed to build fusilli provider from it's new location in rocm-libraries (merged in #3791).

Technical Details

The PR rolls includes the changes from #3791, bumps rocm-libraries to the point where (merged) ROCm/rocm-libraries#5149 will be included, enables tests that are otherwise default disabled until such time as fusilli+ IREE build by default.

Test Plan

Test Result

Submission Checklist

AaronStGeorge and others added 2 commits March 11, 2026 18:14
Point the fusilliprovider subproject at rocm-libraries/dnn-providers/fusilli-provider
instead of iree-libs/fusilli/plugins/hipdnn-plugin. Add rocm-libraries to the
fusilli-libs artifact group source_sets in BUILD_TOPOLOGY.toml.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AaronStGeorge AaronStGeorge requested a review from a team as a code owner March 11, 2026 18:32
@AaronStGeorge AaronStGeorge marked this pull request as draft March 11, 2026 18:32
@AaronStGeorge AaronStGeorge force-pushed the multi_arch/p036-move-fusilli-plugin-to-rocm-libs_test branch from d31a103 to db345a3 Compare March 11, 2026 18:33
@AaronStGeorge AaronStGeorge changed the title [CI Test] Build + test fusilli when pulled from rocm-libraries [CI Test] Build + test fusilli pulled from rocm-libraries Mar 11, 2026
@AaronStGeorge AaronStGeorge force-pushed the multi_arch/p036-move-fusilli-plugin-to-rocm-libs_test branch from db345a3 to d4dc6ec Compare March 11, 2026 20:17
AaronStGeorge added a commit that referenced this pull request Mar 12, 2026
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Update TheRock build for fusilli provider to pull from new location in
`rocm-libraries` (see: ROCm/rocm-libraries#5149)

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

Really just a couple boilerplate additions.

Note: as an optimization, we may want to add a feature to allow a sparse
checkout when fetching the `rocm-libraries` source set
([link](https://github.com/ROCm/TheRock/pull/3791/changes#diff-9c53c23f4ebfe2986e8dfe8af30208eb6a1a6294946bb07b8fd69f9e1b84d379R317)).
The `fusilli-libs` stage is only using a very small portion of that
repo.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

As the IREE / fusilli build are not enabled by default, see this test
branch with temporary changes required to enable the IREE / fusilli
build: #3912

## Test Result

<!-- Briefly summarize test outcomes. -->

It works! [successful build +
CI](https://github.com/ROCm/TheRock/actions/runs/22972523986/job/66726952506?pr=3912)

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can use workflow dispatches: https://github.com/ROCm/TheRock/blob/main/docs/development/ci_behavior_manipulation.md#workflow-dispatch-behavior to test with pre-existing artifacts and run just one build / test :)

since this is just for testing. it does looks like it works though !!!

Comment thread rocm-libraries
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also want to keep submodule bumps by its own, but this is just for testing

@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants