Skip to content

Use fusilli-provider defined in rocm-libraries#3791

Merged
AaronStGeorge merged 1 commit into
mainfrom
multi_arch/p036-move-fusilli-plugin-to-rocm-libs
Mar 12, 2026
Merged

Use fusilli-provider defined in rocm-libraries#3791
AaronStGeorge merged 1 commit into
mainfrom
multi_arch/p036-move-fusilli-plugin-to-rocm-libs

Conversation

@AaronStGeorge
Copy link
Copy Markdown
Contributor

@AaronStGeorge AaronStGeorge commented Mar 5, 2026 •
edited
Loading

Motivation

Update TheRock build for fusilli provider to pull from new location in rocm-libraries (see: ROCm/rocm-libraries#5149)

Technical Details

Really just a couple boilerplate additions.

Note: as an optimization, we may want to add a feature to allow a sparse checkout when fetching the rocm-libraries source set (link). The fusilli-libs stage is only using a very small portion of that repo.

Test Plan

As the IREE / fusilli build are not enabled by default, see this test branch with temporary changes required to enable the IREE / fusilli build: #3912

Test Result

It works! successful build + CI

Submission Checklist

@AaronStGeorge AaronStGeorge mentioned this pull request Mar 5, 2026
Merged
1 task
sjain-stanford
sjain-stanford reviewed Mar 5, 2026
View reviewed changes
Comment thread .github/workflows/multi_arch_build_portable_linux.yml
@AaronStGeorge AaronStGeorge mentioned this pull request Mar 5, 2026
Merged
1 task
@AaronStGeorge AaronStGeorge force-pushed the multi_arch/p036-move-fusilli-plugin-to-rocm-libs branch from 026a455 to 34105dc Compare March 5, 2026 20:59
AaronStGeorge added a commit to AaronStGeorge/TheRock that referenced this pull request Mar 6, 2026
@AaronStGeorge @claude
Bump IREE and fusilli submodules to match ROCm#3791
0fe8e90 
- iree: 4802bac → 1fe030b
- fusilli: 4e1cf4f → 4077c75

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AaronStGeorge added a commit to ROCm/rocm-libraries that referenced this pull request Mar 11, 2026
@AaronStGeorge @claude
[fusilli-provider] Add fusilli-provider to dnn-providers (#5149)
36497b5 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Copy the fusilli hipDNN plugin from
[`iree-org/fusilli`](https://github.com/iree-org/fusilli/tree/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin)
to `rocm-libraries/dnn-providers` so it lives alongside the other hipDNN
providers (`miopen-provider`, `hipblaslt-provider`).

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->


[`ThePebble.py`](https://github.com/iree-org/fusilli/blob/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin/build_tools/ThePebble.py)
is removed as it's no longer necessary, but other than that there are no
other code changes, this is a copy paste.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Take a look at the associated PR in TheRock to see working CI: [link to
pr](ROCm/TheRock#3791), [link to successful run
of fusilli provider
tests](https://github.com/ROCm/TheRock/actions/runs/22736501150/job/65959962519?pr=3791).

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
kokolchin pushed a commit to kokolchin/rocm-libraries that referenced this pull request Mar 11, 2026
@AaronStGeorge @claude
[fusilli-provider] Add fusilli-provider to dnn-providers (ROCm#5149)
8289463 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Copy the fusilli hipDNN plugin from
[`iree-org/fusilli`](https://github.com/iree-org/fusilli/tree/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin)
to `rocm-libraries/dnn-providers` so it lives alongside the other hipDNN
providers (`miopen-provider`, `hipblaslt-provider`).

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->


[`ThePebble.py`](https://github.com/iree-org/fusilli/blob/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin/build_tools/ThePebble.py)
is removed as it's no longer necessary, but other than that there are no
other code changes, this is a copy paste.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Take a look at the associated PR in TheRock to see working CI: [link to
pr](ROCm/TheRock#3791), [link to successful run
of fusilli provider
tests](https://github.com/ROCm/TheRock/actions/runs/22736501150/job/65959962519?pr=3791).

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@AaronStGeorge AaronStGeorge changed the title [CI Test] Build fusilli-provider from rocm-libraries Use fusilli-provider defined in rocm-libraries Mar 11, 2026
@AaronStGeorge AaronStGeorge force-pushed the multi_arch/p036-move-fusilli-plugin-to-rocm-libs branch from 34105dc to 30b3589 Compare March 11, 2026 18:37
@AaronStGeorge AaronStGeorge marked this pull request as ready for review March 11, 2026 18:39
@AaronStGeorge AaronStGeorge mentioned this pull request Mar 11, 2026
Closed
1 task
@AaronStGeorge @claude
Move fusilli plugin source from iree-libs to rocm-libraries
7000c11 
Point the fusilliprovider subproject at rocm-libraries/dnn-providers/fusilli-provider
instead of iree-libs/fusilli/plugins/hipdnn-plugin. Add rocm-libraries to the
fusilli-libs artifact group source_sets in BUILD_TOPOLOGY.toml.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AaronStGeorge AaronStGeorge force-pushed the multi_arch/p036-move-fusilli-plugin-to-rocm-libs branch from 90426d1 to 7000c11 Compare March 12, 2026 02:43
sjain-stanford
sjain-stanford reviewed Mar 12, 2026
View reviewed changes
Comment thread BUILD_TOPOLOGY.toml
artifact_group_deps = ["hip-runtime", "iree-compiler"]
# TODO: rocm-systems included for projects/hip/VERSION (see CMakeLists.txt)
source_sets = ["iree-libs", "rocm-systems"]
source_sets = ["iree-libs", "rocm-libraries", "rocm-systems"]
Copy link
Copy Markdown
Member

@sjain-stanford sjain-stanford Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, where do we specify that this is a sparse checkout of rocm-libs? Or is that future work (after hipdnn moves to the core stage)?

Copy link
Copy Markdown
Contributor Author

@AaronStGeorge AaronStGeorge Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's future work, it's not a sparse checkout at the moment.

Note: as an optimization, we may want to add a feature to allow a sparse checkout when fetching the rocm-libraries source set (link). The fusilli-libs stage is only using a very small portion of that repo.

@AaronStGeorge AaronStGeorge merged commit ff39cb9 into main Mar 12, 2026
59 of 65 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Mar 12, 2026
@AaronStGeorge AaronStGeorge deleted the multi_arch/p036-move-fusilli-plugin-to-rocm-libs branch March 12, 2026 16:37
jovanau pushed a commit to jovanau/rocm-libraries that referenced this pull request Mar 19, 2026
@AaronStGeorge @claude @jovanau
[fusilli-provider] Add fusilli-provider to dnn-providers (ROCm#5149)
de0ef70 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

Copy the fusilli hipDNN plugin from
[`iree-org/fusilli`](https://github.com/iree-org/fusilli/tree/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin)
to `rocm-libraries/dnn-providers` so it lives alongside the other hipDNN
providers (`miopen-provider`, `hipblaslt-provider`).

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->


[`ThePebble.py`](https://github.com/iree-org/fusilli/blob/369d94a246440e183ae1ad185db36e6c8dd36cbb/plugins/hipdnn-plugin/build_tools/ThePebble.py)
is removed as it's no longer necessary, but other than that there are no
other code changes, this is a copy paste.

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Take a look at the associated PR in TheRock to see working CI: [link to
pr](ROCm/TheRock#3791), [link to successful run
of fusilli provider
tests](https://github.com/ROCm/TheRock/actions/runs/22736501150/job/65959962519?pr=3791).

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjain-stanford sjain-stanford sjain-stanford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

TheRock Triage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AaronStGeorge @sjain-stanford