Changing sgpr limits (#304)#514
Merged
Merged
Conversation
AlexBrownAMD
approved these changes
Jul 7, 2025
stanleytsang-amd
pushed a commit
to stanleytsang-amd/rocm-libraries
that referenced
this pull request
Jul 8, 2025
* Structuring backend (ROCm#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (ROCm#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (ROCm#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com>
bstefanuk
pushed a commit
that referenced
this pull request
Jul 8, 2025
* Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric
In regards to LWPTENSILE-1696 This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: mahmoodw <wmahmood@amd.com> Co-authored-by: mahmoodw <44450175+mahmoodw@users.noreply.github.com>
AlexBrownAMD
force-pushed
the
users/mahmoodw/sgprLimit
branch
from
18e667f to
62bd644
Compare
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Jul 10, 2025
Changing sgpr limits (#304) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric [ROCm/rocSPARSEcommit: 151145a]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Structuring backend (#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com> [ROCm/rocSPARSEcommit: 22d1de0]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Structuring backend (#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com> [ROCm/rocSPARSE commit: 22d1de0]
AlexBrownAMD
pushed a commit
that referenced
this pull request
Jul 15, 2025
This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: mahmoodw <wmahmood@amd.com>
SathiyarajRam
pushed a commit
that referenced
this pull request
Jul 15, 2025
This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: mahmoodw <wmahmood@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Oct 27, 2025
…s-core-1.18.1 Bump rocm-docs-core from 1.17.1 to 1.18.1 in /docs/sphinx
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
…s-core-1.18.1 Bump rocm-docs-core from 1.17.1 to 1.18.1 in /docs/sphinx [ROCm/rocwmma commit: b0fff32]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes 2 changes:
🔁 Imported from
ROCm/hipBLASLt#2184 🧑💻 Originally authored by @mahmoodw