Fix typos in VirtualWaveSize warning#495
Merged
stanleytsang-amd merged 1 commit intoAug 11, 2025
Merged
Conversation
assistant-librarian
Bot
added
project: rocprim
external contribution
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
3 times, most recently
from
a3d2ad4 to
b7db489
Compare
Contributor
Author
|
Rebased. |
stanleytsang-amd
pushed a commit
to stanleytsang-amd/rocm-libraries
that referenced
this pull request
Jul 8, 2025
* Structuring backend (ROCm#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (ROCm#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (ROCm#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com>
reboss
pushed a commit
to reboss/rocm-libraries
that referenced
this pull request
Jul 8, 2025
* split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
b7db489 to
12286ad
Compare
matyas-streamhpc
requested review from
RobsonRLemos and
stanleytsang-amd
as code owners
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
12286ad to
a16b63c
Compare
Contributor
Author
|
rebased |
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc [ROCm/rocSPARSEcommit: a2c27a3]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Structuring backend (#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com> [ROCm/rocSPARSEcommit: 22d1de0]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Structuring backend (#495) * split rocsparse_handle.hpp * split rocsparse_handle.cpp * structuring trm_info without behaviour change * fixing test failure related to copy_mat_info * Fixing default initialization of rocsparse_trm_info. Removing error prone cast when calling hipMalloc * Fixing missing behavior check in spgeam (#514) * Fixing missing behavior check. * stage analysis and stage symbolic are not required for stage numeric * spgeam final fix (#516) * spgeam fix --------- Co-authored-by: Yvan Mokwinski <yvan.mokwinski@gmail.com> [ROCm/rocSPARSE commit: 22d1de0]
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
a16b63c to
bce84b9
Compare
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
bce84b9 to
e1c33fe
Compare
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
e1c33fe to
7793aaa
Compare
Contributor
Author
|
rebased |
ammallya
pushed a commit
that referenced
this pull request
Jul 22, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.4.1...v1.5.0) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/hipSPARSE commit: 337dea3]
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
2 times, most recently
from
1f213cc to
2406dd1
Compare
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
2406dd1 to
ed5a921
Compare
Contributor
Author
|
rebased |
matyas-streamhpc
force-pushed
the
32-fix-typos-in-virtualwavesize-warning
branch
from
ed5a921 to
a4b3ab9
Compare
Contributor
Author
|
rebased |
stanleytsang-amd
approved these changes
Aug 8, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Aug 11, 2025
Fix typos in VirtualWaveSize warning Fix warning message from `VirtualWaveSize must be a power of two and equal or lessthan the size of hardware warp.` to `VirtualWaveSize must be a power of two and equal or less than the size of hardware warp.`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warning message from
VirtualWaveSize must be a power of two and equal or lessthan the size of hardware warp.to
VirtualWaveSize must be a power of two and equal or less than the size of hardware warp.