Changing sgpr limits#304
Merged
Merged
Conversation
jayhawk-commits
requested review from
AlexBrownAMD,
Jinp800125,
KKyang,
Serge45,
TonyYHsieh,
aazz44ss,
hcman2,
imcarsonliao,
jichangjichang,
solaslin and
vin-huang
KKyang
reviewed
Jun 26, 2025
KKyang
approved these changes
Jun 30, 2025
AlexBrownAMD
approved these changes
Jun 30, 2025
KKyang
force-pushed
the
import/develop/mahmoodw_hipBLASLt/sgprLimit
branch
from
88c3b8e to
36a8b1d
Compare
Contributor
|
Rather than references tickets, lets put the full description in the PR. Indirection hurts. |
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Jul 3, 2025
Changing sgpr limits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In regards to LWPTENSILE-1696 This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits
AlexBrownAMD
pushed a commit
that referenced
this pull request
Jul 9, 2025
In regards to LWPTENSILE-1696 This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: mahmoodw <wmahmood@amd.com> Co-authored-by: mahmoodw <44450175+mahmoodw@users.noreply.github.com>
mahmoodw
added a commit
that referenced
this pull request
Jul 10, 2025
This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: mahmoodw <wmahmood@amd.com>
AlexBrownAMD
pushed a commit
that referenced
this pull request
Jul 15, 2025
This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: mahmoodw <wmahmood@amd.com>
SathiyarajRam
pushed a commit
that referenced
this pull request
Jul 15, 2025
This includes 2 changes: - Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels - Account for additional temp sgprs that will be required for code gen, up to physical limits --- 🔁 Imported from [ROCm/hipBLASLt#2184](ROCm/hipBLASLt#2184) 🧑💻 Originally authored by @mahmoodw --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: mahmoodw <wmahmood@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Jul 31, 2025
[ROCm/hipFFT commit: 2b7d096]
ammallya
pushed a commit
that referenced
this pull request
Nov 5, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.9.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.9.0...v1.9.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 5, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.9.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.9.0...v1.9.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/hipTensor commit: b22d173]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In regards to LWPTENSILE-1696
This includes 2 changes:
🔁 Imported from ROCm/hipBLASLt#2184
🧑💻 Originally authored by @mahmoodw