rocPRIM: Adapt ifdefs to generic architectures#77
Merged
stanleytsang-amd merged 1 commit intoJun 11, 2025
Conversation
assistant-librarian
Bot
added
project: rocprim
external contribution
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@mkuron Can you target the release-staging/rocm-rel-7.0 branch here instead of develop? Thanks. |
mkuron
requested review from
a team,
RobsonRLemos,
lawruble13 and
umfranzw
as code owners
Contributor
Author
|
Rebased to 7.0. Let me know if there is anything else you want me to change. |
Contributor
Author
|
@stanleytsang-amd, could you please review? There are some failing build jobs whose logs I can't access but I presume these are unrelated to my changes. |
stanleytsang-amd
approved these changes
Jun 11, 2025
Contributor
stanleytsang-amd
left a comment
stanleytsang-amd
left a comment
There was a problem hiding this comment.
Apologies for the delay. The CI failures are unrelated to your changes. The rest of the pipelines passed.
stanleytsang-amd
merged commit 58717d2
into
ROCm:release-staging/rocm-rel-7.0
15 of 17 checks passed
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Jun 11, 2025
jayhawk-commits
pushed a commit
that referenced
this pull request
Jun 17, 2025
For #67. Seems like this was overlooked in ROCm/rocPRIM#734.
jayhawk-commits
added a commit
that referenced
this pull request
Jun 18, 2025
### Includes the following PRs: - #76 - #77 - #78 - #90 - #135 - #150 - #192 --------- Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: Nara Prasetya <nara@streamhpc.com> Co-authored-by: Michael Kuron <1748330+mkuron@users.noreply.github.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Add engine plugin resource manager * The test plugins were refactored
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Add engine plugin resource manager * The test plugins were refactored [ROCm/hipDNN commit: 35d42e4]
evetsso
pushed a commit
to evetsso/rocm-libraries
that referenced
this pull request
Dec 31, 2025
Merge from public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #67. Seems like this was overlooked in ROCm/rocPRIM#734.