fix(emulation): package rocjitsu hooks and CLI test payload by newling · Pull Request #6517 · ROCm/TheRock

newling · 2026-07-13T18:32:35Z

Motivation

The rocjitsu build installs its runtime library, instrumentation hook, CLI, configs, and schemas, but the artifact descriptor did not package all of that test tooling.

This change makes the installed rocjitsu CLI available to CI and development workflows that fetch rocjitsu test artifacts.

Summary

include librocjitsu_hooks.so alongside librocjitsu.so in the lib artifact
validate librocjitsu_hooks.so as an installed shared library
add a test component containing bin/rocjitsu
keep configs and schemas in the run artifact through share/rocjitsu/**

The CLI is available when rocjitsu test artifacts are fetched, for example with:

install_rocm_from_artifacts.py --rocjitsu --tests

Local validation

Ran the artifact descriptor overlap unit test: python3 -m unittest build_tools.tests.artifact_descriptor_overlap_test
Ran git diff --check on the changed descriptor.
Ran build_tools/fileset_tool.py artifact against a temporary synthetic rocjitsu install tree and confirmed the descriptor routes:
- lib/librocjitsu.so and lib/librocjitsu_hooks.so to the lib artifact
- bin/rocjitsu to the test artifact
- share/rocjitsu/** to the run artifact
- include/rocjitsu/** to the dev artifact

JIRA ID : AIHPBLAS-3605
https://amd-hub.atlassian.net/browse/AIHPBLAS-3605

therock-pr-bot · 2026-07-13T18:32:58Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-07-13T18:33:00Z

🎉 All checks passed! This PR is ready for review.

geomin12

lgtm! errors are flaky infra issues, can retry

amd-arosa

don't ship the rocjitsu cli.
we should ship the hook if it's ready.
please confirm the hook doesn't containe all rocjitsu symbols.
also add it to the symbol check in the cmake

amd-arosa · 2026-07-20T21:50:33Z

 [components.dev."emulation/rocjitsu/stage"]
 [components.run."emulation/rocjitsu/stage"]
 include = [
+  "bin/rocjitsu",


we already ship mirage. mirage is built to be the public rocjitsu cli.

also just alias rocjitsu="mirage run"

I have an end-to-end CI workflow (race detection in rocm-libraries) working in this PR: ROCm/rocm-libraries#9363 that uses rocjitsu cli. That PR builds rocjitsu in the CI job though, which I'd prefer to avoid. That is why I wanted to ship rocjitsu (i.e. this PR) -- then I wouldn't need to build rocjitsu in CI.

I have tried getting the same end-to-end working with Mirage (instead of rocjitsu cli) in this PR: ROCm/rocm-libraries#9613 but it looks like I need to install cargo. In https://github.com/ROCm/rocm-libraries/actions/runs/29791059379/job/88513099846 : Could not find MIRAGE_CARGO_FOUND using the following names: cargo in.

Using cargo is not a blocker, but it adds a new dimension of complexity. I want this to be as easy as possible for developers to reproduce. The 'best' for rocm-libraries developers would've been just to install rocjitsu.

Anyway I will push try cargo (i.e. I'll keep iterating on ROCm/rocm-libraries#9613), see if I can get that over the line.

just updated https://ghcr.io/rocm/therock_build_manylinux_x86_64

## Motivation Adds minimal rocjitsu race detection for GEMMs on gfx1151, gfx950, and gfx942/gfx94X, run through `hipblaslt-bench` and `tensilelite-client`. This is the third step in the evolution of race detection for hipBLASLt: 1. #7951 did not use TheRock. It used a free GitHub runner, checked out rocm-libraries and rocm-systems, built them, and ran rocjitsu with hipBLASLt. 2. #8929 used TheRock, but only ran `hipblaslt-bench` on gfx950. 3. This PR uses TheRock, adds gfx1151 and gfx942/gfx94X coverage, adds a reduced `tensilelite-client` path, and runs rocjitsu on a CPU build runner instead of consuming a GPU test runner. JIRA ID : AIHPBLAS-3605 https://amd-hub.atlassian.net/browse/AIHPBLAS-3605 ## High Level Overview For hipBLASLt TheRock Linux rows on supported GPU families, this adds a post-build rocjitsu race-check job. The flow is: 1. The normal TheRock build produces the ROCm runtime, hipBLASLt, and TensileLite test artifacts. 2. The race-check job fetches those artifacts from the same TheRock run. 3. The job builds rocjitsu from a pinned rocm-systems revision. 4. The job runs small `hipblaslt-bench` and `tensilelite-client` workloads under rocjitsu race detection. 5. The script reports a failure if a workload fails or rocjitsu reports a race. The check is initially advisory. Failures remain visible in the job logs and uploaded reports, but do not fail the required TheRock CI summary while the job's reliability is evaluated. The goal is to test GPU-targeted hipBLASLt and TensileLite artifacts under CPU-side emulation without requiring GPU runner capacity. ### Workspace Layout The job uses three repository checkouts in one workspace: - `ROCm/TheRock` is checked out at the workspace root. Its actions and scripts fetch the artifacts produced by the current TheRock run. - The current `ROCm/rocm-libraries` revision is checked out under `rocm-libraries/`. A sparse checkout provides the race-check driver script from `.github/scripts`. - `ROCm/rocm-systems` is checked out under `rocm-systems/` at a pinned revision. A sparse checkout provides the rocjitsu sources and machine-readable ISA data needed to build rocjitsu. These checkouts provide the workflow logic and test tooling. The ROCm runtime, compiler, hipBLASLt, TensileLite, and test payload being exercised still come from the artifacts produced by the associated TheRock build. ## End-to-end CI Proof A recent CI run has successful rocjitsu race-check jobs for all three target rows: - gfx1151: https://github.com/ROCm/rocm-libraries/actions/runs/29942116838/job/89005639878 - gfx950-dcgpu: https://github.com/ROCm/rocm-libraries/actions/runs/29942116838/job/89010903066 - gfx94X-dcgpu: https://github.com/ROCm/rocm-libraries/actions/runs/29942116838/job/89015610352 ## Current Limitations - rocjitsu is still built from a pinned rocm-systems source checkout. This should move to a packaged TheRock component artifact. - The check is initially advisory while its reliability is evaluated. - The TensileLite YAMLs are embedded in the script. They should move to checked-in test data or be replaced by existing product-owned workloads. ## Next Steps And Ongoing Work - Evaluate the job's reliability and decide when it should become blocking. - Move rocjitsu consumption to a complete TheRock runnable artifact. - Move the inline TensileLite YAMLs into checked-in test data or reuse existing workloads. - Continue the TheRock-side work toward a cleaner component path: - ROCm/TheRock#6517 makes rocjitsu available as a runnable artifact. - ROCm/TheRock#6525 adds a component-level rocjitsu smoke test. - ROCm/TheRock#6575 separates artifact selection from runner placement so GPU-targeted artifacts can be tested on CPU runners.

…ponents intended for etsting

This reverts commit 239f4dc.

Groverkss · 2026-08-14T14:37:21Z

 default_patterns = false
 include = [
  "lib/librocjitsu.so",
+  "lib/librocjitsu_hooks.so",


Why are we shipping these hooks? Who is the consumer of these?

github-project-automation Bot added this to TheRock Triage Jul 13, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jul 13, 2026

newling mentioned this pull request Jul 13, 2026

fix(emulation): package runnable rocjitsu payload #6516

Closed

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 13, 2026

therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 13, 2026

newling requested review from amd-arosa, amd-eochoalo and geomin12 July 13, 2026 19:29

amd-eochoalo approved these changes Jul 13, 2026

View reviewed changes

newling marked this pull request as ready for review July 13, 2026 20:10

newling mentioned this pull request Jul 13, 2026

test(rocjitsu): add CPU artifact smoke component #6525

Closed

geomin12 approved these changes Jul 14, 2026

View reviewed changes

newling mentioned this pull request Jul 14, 2026

test(ci): allow external manifest diff URLs #6541

Closed

newling force-pushed the rocjitsu-runnable-artifact branch from 83e81a8 to 83f3c62 Compare July 15, 2026 17:20

newling mentioned this pull request Jul 16, 2026

ci(hipblaslt): rocjitsu race checks for gfx942/gfx950/gfx1151 ROCm/rocm-libraries#9363

Merged

amd-arosa requested changes Jul 20, 2026

View reviewed changes

amd-arosa reviewed Jul 21, 2026

View reviewed changes

Comment thread emulation/artifact-rocjitsu.toml Resolved

newling force-pushed the rocjitsu-runnable-artifact branch from d20e1cd to a5ac276 Compare July 21, 2026 21:04

newling commented Jul 21, 2026

View reviewed changes

Comment thread emulation/artifact-rocjitsu.toml Resolved

amd-arosa approved these changes Jul 27, 2026

View reviewed changes

newling force-pushed the rocjitsu-runnable-artifact branch from c43bd3e to 78c82af Compare July 27, 2026 17:31

newling changed the title ~~fix(emulation): package runnable rocjitsu payload~~ fix(emulation): package rocjitsu hooks and CLI test payload Jul 27, 2026

newling and others added 4 commits August 10, 2026 10:39

fix(emulation): package runnable rocjitsu payload

5d48636

fix(emulation): package installed rocjitsu libraries

a18158d

fix: validate_shared_lib librocjitsu_hooks.so

6e6b379

ship all rocjitsu libs

a8f6fce

amd-arosa and others added 3 commits August 10, 2026 10:39

hold off on shiping rocjitsu cli

03c0a69

add test component. This seems to be the canonical way to package com…

37d5c74

…ponents intended for etsting

be explicit about which libs to ship

4ad57e7

This reverts commit 239f4dc.

newling force-pushed the rocjitsu-runnable-artifact branch from 78c82af to 4ad57e7 Compare August 10, 2026 17:39

Groverkss reviewed Aug 14, 2026

View reviewed changes

newling closed this Sep 2, 2026

github-project-automation Bot moved this from TODO to Done in TheRock Triage Sep 2, 2026

Navigation Menu

Repository navigation

fix(emulation): package rocjitsu hooks and CLI test payload - #6517

fix(emulation): package rocjitsu hooks and CLI test payload#6517
newling wants to merge 7 commits into
ROCm:mainfrom
newling:rocjitsu-runnable-artifact

newling commented Jul 13, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

geomin12 left a comment

Uh oh!

amd-arosa left a comment

Uh oh!

amd-arosa Jul 20, 2026 •

edited

Loading

Uh oh!

newling Jul 21, 2026

Uh oh!

amd-arosa Jul 21, 2026

Uh oh!

Uh oh!

Uh oh!

Groverkss Aug 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

newling commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Summary

Local validation

Uh oh!

therock-pr-bot Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

amd-arosa left a comment

Choose a reason for hiding this comment

Uh oh!

amd-arosa Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

newling Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

amd-arosa Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Groverkss Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

newling commented Jul 13, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 13, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 13, 2026 •

edited

Loading

amd-arosa Jul 20, 2026 •

edited

Loading