Skip to content

fix(emulation): package rocjitsu hooks and CLI test payload #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
newling wants to merge 7 commits into from
Closed

fix(emulation): package rocjitsu hooks and CLI test payload #6517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d48636
fix(emulation): package runnable rocjitsu payload
newling Jul 13, 2026
a18158d
fix(emulation): package installed rocjitsu libraries
newling Jul 14, 2026
6e6b379
fix: validate_shared_lib librocjitsu_hooks.so
amd-arosa Jul 21, 2026
a8f6fce
ship all rocjitsu libs
amd-arosa Jul 21, 2026
03c0a69
hold off on shiping rocjitsu cli
amd-arosa Jul 21, 2026
37d5c74
add test component. This seems to be the canonical way to package com…
newling Jul 21, 2026
4ad57e7
be explicit about which libs to ship
amd-arosa Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions emulation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ if(THEROCK_ENABLE_ROCJITSU)
therock_test_validate_shared_lib(PATH rocjitsu/dist/lib
LIB_NAMES
librocjitsu.so
librocjitsu_hooks.so
)
therock_test_validate_shared_lib(PATH rocjitsu/dist/lib
LIB_NAMES
Expand All @@ -53,6 +54,7 @@ if(THEROCK_ENABLE_ROCJITSU)
dev
lib
run
test
SUBPROJECT_DEPS
rocjitsu
)
Expand Down
5 changes: 5 additions & 0 deletions emulation/artifact-rocjitsu.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
default_patterns = false
include = [
"lib/librocjitsu.so",
"lib/librocjitsu_hooks.so",

@Groverkss Groverkss Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we shipping these hooks? Who is the consumer of these?

]
[components.dbg."emulation/rocjitsu/stage"]
[components.dev."emulation/rocjitsu/stage"]
[components.run."emulation/rocjitsu/stage"]
include = [
"share/rocjitsu/**",
]
[components.test."emulation/rocjitsu/stage"]
Comment thread
amd-arosa marked this conversation as resolved.
Resolved
include = [
"bin/rocjitsu",
]
Loading