Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
newling
force-pushed
the
fix-manifest-diff-external-bucket-test
branch
from
July 15, 2026 17:20
84c7eba to
e5edda9
Compare
therock-pr-bot
Bot
removed
the
Not ready to Review
newling
force-pushed
the
fix-manifest-diff-external-bucket-test
branch
from
July 17, 2026 17:52
e5edda9 to
b1997d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The multi-arch CI summary unit test currently fails in PR contexts that use the external artifact bucket. The summary code correctly emits a manifest-diff URL under
therock-ci-artifacts-external/..., but the test hard-codes the internaltherock-ci-artifactsbucket.This is blocking the unit-test checks on #6517 and #6525.
Summary
Validation
pre-commit run --files build_tools/github_actions/tests/configure_multi_arch_ci_test.pyPYTHONPATH=build_tools:build_tools/github_actions:build_tools/github_actions/tests .venv/bin/python -m unittest build_tools.github_actions.tests.configure_multi_arch_ci_test.TestFormatSummary.test_build_outputs_includes_manifest_diff_linkTestFormatSummary.test_build_outputs_includes_manifest_diff_linkPYTHONPATH=build_tools:build_tools/github_actions:build_tools/github_actions/tests .venv/bin/python -m unittest build_tools.github_actions.tests.configure_multi_arch_ci_testgit diff --checkRelated: #6517
Related: #6525
which are ultimately related to
JIRA ID : AIHPBLAS-3605
https://amd-hub.atlassian.net/browse/AIHPBLAS-3605