Skip to content

Expand on and fix write_torch_version.py script.#1133

Merged
ScottTodd merged 3 commits into
mainfrom
users/scotttodd/write-torch-versions
Jul 26, 2025
Merged

Expand on and fix write_torch_version.py script.#1133
ScottTodd merged 3 commits into
mainfrom
users/scotttodd/write-torch-versions

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd commented Jul 26, 2025

The ${{ env.PACKAGE_DIST_DIR }} value was not making its way to the script correctly (see logs 1, logs 2). We would look in /__w/TheRock/TheRock/output/packages/dist while the files were in /home/runner/_work/TheRock/TheRock/output/packages/dist.

This also includes other changes discussed on #1110 (comment).

Tested:

  • Linux: https://github.com/ROCm/TheRock/actions/runs/16542818823.

    2025-07-26T19:11:37.0162660Z Looking for wheels in '/home/runner/_work/TheRock/TheRock/output/packages/dist'
    2025-07-26T19:11:37.0163431Z Found files in that directory:
    2025-07-26T19:11:37.0164351Z   /home/runner/_work/TheRock/TheRock/output/packages/dist/torchaudio-2.7.1a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl
    2025-07-26T19:11:37.0165576Z   /home/runner/_work/TheRock/TheRock/output/packages/dist/pytorch_triton_rocm-3.3.1-cp312-cp312-linux_x86_64.whl
    2025-07-26T19:11:37.0166748Z   /home/runner/_work/TheRock/TheRock/output/packages/dist/torch-2.7.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl
    2025-07-26T19:11:37.0167850Z   /home/runner/_work/TheRock/TheRock/output/packages/dist/torchvision-0.22.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl
    2025-07-26T19:11:37.0168436Z 
    2025-07-26T19:11:37.0168632Z Looking for 'torch in '/home/runner/_work/TheRock/TheRock/output/packages/dist'
    2025-07-26T19:11:37.0169204Z   Found wheel at 'torch-2.7.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl'
    2025-07-26T19:11:37.0169772Z   Parsed version '2.7.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'
    2025-07-26T19:11:37.0170235Z Looking for 'torchaudio in '/home/runner/_work/TheRock/TheRock/output/packages/dist'
    2025-07-26T19:11:37.0170861Z   Found wheel at 'torchaudio-2.7.1a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl'
    2025-07-26T19:11:37.0171469Z   Parsed version '2.7.1a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'
    2025-07-26T19:11:37.0171936Z Looking for 'torchvision in '/home/runner/_work/TheRock/TheRock/output/packages/dist'
    2025-07-26T19:11:37.0172641Z   Found wheel at 'torchvision-0.22.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-linux_x86_64.whl'
    2025-07-26T19:11:37.0173242Z   Parsed version '0.22.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'
    2025-07-26T19:11:37.0173740Z Looking for 'pytorch_triton_rocm in '/home/runner/_work/TheRock/TheRock/output/packages/dist'
    2025-07-26T19:11:37.0174222Z   Found wheel at 'pytorch_triton_rocm-3.3.1-cp312-cp312-linux_x86_64.whl'
    2025-07-26T19:11:37.0174539Z   Parsed version '3.3.1'
    2025-07-26T19:11:37.0174675Z 
    2025-07-26T19:11:37.0174679Z 
    2025-07-26T19:11:37.0174762Z Setting github output:
    2025-07-26T19:11:37.0175683Z {'torch_version': '2.7.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9', 'torchaudio_version': '2.7.1a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9', 'torchvision_version': '0.22.1+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9', 'triton_version': '3.3.1'}
    

    Note: tests failed with ERROR: Could not find a version that satisfies the requirement pytorch-triton-rocm==3.3.1 (from torch) (from versions: none). I think the wheels are in the bucket but the index needs to be populated? We also need to plumb through the new versions, as discussed on Add gating mechanism to ensure PyTorch wheels pass tests before releasing #1110.

  • Windows: https://github.com/ROCm/TheRock/actions/runs/16543042986

    Looking for wheels in 'C:\home\runner\_work\TheRock\TheRock\output\packages\dist'
    Found files in that directory:
      C:\home\runner\_work\TheRock\TheRock\output\packages\dist\torch-2.9.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-win_amd64.whl
      C:\home\runner\_work\TheRock\TheRock\output\packages\dist\torchaudio-2.8.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-win_amd64.whl
    Looking for 'torch in 'C:\home\runner\_work\TheRock\TheRock\output\packages\dist'
      Found wheel at 'torch-2.9.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-win_amd64.whl'
      Parsed version '2.9.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'
    Looking for 'torchaudio in 'C:\home\runner\_work\TheRock\TheRock\output\packages\dist'
      Found wheel at 'torchaudio-2.8.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9-cp312-cp312-win_amd64.whl'
      Parsed version '2.8.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'
    Looking for 'torchvision in 'C:\home\runner\_work\TheRock\TheRock\output\packages\dist'
      WARNING: Found no 'torchvision' wheels matching 'torchvision-*.whl'
    Looking for 'pytorch_triton_rocm in 'C:\home\runner\_work\TheRock\TheRock\output\packages\dist'
      WARNING: Found no 'pytorch_triton_rocm' wheels matching 'pytorch_triton_rocm-*.whl'
    Did not find torchvision (that's okay, is not currently built on Windows)
    Did not find triton (that's okay, is not currently built on Windows)
    Setting github output:
    {'torch_version': '2.9.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9', 'torchaudio_version': '2.8.0a0+rocm7.0.0.dev0.9b07c81904cf711789f5c8c43919135d018f75a9'}
    

Copy link
Copy Markdown
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of landing. Given that the build is broken and we can't get better automation or testing online in that state, I'm not inclined to nit pick this iteration.

@ScottTodd ScottTodd marked this pull request as ready for review July 26, 2025 20:06
@ScottTodd
Copy link
Copy Markdown
Member Author

Test run on Windows completed too, added logs to the PR description.

I'm in favor of landing. Given that the build is broken and we can't get better automation or testing online in that state, I'm not inclined to nit pick this iteration.

Thanks, agreed. Will take a fresh look at this stuff together with others next week. Close to green now.

@ScottTodd ScottTodd merged commit c6d9806 into main Jul 26, 2025
13 of 14 checks passed
@ScottTodd ScottTodd deleted the users/scotttodd/write-torch-versions branch July 26, 2025 20:08
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants