Expand on and fix write_torch_version.py script.#1133
Merged
Conversation
This was referenced Jul 26, 2025
stellaraccident
approved these changes
Jul 26, 2025
Collaborator
stellaraccident
left a comment
There was a problem hiding this comment.
I'm in favor of landing. Given that the build is broken and we can't get better automation or testing online in that state, I'm not inclined to nit pick this iteration.
Member
Author
|
Test run on Windows completed too, added logs to the PR description.
Thanks, agreed. Will take a fresh look at this stuff together with others next week. Close to green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
${{ env.PACKAGE_DIST_DIR }}value was not making its way to the script correctly (see logs 1, logs 2). We would look in/__w/TheRock/TheRock/output/packages/distwhile the files were in/home/runner/_work/TheRock/TheRock/output/packages/dist.This also includes other changes discussed on #1110 (comment).
Tested:
Linux: https://github.com/ROCm/TheRock/actions/runs/16542818823.
Note: tests failed with
ERROR: Could not find a version that satisfies the requirement pytorch-triton-rocm==3.3.1 (from torch) (from versions: none). I think the wheels are in the bucket but the index needs to be populated? We also need to plumb through the new versions, as discussed on Add gating mechanism to ensure PyTorch wheels pass tests before releasing #1110.Windows: https://github.com/ROCm/TheRock/actions/runs/16543042986