Pylint tools#6609
Merged
Merged
Conversation
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jun 21, 2021
This commit fixes several pylint issues identified in the tools/subunit_to_junit script. This script is only used in CI to adapt the subunit v2 output we get from stestr to the junitxml format expected by azure pipelines for feeding the analytics. Most of the issues were over lack of internal documentation for the internal functions. As we're looking at running pylint on the tools dir in Qiskit#6609 this commit makes the necessary changes for pylint to pass.
Member
|
I pushed up a pylint fix for the subunit to junit script here: #6614 |
mergify Bot
added a commit
that referenced
this pull request
Jun 21, 2021
This commit fixes several pylint issues identified in the tools/subunit_to_junit script. This script is only used in CI to adapt the subunit v2 output we get from stestr to the junitxml format expected by azure pipelines for feeding the analytics. Most of the issues were over lack of internal documentation for the internal functions. As we're looking at running pylint on the tools dir in #6609 this commit makes the necessary changes for pylint to pass. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mtreinish
previously approved these changes
Jun 21, 2021
mtreinish
added
automerge
Changelog: None
mtreinish
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with #6606 and #6607 this is a partial solution to #6608
The remaining file with lint issues issubunit_to_junit.pywhich I don't understand well enough to fix it.After fixing
subunit_to_junit.pywe can additionally add the tools directory to the pylint invocation lines, and CI.Fixes #6608