Pylint tools

Makefile

@@ -45,7 +45,7 @@ env:
 
 # Ignoring generated ones with .py extension.
 lint:
-	pylint -rn qiskit test
+	pylint -rn qiskit test tools
 	tools/verify_headers.py qiskit test tools examples
 	pylint -rn --disable='C0103, C0114, W0621' examples/python/*.py
 	tools/find_optional_imports.py

azure-pipelines.yml

@@ -273,7 +273,7 @@ stages:
             set -e
             source test-job/bin/activate
             black --check qiskit test tools examples setup.py
-            pylint -rn qiskit test
+            pylint -rn qiskit test tools
             tools/verify_headers.py qiskit test
             python tools/find_optional_imports.py
             reno lint

tools/report_ci_failure.py

@@ -47,7 +47,7 @@ def report(self, branch, commit, infourl=None, job_name=None):
             job_name (str): name of the failed ci job.
         """
         if branch != "main" and not self.stable_branch_regex.search(branch):
-            return None
+            return
         key_label = self._key_label(branch, job_name)
         issue_number = self._get_report_issue_number(key_label)
         if issue_number:

tools/update_fake_backends.py

@@ -12,6 +12,7 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
+"""Utility script to update fake backends"""
 
 import argparse
 from datetime import datetime
@@ -48,7 +49,7 @@ def default(self, o):
 )
 
 
-def main():
+def _main():
     parser = argparse.ArgumentParser(description="Generate fake backend snapshots")
     parser.add_argument("--dir", "-d", type=str, default=DEFAULT_DIR)
     parser.add_argument("backends", type=str, nargs="*")
@@ -93,5 +94,5 @@ def main():
                     fd.write(json.dumps(defs.to_dict(), cls=BackendEncoder))
 
 
-if __name__ == main():
-    main()
+if __name__ == "__main__":
+    _main()

tox.ini

@@ -23,7 +23,7 @@ envdir = .tox/lint
 basepython = python3
 commands =
   black --check {posargs} qiskit test tools examples setup.py
-  pylint -rn qiskit test
+  pylint -rn qiskit test tools
   {toxinidir}/tools/verify_headers.py qiskit test tools examples
   {toxinidir}/tools/find_optional_imports.py
   reno lint