Skip to content

Fix lint in subunit to junit tools script#6614

Merged
mergify[bot] merged 2 commits into
Qiskit:mainfrom
mtreinish:fix-lint-junitxml
Jun 21, 2021
Merged

Fix lint in subunit to junit tools script#6614
mergify[bot] merged 2 commits into
Qiskit:mainfrom
mtreinish:fix-lint-junitxml

Conversation

@mtreinish
Copy link
Copy Markdown
Member

Summary

This commit fixes several pylint issues identified in the
tools/subunit_to_junit script. This script is only used in CI to adapt
the subunit v2 output we get from stestr to the junitxml format expected
by azure pipelines for feeding the analytics. Most of the issues were
over lack of internal documentation for the internal functions. As we're
looking at running pylint on the tools dir in #6609 this commit makes the
necessary changes for pylint to pass.

Details and comments

This commit fixes several pylint issues identified in the
tools/subunit_to_junit script. This script is only used in CI to adapt
the subunit v2 output we get from stestr to the junitxml format expected
by azure pipelines for feeding the analytics. Most of the issues were
over lack of internal documentation for the internal functions. As we're
looking at running pylint on the tools dir in Qiskit#6609 this commit makes the
necessary changes for pylint to pass.
@mtreinish mtreinish requested a review from a team as a code owner June 21, 2021 12:01
@mtreinish mtreinish mentioned this pull request Jun 21, 2021
@levbishop levbishop added type: qa Issues and PRs that relate to testing and code quality automerge labels Jun 21, 2021
@mtreinish mtreinish added the Changelog: None Do not include in the GitHub Release changelog. label Jun 21, 2021
@levbishop
Copy link
Copy Markdown
Member

Partial solution to #6608

@mergify mergify Bot merged commit 50c30f5 into Qiskit:main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. type: qa Issues and PRs that relate to testing and code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants