Fix find_optional_imports.py#6606
Merged
Merged
Conversation
levbishop
added
the
type: qa
Member
Author
|
This PR is part of the solution to #6608 |
Merged
mtreinish
added
automerge
Changelog: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5798
find_optional_imports.pyhad the superficially-superfluousimport qiskitline removed. Unfortunately this stopped the script from doing its job to check if qiskit made use of the optional imports.This PR adds this back, with a comment explaining why not to drop it, and makes a couple other minor tweaks to the file.