Closed
Conversation
* Added .circleci/config.yml
* Added .circleci/config.yml
Implements the issuer keys as
IssuerAuthorizingKey -> isk
IssuerVerifyingKey -> ik
Test vectors generated with zcash_test_vectors repo
* Added NoteType to Notes * Added NoteType to value commitment derivation
* Added .circleci/config.yml
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
| // Commit to non-ZEC notes as per the ZSA protocol. | ||
| // Append the note type to the Orchard note encoding. | ||
| let type_bits = BitArray::<_, Lsb0>::new(note_type.to_bytes()); | ||
| let zsa_note_bits = zec_note_bits.chain(type_bits.iter().by_vals()); |
Contributor
There was a problem hiding this comment.
If we decide to extend values for ZSAs to 128 bits, this is where the extra high-order bits will be committed.
daira
reviewed
Sep 10, 2022
| rcm: NoteCommitTrapdoor, | ||
| ) -> CtOption<Self> { | ||
| let domain = sinsemilla::CommitDomain::new(personalization); | ||
| domain.commit(bits, &rcm.0).map(NoteCommitment) |
Contributor
There was a problem hiding this comment.
If we want this to be constant-time, it will need to also take the maximum number of bits so that it can always do that much computation.
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
daira
reviewed
Sep 10, 2022
+ Updated test bsk_consistent_with_bvk to verify mixed note types. + Added NoteType support to the builder and the bundle. + added split_flag to SpentInfo and as input to the Circuit (currently commented out) + added conditional cv_sum calculation (currently commented out) + added padding to actions
Unit and property tests for issue bundle Commitments for issuance
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Oct 26, 2022
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Oct 26, 2022
* fixes and suggestions * changed "issuer" to "issuance" as per zcash#356 (comment) * terminology fixes * updated naming
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Oct 27, 2022
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Oct 27, 2022
* rename 2 note_type -> asset as per zcash#356 (comment) * added a dedicated type for "IssuanceAuth" * disabled codecov github action due to bad behavior. * extracted "is_asset_desc_of_valid_size()" into asset_id.rs
Author
vivek-arte
pushed a commit
to QED-it/orchard
that referenced
this pull request
Nov 24, 2022
* fixes and suggestions * changed "issuer" to "issuance" as per zcash#356 (comment) * terminology fixes * updated naming
vivek-arte
pushed a commit
to QED-it/orchard
that referenced
this pull request
Nov 24, 2022
* rename 2 note_type -> asset as per zcash#356 (comment) * added a dedicated type for "IssuanceAuth" * disabled codecov github action due to bad behavior. * extracted "is_asset_desc_of_valid_size()" into asset_id.rs
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Dec 6, 2022
* fixes and suggestions * changed "issuer" to "issuance" as per zcash#356 (comment) * terminology fixes * updated naming
PaulLaux
added a commit
to QED-it/orchard
that referenced
this pull request
Dec 6, 2022
* rename 2 note_type -> asset as per zcash#356 (comment) * added a dedicated type for "IssuanceAuth" * disabled codecov github action due to bad behavior. * extracted "is_asset_desc_of_valid_size()" into asset_id.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZSA wip, changes can be tracked via https://github.com/QED-it/orchard/tree/zsa1