Add W504 for line breaks before binary operators by sigmavirus24 · Pull Request #502 · PyCQA/pycodestyle

sigmavirus24 · 2016-04-30T12:55:13Z

This flips the W503 rule to enforce line breaks before binary operators.

Related #498

TODO:

Add W504 to list of codes
Add W504 to default ignore
Fix tests

sigmavirus24 · 2016-05-17T15:38:16Z

@IanLee1521 I know the tests are failing, and I'm going to have to figure out how to fix them, but I'd love some code review.

IanLee1521 · 2016-05-20T19:05:49Z

pep8.py


-def break_around_binary_operator(logical_line, tokens):
+def _is_binary_operator(token_type, text):
+    # The % character is strictly speaking a binary operator, but the


Minor, but I'd prefer to move this to a """...""" style doc string rather than # since we're touching it anyways.

IanLee1521 · 2016-05-20T19:13:05Z

@sigmavirus24 -- Made a few in line comments, nothing major, overall looks good to me 👍 if we fix the tests I have no issues merging.

IanLee1521 · 2016-06-26T04:24:41Z

@sigmavirus24 -- I've been working most of the day on fixing the tests and getting some other things merged. I captured the branch at: https://github.com/PyCQA/pycodestyle/tree/gh-502

I'm on the last failure (https://travis-ci.org/PyCQA/pycodestyle/builds/140304242) still chipping away if you have any thoughts...

hoylemd · 2016-07-18T14:54:55Z

Are there any updates on this? My team would very much like to use it. If development has stalled, could we grab the branch and polish it off?

sigmavirus24 · 2016-07-18T14:59:37Z

@hoylemd, thanks for the interest! @IanLee1521 has updated this a bit on https://github.com/PyCQA/pycodestyle/tree/gh-502 but there are still failing tests. If you can fix those, you're welcome to take over this work and submit a new PR!

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

Ideally I'd like to have a check for this, but pycodestyle doesn't have one yet. See also PyCQA/pycodestyle#502.

peterjc · 2018-01-11T11:21:00Z

It looks like flake8 assumed this was going to be merged and already ignores it by default?
https://gitlab.com/pycqa/flake8/issues/397

FichteFoll · 2018-01-11T16:52:42Z

The only thing holding this back are failing tests, right?

Cross reference changes in pull request PyCQA#502 which added this.

peterjc · 2018-01-23T10:38:56Z

Pull request #724 submitted to update the list of error codes.

Note that the new recommended way is to use line break before binary operators. Follow the discussion here: PyCQA/pycodestyle#502

Also fixes pep8 error: W605 (invalid escape sequence '\.') and disables pep8 error W504 from pycodestyle tests. Solves: #10 References: PyCQA/pycodestyle#502

Also fixes pep8 error: W605 (invalid escape sequence '\.') and disables pep8 error W504 from pycodestyle tests. Right now all the pycodestyle tests should be passed and only the pylint tests should cause the travis tests to fail. Resolves: #10 References: PyCQA/pycodestyle#502

Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297

…e W504 (#636) * format_map is python 3.2 or later only (see also #602) * Ignore new pycodestyle rule W504 Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297

…e W504 (ros-infrastructure#636) * format_map is python 3.2 or later only (see also ros-infrastructure#602) * Ignore new pycodestyle rule W504 Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297

See also: PyCQA/pycodestyle/pull/502

* W503 is in conflict with the more modern W504 See PyCQA/pycodestyle#502 Change-Id: I1f29b362e0f0c6893a81c5cd12a862890e8d8609

We use quite old pep8 v1.6.2 which in particular misses this change PyCQA/pycodestyle#502 Let's update Dockerfile to use pycodestyle(former pep8) from bullseye. Change-Id: Id29acd80be212cffa127550d9a4deb764a5b5b30

We use quite old pep8 v1.6.2 which in particular misses this change PyCQA/pycodestyle#502 Let's update Dockerfile to use pycodestyle(former pep8) from bullseye. Change-Id: Id29acd80be212cffa127550d9a4deb764a5b5b30 (cherry picked from commit d552f2c0c2bbb8c802aa29ac9c23ed4c12d5a1cc) (cherry picked from commit ae28060)

We use quite old pep8 v1.6.2 which in particular misses this change PyCQA/pycodestyle#502 Let's update Dockerfile to use pycodestyle(former pep8) from bullseye. Change-Id: Id29acd80be212cffa127550d9a4deb764a5b5b30 (cherry picked from commit d552f2c0c2bbb8c802aa29ac9c23ed4c12d5a1cc)

IanLee1521 reviewed May 20, 2016
View reviewed changes

IanLee1521 added the wip label May 21, 2016

sigmavirus24 force-pushed the add-W504 branch from 83dd7ea to 4db5041 Compare May 21, 2016 18:02

sigmavirus24 modified the milestone: 2.1 Jun 4, 2016

FichteFoll mentioned this pull request Jun 24, 2016

W503: % is not considered to be a binary operator for line breaks #422

Open

IanLee1521 added a commit that referenced this pull request Jun 26, 2016

Updated testsuite cases for #502

619c94f

IanLee1521 added a commit that referenced this pull request Jun 26, 2016

Updated testsuite cases for #502

915e08a

IanLee1521 modified the milestones: 2.2, 2.1 Jun 26, 2016

hackaugusto mentioned this pull request Oct 31, 2016

Fixed all flake8 errors and added flake8 in the build script raiden-network/raiden#169

Merged

hackaugusto added a commit to hackaugusto/raiden that referenced this pull request Nov 2, 2016

failling build fix

579ee0b

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

hackaugusto added a commit to hackaugusto/raiden that referenced this pull request Nov 3, 2016

failling build fix

631755a

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

hackaugusto added a commit to hackaugusto/raiden that referenced this pull request Nov 3, 2016

failling build fix

8e2eb08

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

schmir pushed a commit to raiden-network/raiden that referenced this pull request Nov 6, 2016

failling build fix

6bd6747

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

schmir pushed a commit to raiden-network/raiden that referenced this pull request Nov 6, 2016

failling build fix

3fbb0e5

- removed pep8 from the travis.yml until PyCQA/pycodestyle#502 is merged. - fixed one additional style issue

gilch mentioned this pull request Nov 26, 2016

Ignore a new Flake8 whitespace error hylang/hy#1158

Merged

FichteFoll mentioned this pull request Jun 1, 2017

Fix some flake8 coding style issues packagecontrol/st_package_reviewer#10

Closed

FichteFoll added a commit to packagecontrol/st_package_reviewer that referenced this pull request Jun 1, 2017

Prefer line breaks *before* binary operators

2947de1

Ideally I'd like to have a check for this, but pycodestyle doesn't have one yet. See also PyCQA/pycodestyle#502.

AWhetter mentioned this pull request Aug 22, 2017

Support for W505 - doc line length #674

Merged

peterjc mentioned this pull request Jan 10, 2018

Update of CodonTable biopython/biopython#1501

Merged

peterjc added a commit to peterjc/pycodestyle that referenced this pull request Jan 23, 2018

Describe code W504 line break after binary operator

80684c4

Cross reference changes in pull request PyCQA#502 which added this.

peterjc mentioned this pull request Jan 23, 2018

Describe code W504 line break after binary operator #724

Merged

sigmavirus24 mentioned this pull request Feb 17, 2018

Update handling of breaking around binary operators: W503 vs W504 #498

Closed

tristanbrown mentioned this pull request Apr 12, 2018

Fix get_bam and get_primary_bam functions genialis/resdk#150

Closed

JureZmrzlikar pushed a commit to JureZmrzlikar/resolwe-bio-py that referenced this pull request Apr 13, 2018

Fix linter errors

2d6d4d5

Note that the new recommended way is to use line break before binary operators. Follow the discussion here: PyCQA/pycodestyle#502

LefterisJP mentioned this pull request Apr 24, 2018

Style guide fix for W503 W504 raiden-network/raiden#1382

Merged

micha030201 mentioned this pull request May 15, 2018

Make flake8 run over everything flaskbb/flaskbb#468

Merged

opacam pushed a commit to opacam/Cohen3 that referenced this pull request Sep 5, 2018

Fix travis pycodestyle's test

0af364e

Also fixes pep8 error: W605 (invalid escape sequence '\.') and disables pep8 error W504 from pycodestyle tests. Solves: #10 References: PyCQA/pycodestyle#502

peterjc mentioned this pull request Oct 25, 2018

Adding new entries for the Biopython 1.73 release news biopython/biopython#1832

Merged

3 tasks

NikolausDemmel added a commit to NikolausDemmel/rosdep that referenced this pull request Oct 27, 2018

Ignore new pycodestyle rule W504

2358896

Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297

NikolausDemmel mentioned this pull request Oct 27, 2018

fix travis: format_map is python 3.2 or later only and ignore new rule W504 ros-infrastructure/rosdep#636

Merged

damb pushed a commit to EIDA/mediatorws that referenced this pull request Nov 21, 2018

Ignore W504

fb64e9a

See also: PyCQA/pycodestyle/pull/502

muffgaga pushed a commit to electronicvisions/code-format that referenced this pull request Jun 18, 2019

Adapt pycodestyle to new pep8 version

df7844c

* W503 is in conflict with the more modern W504 See PyCQA/pycodestyle#502 Change-Id: I1f29b362e0f0c6893a81c5cd12a862890e8d8609

mbakar01 added a commit to mbakar01/pycodestyle that referenced this pull request Mar 15, 2020

Merge branch PyCQAgh-502 into issue358

b96fd9d

espears1 mentioned this pull request Oct 9, 2020

W504 and W503 are in conflict with each other and activated at the same time #964

Closed

This was referenced Apr 3, 2021

W503 shouldn't exist PyCQA/flake8#494

Closed

Not-yet-defined W504 in the default ignore list [REPLACEMENT ISSUE] PyCQA/flake8#637

Closed

Not-yet-defined W504 in the default ignore list PyCQA/flake8#1078

Closed

mkniewallner mentioned this pull request May 22, 2022

Bump flake8 additional dependencies python-poetry/poetry-core#362

Merged

2 tasks

hoodmane mentioned this pull request Aug 26, 2022

dynCallLegacy: Fill in dynCall_sig with a Wasm adaptor if it is missing emscripten-core/emscripten#17328

Merged

Julian-O mentioned this pull request Jul 21, 2023

Ignore Flake8's W503 kivy/buildozer#1638

Closed

sstendahl mentioned this pull request Sep 1, 2023

Use a linter in workflow to enforce PEP8 compliance jfkcooper/HOGBEN#72

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add W504 for line breaks before binary operators#502

Add W504 for line breaks before binary operators#502
IanLee1521 merged 5 commits intoPyCQA:masterfrom
sigmavirus24:add-W504

sigmavirus24 commented Apr 30, 2016 •

edited

Loading

Uh oh!

sigmavirus24 commented May 17, 2016

Uh oh!

IanLee1521 May 20, 2016

Uh oh!

IanLee1521 commented May 20, 2016

Uh oh!

IanLee1521 commented Jun 26, 2016

Uh oh!

hoylemd commented Jul 18, 2016

Uh oh!

sigmavirus24 commented Jul 18, 2016

Uh oh!

peterjc commented Jan 11, 2018

Uh oh!

FichteFoll commented Jan 11, 2018

Uh oh!

peterjc commented Jan 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sigmavirus24 commented Apr 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sigmavirus24 commented May 17, 2016

Uh oh!

IanLee1521 May 20, 2016

Choose a reason for hiding this comment

Uh oh!

IanLee1521 commented May 20, 2016

Uh oh!

IanLee1521 commented Jun 26, 2016

Uh oh!

hoylemd commented Jul 18, 2016

Uh oh!

sigmavirus24 commented Jul 18, 2016

Uh oh!

peterjc commented Jan 11, 2018

Uh oh!

FichteFoll commented Jan 11, 2018

Uh oh!

peterjc commented Jan 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sigmavirus24 commented Apr 30, 2016 •

edited

Loading