Ignore a new Flake8 whitespace error#1158
Conversation
Fixes hylang#1157. The new check is E305. Since we're now using the `--ignore` option, we have to list all the checks that are ignored by default, too. I decided that ignoring E305 was better than changing the whitespace it was complaining about because, in at least some cases in our current codebase, single blank lines are used to indicate that several top-level definitions are associated with each other.
|
👍 I'm not sure this is the right solution long term, but I'll approve this for now, since it's kind of holding up other PRs. |
|
Here's the table for the error codes, if that helps anyone. |
|
Wait, what's |
|
Good question. It's in the default of |
|
Did I find the wrong table? Does everything still work if you delete |
|
Maybe we should also bug the flake8 people about this inconsistency. Or maybe the pycodestyle people. They may have neglected to update their docs. |
|
That would be my guess. |
|
Looks like |
|
Makes sense, I guess. |
|
Looks good to me |
3 participants
Fixes #1157.
The new check is E305. Since we're now using the
--ignoreoption, we have to list all the checks that are ignored by default, too.I decided that ignoring E305 was better than changing the whitespace it was complaining about because, in at least some cases in our current codebase, single blank lines are used to indicate that several top-level definitions are associated with each other.