Fix get_bam and get_primary_bam functions#150
Fix get_bam and get_primary_bam functions#150tristanbrown wants to merge 2 commits intogenialis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 68.54% 68.51% -0.03%
==========================================
Files 49 49
Lines 3468 3468
==========================================
- Hits 2377 2376 -1
- Misses 1091 1092 +1
Continue to review full report at Codecov.
|
| # pylint: disable=protected-access | ||
| if not isinstance(index, (slice,) + six.integer_types): | ||
| raise TypeError | ||
| if ((not isinstance(index, slice) and index < 0) or |
There was a problem hiding this comment.
Don't change the code, if the functionality stays the same.
There was a problem hiding this comment.
I'm attempting to fix the Travis-CI test here. The tests started failing because of this change: PyCQA/pycodestyle#502
In this discussion on pycodestyle, they mention that W503 has been added to the default ignore list, and W504 will take precedence. However, in our Travis-CI tests, W503 is still reported as a failure. Is there a way to set up our .tox file so that certain ignored warnings are not reported as failures?
There was a problem hiding this comment.
Ok, I see. You have to argue such changes better and put a description in the commit message.
| import yaml | ||
| # Needed because we mock requests in test_resolwe.py | ||
| from requests.exceptions import ConnectionError # pylint: disable=redefined-builtin | ||
| from six.moves.urllib.parse import urljoin # pylint: disable=import-error |
There was a problem hiding this comment.
Fix the problem instead of disabling the checker.
|
Superseded by #151 |
3 participants
@jkokosar @dblenkus