fix travis: format_map is python 3.2 or later only and ignore new rule W504#636
Merged
wjwwood merged 2 commits intoros-infrastructure:masterfrom Nov 1, 2018
Merged
Conversation
Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297
NikolausDemmel
changed the title
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=======================================
Coverage 75.29% 75.29%
=======================================
Files 30 30
Lines 2882 2882
=======================================
Hits 2170 2170
Misses 712 712Continue to review full report at Codecov.
|
nuclearsandwich
approved these changes
Nov 1, 2018
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Thanks for taking a look and providing a fix!
at-wat
pushed a commit
to at-wat/rosdep
that referenced
this pull request
Nov 15, 2018
…e W504 (ros-infrastructure#636) * format_map is python 3.2 or later only (see also ros-infrastructure#602) * Ignore new pycodestyle rule W504 Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using format_map breaks travis on python 2 (see also #602), e.g.: https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297
W504 was introduced in PyCQA/pycodestyle#502 it seems.
Makes travis on master fail also for python 3 https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297