Skip to content

Update document for release 1.1.0 - #21

Merged
archlitchi merged 4 commits into
mainfrom
update_document
Aug 4, 2026
Merged

Update document for release 1.1.0#21
archlitchi merged 4 commits into
mainfrom
update_document

Conversation

@archlitchi

@archlitchi archlitchi commented Aug 4, 2026

Copy link
Copy Markdown
Member
  1. We enable monitor by default
  2. Update the kai-scheduler installation command

Summary by CodeRabbit

  • Documentation
    • Added prerequisites for KAI-Scheduler version 0.17.0 or later.
    • Updated Helm installation instructions and chart versions.
    • Included monitor enablement, node selector, and runtime class configuration details.
    • Clarified that VRAM metrics are enabled as part of the standard setup.

Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@hami-robot

hami-robot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The README now requires KAI-Scheduler 0.17.0, uses OCI Helm installation, pins the isolator chart to 1.1.0-chart, enables monitoring, documents runtime settings, and simplifies VRAM metrics instructions.

Changes

Installation documentation

Layer / File(s) Summary
Helm installation requirements and configuration
README.md
Adds the KAI-Scheduler prerequisite. Updates the Helm source and versions. Enables the monitor and ServiceMonitor. Documents node selection and NVIDIA runtime settings.
VRAM metrics instructions
README.md
Removes the optional label and separate monitor enablement instructions from the VRAM metrics section.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: dttung2905

Poem

A rabbit checks the chart with care,
OCI commands now nestle there.
Monitors wake, metrics shine,
Versions match in neat design.
Hop through setup, smooth and bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the documentation updates for release 1.1.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_document

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 7: Correct the README heading spelling by changing “Prequisities” to
“Prerequisites,” leaving the surrounding content unchanged.
- Around line 32-33: Update the README configuration guidance around
monitor.serviceMonitor.enabled to document that automatic scraping requires the
Prometheus Operator monitoring.coreos.com/v1 ServiceMonitor CRD, and state that
the setting has no effect when that CRD is unavailable.
- Line 34: Update the README Helm install example around the `--version
1.1.0-chart` reference to use a version that exists in the checked-out chart or
omit the version for source-only installs; keep release workflow version-bumping
details out of user-facing installation documentation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8189a210-d6a3-476d-841e-bfbd806926e6

📥 Commits

Reviewing files that changed from the base of the PR and between b705858 and 9626970.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md

For architecture details see the [Design](#design) section.

## Prequisities

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the heading spelling.

Change Prequisities to Prerequisites.

🧰 Tools
🪛 LanguageTool

[grammar] ~7-~7: Ensure spelling is correct
Context: ... see the Design section. ## Prequisities - KAI-scheduler Version: ≥ 0.17.0 ## Qu...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 7, Correct the README heading spelling by changing
“Prequisities” to “Prerequisites,” leaving the surrounding content unchanged.

Source: Linters/SAST tools

Comment thread README.md
Comment on lines +32 to +33
--set monitor.enabled=true \
--set monitor.serviceMonitor.enabled=true \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Document the ServiceMonitor dependency.

The chart creates ServiceMonitor only when monitoring.coreos.com/v1 is available. Without the Prometheus Operator CRD, Helm succeeds but automatic scraping is not configured.

Add this prerequisite or state that monitor.serviceMonitor.enabled=true is effective only when the CRD exists.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 32 - 33, Update the README configuration guidance
around monitor.serviceMonitor.enabled to document that automatic scraping
requires the Prometheus Operator monitoring.coreos.com/v1 ServiceMonitor CRD,
and state that the setting has no effect when that CRD is unavailable.

Comment thread README.md
@archlitchi
archlitchi merged commit 13af262 into main Aug 4, 2026
5 of 6 checks passed
@archlitchi
archlitchi deleted the update_document branch August 4, 2026 09:26
@coderabbitai coderabbitai Bot mentioned this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant