Update document for release 1.1.0 - #21
Conversation
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe README now requires KAI-Scheduler 0.17.0, uses OCI Helm installation, pins the isolator chart to 1.1.0-chart, enables monitoring, documents runtime settings, and simplifies VRAM metrics instructions. ChangesInstallation documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 7: Correct the README heading spelling by changing “Prequisities” to
“Prerequisites,” leaving the surrounding content unchanged.
- Around line 32-33: Update the README configuration guidance around
monitor.serviceMonitor.enabled to document that automatic scraping requires the
Prometheus Operator monitoring.coreos.com/v1 ServiceMonitor CRD, and state that
the setting has no effect when that CRD is unavailable.
- Line 34: Update the README Helm install example around the `--version
1.1.0-chart` reference to use a version that exists in the checked-out chart or
omit the version for source-only installs; keep release workflow version-bumping
details out of user-facing installation documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
||
| For architecture details see the [Design](#design) section. | ||
|
|
||
| ## Prequisities |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the heading spelling.
Change Prequisities to Prerequisites.
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: Ensure spelling is correct
Context: ... see the Design section. ## Prequisities - KAI-scheduler Version: ≥ 0.17.0 ## Qu...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 7, Correct the README heading spelling by changing
“Prequisities” to “Prerequisites,” leaving the surrounding content unchanged.
Source: Linters/SAST tools
| --set monitor.enabled=true \ | ||
| --set monitor.serviceMonitor.enabled=true \ |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Document the ServiceMonitor dependency.
The chart creates ServiceMonitor only when monitoring.coreos.com/v1 is available. Without the Prometheus Operator CRD, Helm succeeds but automatic scraping is not configured.
Add this prerequisite or state that monitor.serviceMonitor.enabled=true is effective only when the CRD exists.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 32 - 33, Update the README configuration guidance
around monitor.serviceMonitor.enabled to document that automatic scraping
requires the Prometheus Operator monitoring.coreos.com/v1 ServiceMonitor CRD,
and state that the setting has no effect when that CRD is unavailable.
Summary by CodeRabbit