Skip to content

docs: fix kai-scheduler hamicore install flags - #8

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
mesutoezdil:fix/hamicore-install-flags
Aug 3, 2026
Merged

docs: fix kai-scheduler hamicore install flags#8
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
mesutoezdil:fix/hamicore-install-flags

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

the docs enable hami-core with --set scheduler.gpuSharing.enabled=true --set scheduler.gpuSharing.hamicoreEnabled=true, but those keys don't exist in the kai-scheduler chart (checked v0.16.0 through main), so helm silently ignores them and nothing gets enabled.

fix: use the real values --set global.gpuSharing=true --set binder.plugins.hamicore.enabled=true. verified with helm template.

companion: kai-scheduler/KAI-Scheduler#1925, Project-HAMi/website#612. reported in kai-scheduler/KAI-Scheduler#1912.

The install snippet used --set scheduler.gpuSharing.enabled and --set scheduler.gpuSharing.hamicoreEnabled, but neither key exists in the kai-scheduler chart values.yaml (checked v0.16.0 through main). helm silently ignores unknown --set paths, so the command runs but never enables GPU sharing or the hamicore plugin. Use the real chart values: global.gpuSharing and binder.plugins.hamicore.enabled.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The README Quick Start Helm command now enables GPU sharing through global.gpuSharing and HAMi-core through binder.plugins.hamicore.enabled.

Changes

GPU sharing deployment documentation

Layer / File(s) Summary
Update GPU sharing Helm values
README.md
The deployment command uses global.gpuSharing=true and binder.plugins.hamicore.enabled=true instead of the previous scheduler GPU sharing keys.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: archlitchi

Poem

I’m a bunny with a chart to share,
New GPU values hop through the air.
HAMi-core wakes with a tap and a grin,
The Quick Start now lets sharing begin.
Boing! Clear commands make deployment win.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the README update correcting KAI-Scheduler HAMiCore installation flags.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mesutoezdil mesutoezdil changed the title docs: fix KAI-Scheduler hamicore install flags docs: fix kai-scheduler hamicore install flags Jul 15, 2026

@archlitchi archlitchi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot

hami-robot Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, mesutoezdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label Aug 3, 2026
@hami-robot
hami-robot Bot merged commit 34600e5 into Project-HAMi:main Aug 3, 2026
6 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants