docs: fix kai-scheduler hamicore install flags - #8
Conversation
The install snippet used --set scheduler.gpuSharing.enabled and --set scheduler.gpuSharing.hamicoreEnabled, but neither key exists in the kai-scheduler chart values.yaml (checked v0.16.0 through main). helm silently ignores unknown --set paths, so the command runs but never enables GPU sharing or the hamicore plugin. Use the real chart values: global.gpuSharing and binder.plugins.hamicore.enabled. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
📝 WalkthroughWalkthroughThe README Quick Start Helm command now enables GPU sharing through ChangesGPU sharing deployment documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, mesutoezdil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the docs enable hami-core with
--set scheduler.gpuSharing.enabled=true --set scheduler.gpuSharing.hamicoreEnabled=true, but those keys don't exist in the kai-scheduler chart (checked v0.16.0 through main), so helm silently ignores them and nothing gets enabled.fix: use the real values
--set global.gpuSharing=true --set binder.plugins.hamicore.enabled=true. verified withhelm template.companion: kai-scheduler/KAI-Scheduler#1925, Project-HAMi/website#612. reported in kai-scheduler/KAI-Scheduler#1912.