Skip to content

prepare to release v1.1.0: update libvgpu submodule to upstream main and simplify README - #20

Merged
archlitchi merged 1 commit into
mainfrom
update-libvgpu-submodule
Aug 4, 2026
Merged

prepare to release v1.1.0: update libvgpu submodule to upstream main and simplify README#20
archlitchi merged 1 commit into
mainfrom
update-libvgpu-submodule

Conversation

@archlitchi

@archlitchi archlitchi commented Aug 4, 2026

Copy link
Copy Markdown
Member

att

Summary by CodeRabbit

  • Documentation
    • Updated optional VRAM metrics guidance to use the monitor’s pod IP.
    • Simplified customization guidance for container vGPU mounts and shared GPU resources.
  • Maintenance
    • Updated the bundled vGPU library revision.

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@hami-robot

hami-robot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@archlitchi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 55b52da6-fd39-4e08-ae7b-c751ad500893

📥 Commits

Reviewing files that changed from the base of the PR and between 0b54aaf and 855e807.

📒 Files selected for processing (2)
  • README.md
  • libvgpu
📝 Walkthrough

Walkthrough

The README updates VRAM metrics access and customization guidance. The libvgpu submodule reference advances to a newer commit.

Changes

Documentation and libvgpu updates

Layer / File(s) Summary
Metrics and customization documentation
README.md
The README directs metrics queries through the monitor pod IP and documents paths.containerVgpuMount and webhook.gpuShareResources.
libvgpu revision
libvgpu
The submodule pointer advances to commit 5496322f2fb3e71bf1eca014fba3c9bc59ab8ffd.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: enhancement

Suggested reviewers: dttung2905

Poem

A rabbit hops through metrics bright,
Pod IP guides the path just right.
Mounts and shares now meet the page,
libvgpu turns a newer stage.
Nibble, review, and merge with cheer!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the submodule update and README simplification for the v1.1.0 release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-libvgpu-submodule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Aug 4, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@libvgpu`:
- Line 1: Update the libvgpu submodule reference to a reachable commit from the
configured HAMi-core remote, or revise its configured URL to a remote containing
commit 5496322f2fb3e71bf1eca014fba3c9bc59ab8ffd; ensure the submodule
initializes successfully before merging.

In `@README.md`:
- Line 45: Update the affected code fence in README.md to use the bash language
identifier on its opening fence, changing it from an untyped fence to ```bash
while preserving the enclosed command content.
- Line 46: Update the curl example in README.md to use a shell-safe pod IP
placeholder without spaces, such as a hyphenated token, or show a command that
resolves the monitor Pod IP. Preserve the existing metrics endpoint and port.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 003aaaf5-a97d-4b2a-90de-ae776baebe52

📥 Commits

Reviewing files that changed from the base of the PR and between 84393ae and 0b54aaf.

📒 Files selected for processing (2)
  • README.md
  • libvgpu

Comment thread libvgpu
Comment thread README.md
Comment thread README.md
- Update libvgpu submodule from 4bbd97a to 5496322 (upstream main)
- Simplify README metrics usage and customization sections

Signed-off-by: archlitchi <mengxuan.li@dynamia.ai>
@archlitchi
archlitchi force-pushed the update-libvgpu-submodule branch from 0b54aaf to 855e807 Compare August 4, 2026 05:12
@archlitchi
archlitchi merged commit b705858 into main Aug 4, 2026
5 of 6 checks passed
@archlitchi
archlitchi deleted the update-libvgpu-submodule branch August 4, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant