-
Notifications
You must be signed in to change notification settings - Fork 6
Update document for release 1.1.0 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,17 +4,22 @@ | |
|
|
||
| For architecture details see the [Design](#design) section. | ||
|
|
||
| ## Prequisities | ||
|
|
||
| - **KAI-scheduler Version**: ≥ 0.17.0 | ||
|
|
||
| ## Quick Start | ||
|
|
||
| ### 1. Deploy KAI-Scheduler with GPU sharing enabled | ||
|
|
||
| Follow the [KAI-Scheduler deployment guide](https://github.com/NVIDIA/KAI-Scheduler/blob/main/docs/gpu-sharing/gpu-sharing.md) and enable `gpushare` and `hamicore`: | ||
|
|
||
| ```bash | ||
| helm install kai-scheduler oci://ghcr.io/nvidia/kai-scheduler \ | ||
| helm install kai-scheduler oci://ghcr.io/kai-scheduler/kai-scheduler/kai-scheduler \ | ||
| --set global.gpuSharing=true \ | ||
| --set binder.plugins.hamicore.enabled=true \ | ||
| --namespace kai-scheduler --create-namespace | ||
| --namespace kai-scheduler --create-namespace \ | ||
| --version v0.17.0 | ||
| ``` | ||
|
|
||
| ### 2. Deploy kai-resource-isolator | ||
|
|
@@ -24,10 +29,14 @@ Install directly from the OCI registry: | |
| ```bash | ||
| helm install kai-resource-isolator oci://docker.io/projecthami/kai-resource-isolator \ | ||
| --namespace kai-resource-isolator --create-namespace \ | ||
| --version 1.0.0-chart | ||
| --set monitor.enabled=true \ | ||
| --set monitor.serviceMonitor.enabled=true \ | ||
|
Comment on lines
+32
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Document the ServiceMonitor dependency. The chart creates Add this prerequisite or state that 🤖 Prompt for AI Agents |
||
| --version 1.1.0-chart | ||
|
archlitchi marked this conversation as resolved.
|
||
| ``` | ||
|
|
||
| Note: Chart versions carry a `-chart` suffix (e.g. `1.0.0-chart`). Available versions are listed at [projecthami/kai-resource-isolator](https://hub.docker.com/r/projecthami/kai-resource-isolator/tags) on Docker Hub. | ||
| The default `monitor.nodeSelector` is `nvidia.com/gpu.present: "true"` (NVIDIA GPU feature discovery). Set `monitor.runtimeClassName=nvidia` if NVML is only available through the NVIDIA runtime handler in your cluster. | ||
|
|
||
| Note: Chart versions carry a `-chart` suffix (e.g. `1.1.0-chart`). Available versions are listed at [projecthami/kai-resource-isolator](https://hub.docker.com/r/projecthami/kai-resource-isolator/tags) on Docker Hub. | ||
|
|
||
| ## Build | ||
|
|
||
|
|
@@ -38,25 +47,14 @@ git submodule update --init --recursive | |
| docker build -f docker/Dockerfile -t <registry>/<project>/kai-resource-isolator:<tag> . | ||
| ``` | ||
|
|
||
| ## Per-container VRAM metrics (optional) | ||
| ## Per-container VRAM metrics | ||
|
|
||
| `kai-vgpu-monitor` is a DaemonSet that reads the shared-memory cache `libvgpu.so` writes for each GPU container and exposes HAMi-compatible gauges (`hami_vgpu_memory_used_bytes`, `hami_vgpu_memory_limit_bytes`, `hami_container_device_utilization_ratio`, …) by using | ||
|
|
||
| ``` | ||
| curl {pod ip}:9394/metrics | ||
| ``` | ||
|
|
||
| It is disabled by default because it runs privileged and needs NVML. Enable it on GPU nodes: | ||
|
|
||
| ```bash | ||
| helm upgrade --install kai-resource-isolator oci://docker.io/projecthami/kai-resource-isolator \ | ||
| --namespace kai-resource-isolator --create-namespace \ | ||
| --set monitor.enabled=true \ | ||
| --set monitor.serviceMonitor.enabled=true | ||
| ``` | ||
|
|
||
| The default `monitor.nodeSelector` is `nvidia.com/gpu.present: "true"` (NVIDIA GPU feature discovery). Set `monitor.runtimeClassName=nvidia` if NVML is only available through the NVIDIA runtime handler in your cluster. | ||
|
|
||
| ## Customization | ||
|
|
||
| Tune `paths.containerVgpuMount` and `webhook.gpuShareResources` for your environment and HAMi extended resource names. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the heading spelling.
Change
PrequisitiestoPrerequisites.🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: Ensure spelling is correct
Context: ... see the Design section. ## Prequisities - KAI-scheduler Version: ≥ 0.17.0 ## Qu...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Source: Linters/SAST tools