-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe nodes #73
Observe nodes #73
Conversation
/cc @azakus |
@@ -306,11 +284,6 @@ | |||
this._updateSelected(); | |||
} | |||
}.bind(this)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can factor away the bind here if you want. The callback is called in the context of the observed node and you shouldn't need the argument now.
Can we add a test that would have failed before? For example, add a node that only gets to distributed to a child of the selector via re-projection? |
Why don't we change the |
Feedback addressed. Tests are failing locally due to a bug in |
Also, I threw in a fix for #69 since it was relevant and it felt lame to fix it with the old code. |
We already appear to have tests for this that passed. See: https://github.com/PolymerElements/iron-selector/blob/master/test/content.html Hrm.. |
Already resolved, but this change now depends on resolution of Polymer/polymer#2587 |
Just a note for future @cdata: You'll need to bump the Polymer version up in |
83f4d63
to
247c23c
Compare
This change does the following:
listen
call Polymer/polymer#2535Polymer.dom(...).observeNodes
/cc @notwaldorf
This branch is blocked by Polymer/polymer#2548 being tagged. It is currently released on
polymer#master
, but until it is tagged these changes cannot be merged intoiron-selected#master
.