Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IronMultiSelectableBehavior: no _updateSelected() on DOM mutation #69

Closed
sklobovskaya opened this issue Oct 1, 2015 · 1 comment
Closed
Assignees

Comments

@sklobovskaya
Copy link

IronMultiSelectableBehavior fails to update the selection (this._updateSelected()) when the DOM is mutated.

IronSelectableBehavior calls this._updateSelected() on DOM mutation, here:

https://github.com/PolymerElements/iron-selector/blob/master/iron-selectable.html#L295

However, when using IronMultiSelectableBehavior, the above line is never executed because IronMultiSelectableBehavior uses this.selectedValues instead, and thus this.selected is always null.

@eliseosoto
Copy link

The problem appears to be in IronSelectableBehavior._observeContent

https://github.com/PolymerElements/iron-selector/blob/master/iron-selectable.html#L277

var content = node.querySelector('content');
content is null

And then after an element that has IronSelectableBehavior is attached the _contentObserver is undefined.

cdata pushed a commit that referenced this issue Oct 16, 2015
@cdata cdata mentioned this issue Oct 16, 2015
cdata pushed a commit that referenced this issue Oct 16, 2015
@cdata cdata closed this as completed in f97d342 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants