Only one real listener per listen call
#2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually use event listener cache correctly Fixes #2534 Polymer Gestures creates a new bound handler for every `listen` call
|
Is there a test we can put in place for this? |
|
@samccone yep |
|
A good test might be..
|
| this._listen(node, eventName, | ||
| this._createEventHandler(node, eventName, methodName)); | ||
| var handler = this._recallEventHandler(this, eventName, node, methodName); | ||
| // reuse cache'd handler |
|
Relevant for PolymerElements/iron-selector#64 |
|
@sorvell or @kevinpschaaf PTAL |
| @@ -141,6 +141,41 @@ | |||
| assert.deepEqual(el._removed[3], {target: 'div', event: 'bar'}); | |||
| }); | |||
| }); | |||
|
|
|||
| suite('Event Listener Cache', function() { | |||
Gestures have counter code that should not be re-added with multiple identical `listen` calls
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Oct 8, 2015
Only one real listener per `listen` call
cdata
pushed a commit
to PolymerElements/iron-selector
that referenced
this pull request
Oct 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually use event listener cache correctly
Fixes #2534 Polymer Gestures creates a new bound handler for every
listencall