Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer.dom(...).observeNodes does not notify for some DOM removal #2587

Closed
cdata opened this issue Oct 17, 2015 · 2 comments
Closed

Polymer.dom(...).observeNodes does not notify for some DOM removal #2587

cdata opened this issue Oct 17, 2015 · 2 comments
Assignees
@sorvell
Labels
0.5

Comments

@cdata
Copy link
Contributor

cdata commented Oct 17, 2015

Please see the contrived test case here: http://jsbin.com/dajife/2

Removing nodes from the example element (notably, an element without a shadow root), fails to cause an expected notification from observeNodes.
@sorvell sorvell added the 0.5 label Oct 17, 2015
@sorvell
Copy link
Contributor

sorvell commented Oct 17, 2015

Confirmed. The issue is that we're only notifying if we have an existing logical parent for the node that's added somewhere else. This is not a sufficient check and we'll need to fallback to using composed parent.

kevinpschaaf added a commit that referenced this issue Oct 17, 2015
@kevinpschaaf
Merge pull request #2588 from Polymer/fix-2587
f10deb1 
Fix #2587: When Polymer.dom(el).appendChild(node) is called, cleanup …
@cdata cdata mentioned this issue Oct 17, 2015
Merged
@cdata
Copy link
Contributor Author

cdata commented Oct 19, 2015

This issue supports PolymerElements/iron-selector#73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
0.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @cdata