Add support for VTK 9

[larshg]

Closes #4138, closes #4096.

[kunaltyagi]

Please run make format and commit+push to pass the first CI 😄

[larshg]

Is draft PRs not run by CI anymore?

[kunaltyagi]

Is draft PRs not run by CI anymore?

[kunaltyagi]

Please rebase to get the latest release pipeline CI. Current version forces release CI to be run always

[kunaltyagi]

15/71

[kunaltyagi]

34/71

[kunaltyagi]

@larshg 🚀 ?

[larshg]

Yes please, lets get it merged so we can get a swarm of issues about VTK9 🤣

[kunaltyagi]

LGTM. I'll let you do the honors of merging this 🥳 🎆 🎊

[larshg]

Woot 🥳

[Neumann-A]

So when will be the next tagged release?

[larshg]

So when will be the next tagged release?

That's a great question. Since there are still a few issue left on the milestone, but maybe... some of them should be moved for the next :)
https://github.com/PointCloudLibrary/pcl/milestone/10

[drhpc]

About the milestones and releasing this fix … please consider releasing such changes as minor/bugfix versions. I'll have to pull in the change anyway when packaging this for an environment that has vtk 9, like I right now have to pull in PR 4540 since the still-current release relies on qhull API that has long been deprecated.

When you are in this ecosystem of dependencies that put pressure on users even being able to build PCL at all, it would be nice to consider such build fixes/updates separately from any milestone goals about features. Saves a lot of pain for packagers, especially, who usually are not at the liberty of picking a preferred version of any dependency when there is another in the repository/distribution.