Closed
Conversation
Version 2 of vtkCellArray deprecates the write pointer and requires const pointers in in some api calls that return pointers to shared memory. If the VTK_CELL_ARRAY_V2 macro is defined, this code uses the appropriate const pointers and uses alternative methods to insert cells into the cell array. This commit also adds some missing vtk headers that were causing incomplete type errors.
Reorganise to hopefully support pre 9.0.
Move RenderingUI as it is not available vtk < 9.0
|
actually still around, just have been a bit swamped. Let me have a look at remaining comments. I haven’t figured out a good common header for the typedefs, and it looks like someone else has worked on cmake |
Contributor
Author
|
Ahh great. Yes, I have worked a bit on it. I have made a pr to your branch :-) Can see we have some more work to so :-D |
pionex
approved these changes
May 28, 2020
Contributor
Author
|
Closing in favour of #4096. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since @pionex hasn't responded for a while, I'll just checking how CI works with my additions.