Skip to content

Fix compile issue of visualization::details::fillCells under MSVC due to missing symbol export#4705

Merged
kunaltyagi merged 1 commit intoPointCloudLibrary:masterfrom
SunBlack:fillCells_export_fix
Apr 18, 2021
Merged

Fix compile issue of visualization::details::fillCells under MSVC due to missing symbol export#4705
kunaltyagi merged 1 commit intoPointCloudLibrary:masterfrom
SunBlack:fillCells_export_fix

Conversation

@SunBlack
Copy link
Contributor

Fixes:

1>------ Build started: Project: pcl_example_nurbs_fitting_surface, Configuration: Debug x64 ------
1>example_nurbs_fitting_surface.obj : error LNK2019: unresolved external symbol "__int64 __cdecl pcl::visualization::details::fillCells(class std::vector<int,class std::allocator<int> > &,class std::vector<struct pcl::Vertices,class std::allocator<struct pcl::Vertices> > const &,class vtkSmartPointer<class vtkCellArray>,int)" (?fillCells@details@visualization@pcl@@YA_JAEAV?$vector@HV?$allocator@H@std@@@std@@AEBV?$vector@UVertices@pcl@@V?$allocator@UVertices@pcl@@@std@@@5@V?$vtkSmartPointer@VvtkCellArray@@@@H@Z) referenced in function "public: bool __cdecl pcl::visualization::PCLVisualizer::updatePolygonMesh<struct pcl::PointXYZ>(class std::shared_ptr<class pcl::PointCloud<struct pcl::PointXYZ> const > const &,class std::vector<struct pcl::Vertices,class std::allocator<struct pcl::Vertices> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (??$updatePolygonMesh@UPointXYZ@pcl@@@PCLVisualizer@visualization@pcl@@QEAA_NAEBV?$shared_ptr@$$CBV?$PointCloud@UPointXYZ@pcl@@@pcl@@@std@@AEBV?$vector@UVertices@pcl@@V?$allocator@UVertices@pcl@@@std@@@4@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@4@@Z)
1>C:\dev\pcl_build\bin\pcl_example_nurbs_fitting_surfaced.exe : fatal error LNK1120: 1 unresolved externals
1>Done building project "pcl_example_nurbs_fitting_surface.vcxproj" -- FAILED.

Issue introduced in #4262

Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we don't build viz on the windows CI

@kunaltyagi kunaltyagi merged commit aa29443 into PointCloudLibrary:master Apr 18, 2021
@SunBlack SunBlack deleted the fillCells_export_fix branch April 18, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants