Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DemoApp]: Fix some design isssues #189

Closed
1 task done
ludovic35 opened this issue Oct 10, 2024 · 1 comment · Fixed by #194
Closed
1 task done

[DemoApp]: Fix some design isssues #189

ludovic35 opened this issue Oct 10, 2024 · 1 comment · Fixed by #194
Assignees
@ludovic35 @Tayebsed93
Labels
📱 demo app Update of the Demo App

Comments

@ludovic35
Copy link
Member

ludovic35 commented Oct 10, 2024 •
edited
Loading

Prerequisites

As a

user of the demo application

... I want to

the same presentation of all token illustrations

... so that I can

see all token easily

Motivation and context

  1. Use same typo on description (.typeBodyDefaultLarge(theme) on all screens
  2. Use same typo on token name (.typeBodyStrongLarge(theme) on token illustration (exemple "elevationNone" on the elevation screen)
  3. Use same typo on token value .typeBodyDefaultMedium(theme) on token illustration (exemple "x: y: .." on the elevation screen)
  4. Try toi add unit og the token (exemple border)
  5. Try to mutualise the illustration view (refactring)

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Oct 10, 2024
@pylapp pylapp removed their assignment Oct 10, 2024
@ludovic35 ludovic35 linked a pull request Oct 11, 2024 that will close this issue
[#189] Fix some design issues and mutualize some UI elements in demo app #194
Merged
9 tasks
@ludovic35 ludovic35 added 📱 demo app Update of the Demo App and removed 🔍 triage A new issue that needs to be treated labels Oct 14, 2024
@pylapp pylapp mentioned this issue Oct 14, 2024
Merged
9 tasks
pylapp pushed a commit that referenced this issue Oct 14, 2024
@ludovic35
refactor: fix some design issues and mutualize some UI elements in de…
77e437d 
…mo app (#189) (#194)

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp mentioned this issue Oct 18, 2024
Merged
pylapp added a commit that referenced this issue Oct 18, 2024
@pylapp @ludovic35 @Tayebsed93
Release 0.4.0 (#206)
c8da6ec 
Release of version 0.4.0
See below the full CHANGELOG details.

Added

- [DemoApp] Update opacity screen with new design ([#200](#200))
- [DemoApp] Add color tokens screen in demo app ([#152](#152))
- [Library] Add semantic tokens `spacePaddingInlineTallest`, `spacePaddingBlockTallest`, `spaceColumnGapTaller`, `spaceColumnGapWithArrowShortest`, `spaceRowGapShortest` (Figjam final synchronization of October 16th)
- [Library] Add semantic color tokens ([#124](#124))
- [DemoApp] Fix some design issues and mutualize some UI elements ([#189](#189))
- [DemoApp] Add sizing tokens screen in demo app ([#150](#150))
- [DemoApp] Add spacing tokens screen in demo app ([#149](#149))
- [Library] Add color semantic tokens `colorContentTransparentDefault`, `colorBorderTransparentDefault` and `colorBackgroundTransparentDefault` (October 8th) ([#177](#177))
- [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](#157))

Changed

- [Library] Update of semantic typography tokens (Figjam final synchronization of October 16th)
- [Library] Update of semantic grid tokens `gridExtraCompactColumnCount`, `gridCompactColumnGap`, `gridRegularColumnGap` (Figjam final synchronization of October 16th)
- [Library] Update of semantic elevation token `elevationStickyNavigationScrolled` (Figjam final synchronization of October 16th)
- [Library] Update of semantic color tokens, semantic sizing tokens (Figjam final synchronization of October 16th)
- [Library/DemoApp] Updates SwiftLint rules, fix linter warnings ([#143](#143))
- [Tool] Update the templates for GitHub issues
- [Tool] Improve script for documentation generation ([#168](#168))
- [Library] Rename raw brand-specific color tokens in Orange theme (no use of "brand" word) ([#179](#179))
- [Library] `fontLetterSpacingMobile*` and `fontLetterSpacingTablet*` merged in `MultipleFontLetterSpacingTokens` objects
- [Library] `fontLineHeightMobile*` and `fontLineHeightTablet*` merged in `MultipleFontLineHeightTokens` objects
- [Library] `fontSizeMobile*` and `fontSizeTablet*` merged in `MultipleFontSizeTokens` objects 
- [Library] Update semantic and raw tokens for fonts ([#155](#155))
- [Library] Update semantic tokens for fonts (October 7th) ([#172](#172))
- [Library] Update raw tokens for fonts (October 7th) ([#170](#170))
- [Library] Any semantic token of sizing `TypeXXX` has been replaced by `TypeSizeXXX` (update of October 7th)
- [Library] Any semantic tokens of sizing `WithTypeXXX` has been replaced by `TypzeXXX` (update of October 7th)
- [Library] Update semantic tokens for sizing (October 7th) ([#173](#173))
- [Library] Any semantic tokens of spacing `isIcon` and `isArrow` are now `withIcon` and `withArrow` (update of October 7th)
- [Library] Update semantic tokens for spacing (October 4th) ([#174](#174))
- [Library] Update semantic tokens for spacing (October 4th) ([#156](#156))
- [Library] Update raw tokens for dimensions (October 7th) ([#169](#169))

Removed

- [Library] Raw typography token `fontSize100` (Figjam final synchronization of October 16th)
- [Library] Semantic token `spaceColumnGapWithArrowTaller` (Figjam final synchronization of October 16th)
- [Library] Remove all color alias semantic tokens and any optional color tokens type uses
- [Library] `SoshTheme` ([#180](#180))
- [Library] `fontSizeMobile*`, `fontSizeTablet*`, `fontLineHeightMobile*`, `fontLineHeightTablet*`, `fontLetterSpacingMobile*`, `fontLetterSpacingTablet*` removed (update of October 4th)
- [Library] `spaceRowGapWithIconTaller`, `spaceColumnGapWithIconTaller` removed (update of October 7th)

Fixed

- [Library] `typeBodyDefaultLarge` font weight ([#191](#191))

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Tayeb Sedraia <[email protected]>
@pylapp
Copy link
Member

pylapp commented Oct 18, 2024

ℹ️ Released with version v0.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludovic35 ludovic35

@Tayebsed93 Tayebsed93

Labels
📱 demo app Update of the Demo App
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#189] Fix some design issues and mutualize some UI elements in demo app Orange-OpenSource/ouds-ios
3 participants
@pylapp @ludovic35 @Tayebsed93