Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#189] Fix some design issues and mutualize some UI elements in demo app #194

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Oct 11, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#189

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • (NA) I have added unit tests to cover my changes (optional)

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 linked an issue Oct 11, 2024 that may be closed by this pull request
1 task
@ludovic35
Copy link
Member Author

@pylapp Commit message should be like:

refactor: Fix some design issues and mutualize some UI elements in demo app (#189)

@pylapp
Copy link
Member

pylapp commented Oct 14, 2024

@ludovic35 Je sais comment faire des messages de commits ; je me permet juste de préciser lesquels pourraient être utilisés :-)

D'ailleurs concernant ta proposition, il ne faut pas que le message commence par une majuscule, et idéalement si on pouvait référencer le numéro de la PR ce serait parfait.

On aurait donc :

refactor: fix some design issues and mutualize some UI elements in demo app (#189) (#194)

Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une faute de frappe à corriger ;)

Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp pylapp merged commit 77e437d into develop Oct 14, 2024
2 of 4 checks passed
@pylapp pylapp deleted the 189-demoapp-fix-some-design-isssues branch October 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DemoApp]: Fix some design isssues
2 participants