Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token] Spacing semantic tokens update (Oct, 7) #174

Closed
julien-deramond opened this issue Oct 7, 2024 · 2 comments · Fixed by #175
Closed

[Token] Spacing semantic tokens update (Oct, 7) #174

julien-deramond opened this issue Oct 7, 2024 · 2 comments · Fixed by #175
Assignees
@pylapp
Labels
📀 token Related to tokens (raws, semantics or components)

Comments

@julien-deramond
Copy link
Contributor

Description

Spacing semantic tokens have been updated on October, 7.

⚠ As usual, the files generated by the parser are not perfect, so please adapt to your current tokens files.

    public static let spaceFixedHuge = dimension700
-    public static let spaceRowGapWithIconTaller = dimension5xs
-    public static let spaceRowGapWithIconTall = dimension7xs
-    public static let spaceRowGapWithIconShorter = dimension10xs
-    public static let spaceRowGapWithIconShort = dimension9xs
+    public static let spaceRowGapWithIconTall = dimension5xs
+    public static let spaceRowGapWithIconShortest = dimension10xs
+    public static let spaceRowGapWithIconShorter = dimension9xs
+    public static let spaceRowGapWithIconShort = dimension8xs
    public static let spaceRowGapWithIconNone = dimensionNone
-    public static let spaceRowGapWithIconMedium = dimension8xs
-    public static let spaceRowGapTaller = dimension5xs
-    public static let spaceRowGapTall = dimension7xs
-    public static let spaceRowGapShorter = dimension10xs
-    public static let spaceRowGapShort = dimension9xs
+    public static let spaceRowGapWithIconMedium = dimension7xs
+    public static let spaceRowGapTall = dimension5xs
+    public static let spaceRowGapShortest = dimension10xs
+    public static let spaceRowGapShorter = dimension9xs
+    public static let spaceRowGapShort = dimension8xs
    public static let spaceRowGapNone = dimensionNone
-    public static let spaceRowGapMedium = dimension8xs
+    public static let spaceRowGapMedium = dimension7xs
    public static let spacePaddingInlineWithIconTallest = dimension2xs
    public static let spacePaddingInlineWithIconTaller = dimension3xs
-    public static let spacePaddingInlineWithIconTall = dimension5xs
+    public static let spacePaddingInlineWithIconTall = dimension4xs
    public static let spacePaddingInlineWithIconShortest = dimension10xs
    public static let spacePaddingInlineWithIconShorter = dimension9xs
-    public static let spacePaddingInlineWithIconShort = dimension8xs
+    public static let spacePaddingInlineWithIconShort = dimension7xs
    public static let spacePaddingInlineWithIconNone = dimensionNone
-    public static let spacePaddingInlineWithIconMedium = dimension7xs
+    public static let spacePaddingInlineWithIconMedium = dimension5xs
    public static let spacePaddingInlineWithArrowTallest = dimension3xs
    public static let spacePaddingInlineWithArrowTaller = dimension4xs
-    public static let spacePaddingInlineWithArrowTall = dimension6xs
+    public static let spacePaddingInlineWithArrowTall = dimension5xs
    public static let spacePaddingInlineWithArrowShortest = dimension10xs
    public static let spacePaddingInlineMedium = dimension5xs
-    public static let spacePaddingBlockWithIconTallest = dimension5xs
-    public static let spacePaddingBlockWithIconTaller = dimension6xs
-    public static let spacePaddingBlockWithIconTall = dimension7xs
-    public static let spacePaddingBlockWithIconShorter = dimension10xs
-    public static let spacePaddingBlockWithIconShort = dimension9xs
+    public static let spacePaddingBlockWithIconTaller = dimension5xs
+    public static let spacePaddingBlockWithIconTall = dimension6xs
+    public static let spacePaddingBlockWithIconShortest = dimension10xs
+    public static let spacePaddingBlockWithIconShorter = dimension9xs
+    public static let spacePaddingBlockWithIconShort = dimension8xs
    public static let spacePaddingBlockWithIconNone = dimensionNone
-    public static let spacePaddingBlockWithIconMedium = dimension8xs
+    public static let spacePaddingBlockWithIconMedium = dimension7xs
    public static let spacePaddingBlockTallest = dimensionXs
    public static let spaceInsetMedium = dimension6xs
-    public static let spaceColumnGapWithIconTaller = dimension5xs
-    public static let spaceColumnGapWithIconTall = dimension7xs
-    public static let spaceColumnGapWithIconShorter = dimension10xs
-    public static let spaceColumnGapWithIconShort = dimension9xs
+    public static let spaceColumnGapWithIconTall = dimension5xs
+    public static let spaceColumnGapWithIconShortest = dimension10xs
+    public static let spaceColumnGapWithIconShorter = dimension9xs
+    public static let spaceColumnGapWithIconShort = dimension8xs
    public static let spaceColumnGapWithIconNone = dimensionNone
-    public static let spaceColumnGapWithIconMedium = dimension8xs
-    public static let spaceColumnGapWithArrowTaller = dimension5xs
-    public static let spaceColumnGapWithArrowTall = dimension7xs
-    public static let spaceColumnGapWithArrowShorter = dimension10xs
-    public static let spaceColumnGapWithArrowShort = dimension9xs
+    public static let spaceColumnGapWithIconMedium = dimension7xs
+    public static let spaceColumnGapWithArrowTall = dimension5xs
+    public static let spaceColumnGapWithArrowShortest = dimension10xs
+    public static let spaceColumnGapWithArrowShorter = dimension9xs
+    public static let spaceColumnGapWithArrowShort = dimension8xs
    public static let spaceColumnGapWithArrowNone = dimensionNone
-    public static let spaceColumnGapWithArrowMedium = dimension8xs
-    public static let spaceColumnGapTaller = dimensionNone
-    public static let spaceColumnGapTall = dimensionNone
-    public static let spaceColumnGapShorter = dimensionNone
-    public static let spaceColumnGapShort = dimensionNone
+    public static let spaceColumnGapWithArrowMedium = dimension7xs
+    public static let spaceColumnGapTaller = dimensionXs
+    public static let spaceColumnGapTall = dimension3xs
+    public static let spaceColumnGapShorter = dimension9xs
+    public static let spaceColumnGapShort = dimension7xs
    public static let spaceColumnGapNone = dimensionNone
-    public static let spaceColumnGapMedium = dimensionNone
+    public static let spaceColumnGapMedium = dimension5xs
}
@julien-deramond julien-deramond added the 📀 token Related to tokens (raws, semantics or components) label Oct 7, 2024
@pylapp pylapp self-assigned this Oct 7, 2024
@pylapp pylapp changed the title Spacing semantic tokens update (Oct, 7) [Token] Spacing semantic tokens update (Oct, 7) Oct 7, 2024
pylapp added a commit that referenced this issue Oct 7, 2024
@pylapp
refactor: version of October 7th update for spacing semantic tokens (#…
d9d9138 
…174)

Closes #174

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp mentioned this issue Oct 7, 2024
Merged
9 tasks
@pylapp pylapp linked a pull request Oct 7, 2024 that will close this issue
[#155] [#156] [#169] [#170] [#172] [#173] [#174] Update tokens with values of tokenator generated at October 4th and 7th #175
Merged
9 tasks
pylapp added a commit that referenced this issue Oct 7, 2024
@pylapp
refactor: version of October 7th update for spacing semantic tokens (#…
90f0e23 
…174)

Closes #174

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
ludovic35 pushed a commit that referenced this issue Oct 7, 2024
@pylapp
refactor: apply tokens of October 4th and 7th generation (#155, #156, #…
1522281 
…169, #170, #172, #173, #174) (#175)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
Copy link
Member

pylapp commented Oct 7, 2024

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers if you don't have access.

  • Display name: OUDS Showcase ALPHA (155, 156, 169, 170, 172, 173, 174)
  • Version: 0.4.0
  • Build number: 1728313283
  • Build tag: 1522281
  • Build type: ALPHA
  • Build details (GitHub): 155, 156, 169, 170, 172, 173, 174

cc @B3nz01d @pylapp @ludovic35 @Tayebsed93 @mccart77

This is an automated message sent with love and Fastlane from our CI/CD pipeline 🤘

@pylapp pylapp mentioned this issue Oct 18, 2024
Merged
pylapp added a commit that referenced this issue Oct 18, 2024
@pylapp @ludovic35 @Tayebsed93
Release 0.4.0 (#206)
c8da6ec 
Release of version 0.4.0
See below the full CHANGELOG details.

Added

- [DemoApp] Update opacity screen with new design ([#200](#200))
- [DemoApp] Add color tokens screen in demo app ([#152](#152))
- [Library] Add semantic tokens `spacePaddingInlineTallest`, `spacePaddingBlockTallest`, `spaceColumnGapTaller`, `spaceColumnGapWithArrowShortest`, `spaceRowGapShortest` (Figjam final synchronization of October 16th)
- [Library] Add semantic color tokens ([#124](#124))
- [DemoApp] Fix some design issues and mutualize some UI elements ([#189](#189))
- [DemoApp] Add sizing tokens screen in demo app ([#150](#150))
- [DemoApp] Add spacing tokens screen in demo app ([#149](#149))
- [Library] Add color semantic tokens `colorContentTransparentDefault`, `colorBorderTransparentDefault` and `colorBackgroundTransparentDefault` (October 8th) ([#177](#177))
- [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](#157))

Changed

- [Library] Update of semantic typography tokens (Figjam final synchronization of October 16th)
- [Library] Update of semantic grid tokens `gridExtraCompactColumnCount`, `gridCompactColumnGap`, `gridRegularColumnGap` (Figjam final synchronization of October 16th)
- [Library] Update of semantic elevation token `elevationStickyNavigationScrolled` (Figjam final synchronization of October 16th)
- [Library] Update of semantic color tokens, semantic sizing tokens (Figjam final synchronization of October 16th)
- [Library/DemoApp] Updates SwiftLint rules, fix linter warnings ([#143](#143))
- [Tool] Update the templates for GitHub issues
- [Tool] Improve script for documentation generation ([#168](#168))
- [Library] Rename raw brand-specific color tokens in Orange theme (no use of "brand" word) ([#179](#179))
- [Library] `fontLetterSpacingMobile*` and `fontLetterSpacingTablet*` merged in `MultipleFontLetterSpacingTokens` objects
- [Library] `fontLineHeightMobile*` and `fontLineHeightTablet*` merged in `MultipleFontLineHeightTokens` objects
- [Library] `fontSizeMobile*` and `fontSizeTablet*` merged in `MultipleFontSizeTokens` objects 
- [Library] Update semantic and raw tokens for fonts ([#155](#155))
- [Library] Update semantic tokens for fonts (October 7th) ([#172](#172))
- [Library] Update raw tokens for fonts (October 7th) ([#170](#170))
- [Library] Any semantic token of sizing `TypeXXX` has been replaced by `TypeSizeXXX` (update of October 7th)
- [Library] Any semantic tokens of sizing `WithTypeXXX` has been replaced by `TypzeXXX` (update of October 7th)
- [Library] Update semantic tokens for sizing (October 7th) ([#173](#173))
- [Library] Any semantic tokens of spacing `isIcon` and `isArrow` are now `withIcon` and `withArrow` (update of October 7th)
- [Library] Update semantic tokens for spacing (October 4th) ([#174](#174))
- [Library] Update semantic tokens for spacing (October 4th) ([#156](#156))
- [Library] Update raw tokens for dimensions (October 7th) ([#169](#169))

Removed

- [Library] Raw typography token `fontSize100` (Figjam final synchronization of October 16th)
- [Library] Semantic token `spaceColumnGapWithArrowTaller` (Figjam final synchronization of October 16th)
- [Library] Remove all color alias semantic tokens and any optional color tokens type uses
- [Library] `SoshTheme` ([#180](#180))
- [Library] `fontSizeMobile*`, `fontSizeTablet*`, `fontLineHeightMobile*`, `fontLineHeightTablet*`, `fontLetterSpacingMobile*`, `fontLetterSpacingTablet*` removed (update of October 4th)
- [Library] `spaceRowGapWithIconTaller`, `spaceColumnGapWithIconTaller` removed (update of October 7th)

Fixed

- [Library] `typeBodyDefaultLarge` font weight ([#191](#191))

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Tayeb Sedraia <[email protected]>
@pylapp
Copy link
Member

pylapp commented Oct 18, 2024

ℹ️ Released with version v0.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
📀 token Related to tokens (raws, semantics or components)
Projects
None yet
Milestone
No milestone
2 participants
@pylapp @julien-deramond